CID 351290: Control flow issues (DEADCODE)
3a650d97's removal of result = isc_app_ctxrun(client->actx);
seems to be the change which triggered Coverity Scan to report this on main
:
*** CID 351290: Control flow issues (DEADCODE)
/lib/dns/client.c: 1027 in dns_client_resolve()
1021 if (!client->readydone) {
1022 WAIT(&client->ready, &client->readylock);
1023 }
1024 UNLOCK(&client->readylock);
1025
1026 LOCK(&resarg->lock);
>>> CID 351290: Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "result == ISC_R_SUSPEND" inside this statement: "if (result == ISC_R_SUCCESS...".
1027 if (result == ISC_R_SUCCESS || result == ISC_R_SUSPEND) {
1028 result = resarg->result;
1029 }
1030 if (result != ISC_R_SUCCESS && resarg->vresult != ISC_R_SUCCESS) {
1031 /*
1032 * If this lookup failed due to some error in DNSSEC