Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 616
    • Issues 616
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 94
    • Merge requests 94
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Issues
  • #3273
Closed
Open
Issue created Apr 11, 2022 by Tony Finch@fanfDeveloper

Refactor `dns_rdataset_t->privateN`

The generic dns_rdataset_t structure has a number of private fields that are (according to the comment before their declarations) "for use by the rdataset implementation, and MUST NOT be changed by clients." That suggests they should only be used by dns_rdatalist_t and the rdataslab implementation (which is largely in rbtdb.c). However, the privateN fields are also used by:

  • dnsrps.c
  • keytable.c
  • ncache.c
  • sdb.c
  • sdlz.c

It is not clear what each privateN field is for, which code owns which fields, whether or not there are clashes (or how developers can be sure to avoid them).

This is one of the work items tracked in #3268

Edited Apr 28, 2022 by Tony Finch
Assignee
Assign to
Time tracking