Skip to content

GitLab

BIND
BIND
Open
Opened by Michał Kępień@michalMaintainer0 of 9 tasks completed0/9 tasks
Report abuse New issue

Further refactoring of functions in lib/dns/zoneverify.c

Certain review comments in !291 (merged) were related to code which was not introduced by that MR, but rather just moved around. The following comments should thus be addressed:

  • @ondrej started a discussion: (+1 comment)

    This block is little bit confusing (triggering warning condition on ISC_R_SUCCESS), is there a reason why not to move the whole block before the break where it really logically belongs?

  • @ondrej started a discussion: (+1 comment)

    Also this sort of calls for a helper static functions similar to innsec3params().

  • @ondrej started a discussion: (+1 comment)

    Perhaps use = { 0 }; and remove memset?

  • @ondrej started a discussion: (+1 comment)

    Use sizeof(set_algorithms) instead of arbitrary number.

  • @ondrej started a discussion: (+1 comment)

    = { 0 };

  • @ondrej started a discussion: (+3 comments)

    goto done; as in previous functions instead of cut&copy code?

  • @ondrej started a discussion: (+1 comment)

    This seems awfully similar to just calling !chain_equal().

  • @ondrej started a discussion: (+1 comment)

    This is so fragile.

  • @ondrej started a discussion: (+1 comment)

    Perhaps 255 should be a constant with a descriptive name?

Edited by Michał Kępień