The one place for your designs
To enable design management, you'll need to meet the requirements. If you need help, reach out to our support team for assistance.
Further refactoring of functions in lib/dns/zoneverify.c
Certain review comments in !291 (merged) were related to code which was not introduced by that MR, but rather just moved around. The following comments should thus be addressed:
-
@ondrej started a discussion: (+1 comment)
This block is little bit confusing (triggering warning condition on ISC_R_SUCCESS), is there a reason why not to move the whole block before the
breakwhere it really logically belongs? -
@ondrej started a discussion: (+1 comment)
Also this sort of calls for a helper static functions similar to
innsec3params(). -
@ondrej started a discussion: (+1 comment)
Perhaps use
= { 0 };and remove memset? -
@ondrej started a discussion: (+1 comment)
Use
sizeof(set_algorithms)instead of arbitrary number. -
@ondrej started a discussion: (+1 comment)
= { 0 }; -
@ondrej started a discussion: (+3 comments)
goto done;as in previous functions instead of cut© code? -
@ondrej started a discussion: (+1 comment)
This seems awfully similar to just calling
!chain_equal(). -
@ondrej started a discussion: (+1 comment)
This is so fragile.
-
@ondrej started a discussion: (+1 comment)
Perhaps
255should be a constant with a descriptive name?