Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 587
    • Issues 587
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 96
    • Merge requests 96
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Issues
  • #3551
Closed
Open
Issue created Sep 21, 2022 by Mark Andrews@markaOwner

Missing RSA_free call in opensslrsa_verify2

If e == NULL then we should be freeing rsa. I don't believe that there is a path where we construct a rsa key without e and thereby trigger this path but marking confidential until that review is done. This was reported by Seth Arnold seth.arnold@canonical.com.

#if OPENSSL_VERSION_NUMBER < 0x30000000L
        rsa = EVP_PKEY_get1_RSA(pkey);
        if (rsa == NULL) {
                return (dst__openssl_toresult(DST_R_OPENSSLFAILURE));
        }
        RSA_get0_key(rsa, NULL, &e, NULL);
        if (e == NULL) {
                return (dst__openssl_toresult(DST_R_VERIFYFAILURE));
        }
        bits = BN_num_bits(e);
        RSA_free(rsa);
#else
Edited Sep 21, 2022 by Mark Andrews
Assignee
Assign to
Time tracking