Skip to content

GitLab

BIND
BIND
Closed
Opened by Stephen Morris@stephen
Report abuse New issue

Missing dereference in REQUIRE statement?

Caught by cppcheck:

File lib/isccfg/parser.c:

isc_result_t
cfg_parse_boolean(cfg_parser_t *pctx, const cfg_type_t *type, cfg_obj_t **ret)
{
	isc_result_t result;
	isc_boolean_t value;
	cfg_obj_t *obj = NULL;

	REQUIRE(pctx != NULL);
	REQUIRE(ret != NULL && ret != NULL);

The check on ret in the last line is repeated. Should that read:

	REQUIRE(ret != NULL && *ret != NULL);

?