Missing check in acl_test.c unit test
The Jenkins cppcheck job reports that a variable in acl_test.c is assigned a value that is never used. The code in question is at line 93 and is:
090 result = dns_acl_create(mctx, 1, ¬geoip); 091 ATF_REQUIRE_EQ(result, ISC_R_SUCCESS); 092 093 result = dns_acl_merge(notgeoip, geoip, ISC_FALSE); 094 #endif 095 096 ATF_CHECK(dns_acl_isinsecure(any)); /* any; */
It would seem that an ATF_REQUIRE_EQ check is required after the call to dns_acl_merge.