Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 615
    • Issues 615
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Issues
  • #465
Closed
Open
Issue created Aug 07, 2018 by Stephen Morris@stephen

Missing check in acl_test.c unit test

The Jenkins cppcheck job reports that a variable in acl_test.c is assigned a value that is never used. The code in question is at line 93 and is:

090   result = dns_acl_create(mctx, 1, &notgeoip);
091   ATF_REQUIRE_EQ(result, ISC_R_SUCCESS);
092 
093   result = dns_acl_merge(notgeoip, geoip, ISC_FALSE);
094 #endif
095 
096   ATF_CHECK(dns_acl_isinsecure(any));    /* any; */

It would seem that an ATF_REQUIRE_EQ check is required after the call to dns_acl_merge.

Assignee
Assign to
Time tracking