data race in memmove

Job #4725134 failed for 193acd27 in the upforw system test and TSAN report emerged as well (those two may not be related).

2024-09-10 13:42:15 INFO:upforwd.test_upforwd     I:checking update forwarding with sig0 (Do53 -> Do53) (23)
2024-09-10 13:42:15 INFO:upforwd.test_upforwd     I:failed
2024-09-10 13:42:15 INFO:upforwd.test_upforwd     I:waiting for servers to incorporate changes
2024-09-10 13:42:24 INFO:upforwd.test_upforwd     I:exceeded time limit waiting for literal 'committing update transaction' in ns1/named.run

named.run

WARNING: ThreadSanitizer: data race 
  Read of size 8 at 0x000000000001 by thread T0001:
    #0 memmove <null> (BuildId: 4037c6a3ca411fc7713f28ef5e1cb780845c5d8e)
    #1 memmove /usr/include/bits/string_fortified.h:36 (BuildId: c5c98ed2cef72afb7a6b3f85932710dd7db75c20)
    #2 dns_dnssec_verifymessage lib/dns/dnssec.c:988
    #3 dns_message_checksig lib/dns/message.c:3358 (BuildId: c5c98ed2cef72afb7a6b3f85932710dd7db75c20)
    #4 checksig_run lib/dns/message.c:3225 (BuildId: c5c98ed2cef72afb7a6b3f85932710dd7db75c20)
    #5 isc__work_cb lib/isc/work.c:30 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #6 uv__queue_work src/threadpool.c:351 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)
    #7 worker src/threadpool.c:122 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)

  Previous write of size 8 at 0x000000000001 by thread T0002:
    #0 recvmsg <null> (BuildId: 4037c6a3ca411fc7713f28ef5e1cb780845c5d8e)
    #1 uv__udp_recvmsg src/unix/udp.c:252 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)
    #2 uv__udp_io src/unix/udp.c:142
    #3 uv__io_poll src/unix/linux.c:1528 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)
    #4 uv_run src/unix/core.c:448 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)
    #5 loop_thread lib/isc/loop.c:288 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #6 thread_body lib/isc/thread.c:85 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #7 thread_run lib/isc/thread.c:100

  Location is heap block of size 1310732 at 0x000000000015 allocated by main thread:
    #0 malloc <null> (BuildId: 4037c6a3ca411fc7713f28ef5e1cb780845c5d8e)
    #1 mallocx lib/isc/jemalloc_shim.h:41 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #2 mem_get lib/isc/mem.c:303
    #3 isc__mem_get lib/isc/mem.c:654
    #4 isc_netmgr_create netmgr/netmgr.c:216 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #5 isc_managers_create lib/isc/managers.c:31 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #6 create_managers bin/named/main.c:1020 (BuildId: cec1d953f9b8d6b77f6d790c351cde1e2e072213)
    #7 setup bin/named/main.c:1251
    #8 main bin/named/main.c:1515

  Thread T0001 (running) created by thread T0003 at:
    #0 pthread_create <null> (BuildId: 4037c6a3ca411fc7713f28ef5e1cb780845c5d8e)
    #1 uv_thread_create_ex src/unix/thread.c:172 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)
    #2 init_threads src/threadpool.c:234 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)
    #3 init_once src/threadpool.c:261
    #4 pthread_once <null> (BuildId: 4037c6a3ca411fc7713f28ef5e1cb780845c5d8e)
    #5 uv_once src/unix/thread.c:433 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)
    #6 uv__work_submit src/threadpool.c:270 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)
    #7 uv_queue_work src/threadpool.c:379
    #8 isc_work_enqueue lib/isc/work.c:70 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #9 axfr_commit lib/dns/xfrin.c:399 (BuildId: c5c98ed2cef72afb7a6b3f85932710dd7db75c20)
    #10 xfr_rr lib/dns/xfrin.c:851
    #11 xfrin_recv_done lib/dns/xfrin.c:1911
    #12 tcp_recv_processall lib/dns/dispatch.c:748 (BuildId: c5c98ed2cef72afb7a6b3f85932710dd7db75c20)
    #13 tcp_recv lib/dns/dispatch.c:891 (BuildId: c5c98ed2cef72afb7a6b3f85932710dd7db75c20)
    #14 streamdns_on_complete_dnsmessage netmgr/streamdns.c:163 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #15 streamdns_on_dnsmessage_data_cb netmgr/streamdns.c:223
    #16 isc__dnsstream_assembler_callcb include/isc/dnsstream.h:306 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #17 isc__dnsstream_assembler_handle_message include/isc/dnsstream.h:353
    #18 isc__dnsstream_assembler_processing include/isc/dnsstream.h:370 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #19 isc__dnsstream_assembler_incoming_direct include/isc/dnsstream.h:396
    #20 isc_dnsstream_assembler_incoming include/isc/dnsstream.h:508
    #21 streamdns_handle_incoming_data netmgr/streamdns.c:259
    #22 streamdns_readcb netmgr/streamdns.c:574 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #23 isc___nm_readcb netmgr/netmgr.c:1859 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #24 isc__nm_readcb netmgr/netmgr.c:1874
    #25 isc__nm_tcp_read_cb netmgr/tcp.c:778 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #26 uv__read src/unix/stream.c:1143 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)
    #27 uv__stream_io src/unix/stream.c:1203 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)
    #28 uv__io_poll src/unix/linux.c:1528 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)
    #29 uv_run src/unix/core.c:448 (BuildId: 14a6f2780ed7d1a14ef3e9047a5f805571e2a626)
    #30 loop_thread lib/isc/loop.c:288 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #31 thread_body lib/isc/thread.c:85 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #32 thread_run lib/isc/thread.c:100

  Thread T0002 'isc-loop-0001' (running) created by main thread at:
    #0 pthread_create <null> (BuildId: 4037c6a3ca411fc7713f28ef5e1cb780845c5d8e)
    #1 isc_thread_create lib/isc/thread.c:139 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #2 isc_loopmgr_run lib/isc/loop.c:456 (BuildId: 176b4915a7ceecf36fbb56f92b348c0210312be2)
    #3 main bin/named/main.c:1529 (BuildId: cec1d953f9b8d6b77f6d790c351cde1e2e072213)

SUMMARY: ThreadSanitizer: data race (BuildId: 4037c6a3ca411fc7713f28ef5e1cb780845c5d8e) in memmove