Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 577
    • Issues 577
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 111
    • Merge requests 111
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Issues
  • #744
Closed
Open
Issue created Nov 27, 2018 by Witold Krecicki@wpkContributor

Fix a race in socket code

in socket.c we have:

        if (SOCK_DEAD(sock)) { /* Sock is being closed, bail */
                goto unlock_fd;
        }

        isc_refcount_increment(&sock->references);

However, if between SOCK_DEAD and isc_refcount_increment something will close the socket (decreasing refcount to 0) we'll have an ugly race.

The proper way to fix it should be to hold a reference for socket in thread->fds[fd].

Assignee
Assign to
Time tracking