BIND merge requestshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests2019-10-03T07:32:29Zhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/2403Add Cppcheck job to the CI2019-10-03T07:32:29ZOndřej SurýAdd Cppcheck job to the CIThis MR changes the default Debian sid build to wrap make with bear
that creates compilation database and use the compilation database
to run Cppcheck on the source files systematically.
The job is currently set to be allowed to fail as...This MR changes the default Debian sid build to wrap make with bear
that creates compilation database and use the compilation database
to run Cppcheck on the source files systematically.
The job is currently set to be allowed to fail as it will take some
time to fix all the Cppcheck detected issues.November 2019 (9.11.13, 9.14.8, 9.15.6)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/2453In developer mode assert if statistics counter underflows2022-02-25T13:59:46ZMatthijs Mekkingmatthijs@isc.orgIn developer mode assert if statistics counter underflowsCloses #1087Closes #1087April 2022 (9.16.28, 9.16.28-S1, 9.18.2, 9.19.0)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/2707Resolve "always check return from isc_refcount_decrement"2020-08-04T09:44:55ZMark AndrewsResolve "always check return from isc_refcount_decrement"Closes #1456Closes #1456August 2020 (9.11.22, 9.11.22-S1, 9.16.6, 9.17.4)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/2943Cleanup support for specifying PKCS#11 engine as part of the label2020-02-11T07:46:28ZOndřej SurýCleanup support for specifying PKCS#11 engine as part of the labelThe code for specifying OpenSSL PKCS#11 engine as part of the label
(e.g. -l "pkcs11:token=..." instead of -E pkcs11 -l "token=...")
was non-functional. This commit just cleans the related code.The code for specifying OpenSSL PKCS#11 engine as part of the label
(e.g. -l "pkcs11:token=..." instead of -E pkcs11 -l "token=...")
was non-functional. This commit just cleans the related code.February 2020 (9.11.16, 9.14.11, 9.16.0, 9.16.0-S)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/2969Fix cppcheck 1.90 warnings2020-02-07T13:46:22ZMatthijs Mekkingmatthijs@isc.orgFix cppcheck 1.90 warningsCloses #1590Closes #1590February 2020 (9.11.16, 9.14.11, 9.16.0, 9.16.0-S)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/2997Cppcheck 1.90 warnings v9 142020-02-07T13:47:21ZMatthijs Mekkingmatthijs@isc.orgCppcheck 1.90 warnings v9 14February 2020 (9.11.16, 9.14.11, 9.16.0, 9.16.0-S)Matthijs Mekkingmatthijs@isc.orgMatthijs Mekkingmatthijs@isc.orghttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3001Cppcheck 1.90 warnings v9 112020-02-08T15:32:37ZMatthijs Mekkingmatthijs@isc.orgCppcheck 1.90 warnings v9 11February 2020 (9.11.16, 9.14.11, 9.16.0, 9.16.0-S)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3025Various little coccinelle improvements2020-02-10T09:49:03ZOndřej SurýVarious little coccinelle improvementsFebruary 2020 (9.11.16, 9.14.11, 9.16.0, 9.16.0-S)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3026NULL the destroyed pointer early2020-02-10T10:34:39ZOndřej SurýNULL the destroyed pointer earlyFebruary 2020 (9.11.16, 9.14.11, 9.16.0, 9.16.0-S)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3033[v9_14] Cleanup support for specifying PKCS#11 engine as part of the label2020-02-11T10:13:58ZMichał Kępień[v9_14] Cleanup support for specifying PKCS#11 engine as part of the labelFebruary 2020 (9.11.16, 9.14.11, 9.16.0, 9.16.0-S)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3034[v9_11] Cleanup support for specifying PKCS#11 engine as part of the label2020-02-11T10:51:44ZMichał Kępień[v9_11] Cleanup support for specifying PKCS#11 engine as part of the labelFebruary 2020 (9.11.16, 9.14.11, 9.16.0, 9.16.0-S)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3060Merge branch '46-add-curly-braces' into 'master'2020-02-13T22:44:04ZOndřej SurýMerge branch '46-add-curly-braces' into 'master'Add curly braces using uncrustify and then reformat with clang-format back
Closes #46
See merge request isc-projects/bind9!3057
(cherry picked from commit 67b68e06ad6f3799872cd79de999276df1e1e872)
36c6105e Use coccinelle to add brace...Add curly braces using uncrustify and then reformat with clang-format back
Closes #46
See merge request isc-projects/bind9!3057
(cherry picked from commit 67b68e06ad6f3799872cd79de999276df1e1e872)
36c6105e Use coccinelle to add braces to nested single line statement
d14bb713 Add copy of run-clang-tidy that can fixup the filepaths
056e133c Use clang-tidy to add curly braces around one-line statementsMarch 2020 (9.11.17, 9.16.1, 9.17.0)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3285Fix new warnings reported by scan-build from LLVM/Clang 102020-04-09T12:44:42ZOndřej SurýFix new warnings reported by scan-build from LLVM/Clang 10April 2020 (9.11.18, 9.16.2, 9.17.1)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3296Fix 'Dead nested assignment' from scan-build-102020-03-26T13:10:07ZOndřej SurýFix 'Dead nested assignment' from scan-build-10This is the warning:
```
In file included from print_test.c:47:
./../print.c:203:9: warning: Although the value stored to 'neg' is used in the enclosing expression, the value is never actually read from 'neg'
dot = ...This is the warning:
```
In file included from print_test.c:47:
./../print.c:203:9: warning: Although the value stored to 'neg' is used in the enclosing expression, the value is never actually read from 'neg'
dot = neg = space = plus = left = zero = alt = h = l = q = z = 0;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```April 2020 (9.11.18, 9.16.2, 9.17.1)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3297Fix new warnings reported by scan-build from LLVM/Clang 10 (v9.14) v22020-03-26T12:51:51ZOndřej SurýFix new warnings reported by scan-build from LLVM/Clang 10 (v9.14) v2April 2020 (9.11.18, 9.16.2, 9.17.1)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3311Add python static analysis to GitLab CI2020-04-29T13:16:11ZOndřej SurýAdd python static analysis to GitLab CIThis adds flake8 and pylint to the GitLab CI.
There's an exception for existing `ans.py` scripts for the moment, but that needs to be fixed eventually too.
This adds flake8 and pylint to the GitLab CI.
There's an exception for existing `ans.py` scripts for the moment, but that needs to be fixed eventually too.
May 2020 (9.11.19, 9.11.19-S1, 9.14.12, 9.16.3)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3335Address Coverity warnings in keymgr.c2020-04-20T07:42:28ZMatthijs Mekkingmatthijs@isc.orgAddress Coverity warnings in keymgr.cCoverity showed that the return value of `dst_key_gettime` was
unchecked in INITIALIZE_STATE. If DST_TIME_CREATED was not set we
would set the state to be initialized to a weird last changed time.
This would normally not happen because ...Coverity showed that the return value of `dst_key_gettime` was
unchecked in INITIALIZE_STATE. If DST_TIME_CREATED was not set we
would set the state to be initialized to a weird last changed time.
This would normally not happen because DST_TIME_CREATED is always
set. However, we would rather set the time to now (as the comment
also indicates) not match the creation time.
The comment on INITIALIZE_STATE also needs updating as we no
longer always initialize to HIDDEN.
Closes #1737May 2020 (9.11.19, 9.11.19-S1, 9.14.12, 9.16.3)Matthijs Mekkingmatthijs@isc.orgMatthijs Mekkingmatthijs@isc.orghttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3403Address Coverity warnings in keymgr.c2020-04-29T11:50:55ZMatthijs Mekkingmatthijs@isc.orgAddress Coverity warnings in keymgr.cCoverity showed that the return value of `dst_key_gettime` was
unchecked in INITIALIZE_STATE. If DST_TIME_CREATED was not set we
would set the state to be initialized to a weird last changed time.
This would normally not happen because ...Coverity showed that the return value of `dst_key_gettime` was
unchecked in INITIALIZE_STATE. If DST_TIME_CREATED was not set we
would set the state to be initialized to a weird last changed time.
This would normally not happen because DST_TIME_CREATED is always
set. However, we would rather set the time to now (as the comment
also indicates) not match the creation time.
The comment on INITIALIZE_STATE also needs updating as we no
longer always initialize to HIDDEN.
(cherry picked from commit 564f9dca3578234214eaffc4f6220a73315dde8f)
Closes #1737May 2020 (9.11.19, 9.11.19-S1, 9.14.12, 9.16.3)Matthijs Mekkingmatthijs@isc.orgMatthijs Mekkingmatthijs@isc.orghttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3415Add configuration for LGTM.com static code analyzer2020-04-29T13:13:10ZOndřej SurýAdd configuration for LGTM.com static code analyzerMay 2020 (9.11.19, 9.11.19-S1, 9.14.12, 9.16.3)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3498Fix outstanding cppcheck errors2020-05-05T05:08:27ZEvan HuntFix outstanding cppcheck errorslib/dns/sdb.c:1145:warning: Either the condition '(sdb)!=((void*)0)' is
redundant or there is possible null pointer dereference: sdb."
lib/dns/sdb.c:1208: Either the condition '(node)!=((void*)0)' is
redundant or there is possible null ...lib/dns/sdb.c:1145:warning: Either the condition '(sdb)!=((void*)0)' is
redundant or there is possible null pointer dereference: sdb."
lib/dns/sdb.c:1208: Either the condition '(node)!=((void*)0)' is
redundant or there is possible null pointer dereference: sdbnode.May 2020 (9.11.19, 9.11.19-S1, 9.14.12, 9.16.3)Evan HuntEvan Hunt