BIND merge requestshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests2024-03-15T09:12:31Zhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8832Rewrite rrchecker system test to pytest2024-03-15T09:12:31ZMichal NowakRewrite rrchecker system test to pytestApril 2024 (9.16.50, 9.16.50-S1, 9.18.26, 9.18.26-S1, 9.19.23)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8239system tests stability tweaks and cleanup2024-03-14T15:27:56ZTom Krizeksystem tests stability tweaks and cleanupThis MR is a collection of smaller unrelated fixes & improvements for system tests.
---
- disable checkds test for unsupported python version, closes #3001
- followup cleanup for recent pytest runner changes, related !8193, !8194
- re...This MR is a collection of smaller unrelated fixes & improvements for system tests.
---
- disable checkds test for unsupported python version, closes #3001
- followup cleanup for recent pytest runner changes, related !8193, !8194
- re-enabling statschannel checks without checking loadtime, related #3983
---
The MR also attempts to improve CI stability by allowing re-runs of selected system tests which are known for their high false positive rate. Following tests were allowed to be re-run in case of failure:
- :white_check_mark: `qmin`, related #904
- :white_check_mark: `reclimit`, related #1587
- :white_check_mark: `rrl`, related #172
I also considered allowing re-runs for these tests, but decided against it for now:
- :x: `statschannel` - seems to be isolated to FreeBSD as of late, related #1621
- :x: `fetchlimit` - not really sure what's going on there, but it might be a candidate upon further investigation, related #3535
- :x: `autosign` - the cause seems to be randomness, but it hasn't been popping up that often #1565September 2023 (9.16.44, 9.16.44-S1, 9.18.19, 9.18.19-S1, 9.19.17)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8511Resolve "Change system tests to not use dnssec-validation auto"2024-03-08T12:01:02ZMark AndrewsResolve "Change system tests to not use dnssec-validation auto"Closes #4402Closes #4402January 2024 (9.16.46, 9.16.46-S1, 9.18.22, 9.18.22-S1, 9.19.20) (❗RECALLED❗)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8833Revert the s/rbt/qp/ change in load_names, it is still rbt2024-03-08T11:48:22ZOndřej SurýRevert the s/rbt/qp/ change in load_names, it is still rbtMarch 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8751Do not block workers when using -T transferslowly/transferstuck2024-03-08T10:54:17ZArtem BoldarievDo not block workers when using -T transferslowly/transferstuckThis commit ensures that worker threads are not sleeping (by using
select()) when '-T transferslowly/transferstuck' test options are
used. This commit converts synchronous implementation of the code into
an asynchronous one based on time...This commit ensures that worker threads are not sleeping (by using
select()) when '-T transferslowly/transferstuck' test options are
used. This commit converts synchronous implementation of the code into
an asynchronous one based on timers.
Closes https://gitlab.isc.org/isc-projects/bind9/-/issues/4566March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Artem BoldarievArtem Boldarievhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8787Resolve "Fix initial tests in masterfile system test"2024-03-07T22:01:25ZMark AndrewsResolve "Fix initial tests in masterfile system test"Closes #4604Closes #4604March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8782Watch logs from start in dialup system test2024-03-07T22:01:15ZMichal NowakWatch logs from start in dialup system testWhen the first parametrized test takes a bit longer than usual, the zone
transfer in ns3 may succeed before the second parametrized test is even
started, and then watch_log_from_here() [won't find](https://gitlab.isc.org/isc-projects/bin...When the first parametrized test takes a bit longer than usual, the zone
transfer in ns3 may succeed before the second parametrized test is even
started, and then watch_log_from_here() [won't find](https://gitlab.isc.org/isc-projects/bind9/-/jobs/4061977) the "Transfer status:
success" message in the named log. Using watch_log_from_start() instead
makes sure the test is more stable.March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8795Move RRL broken-config check to checkconf2024-03-02T00:37:38ZMatthijs Mekkingmatthijs@isc.orgMove RRL broken-config check to checkconfThe RRL test included a test case that tried to start named with a broken configuration. The same error could be found with
`named-checkconf`, so it should have been tested in the `checkconf` system test.The RRL test included a test case that tried to start named with a broken configuration. The same error could be found with
`named-checkconf`, so it should have been tested in the `checkconf` system test.March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Evan HuntEvan Hunthttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8770Rewrite dsdigest system test to pytest2024-02-23T14:22:40ZMichal NowakRewrite dsdigest system test to pytestMarch 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8676Rewrite xferquota system test to pytest2024-02-23T10:52:07ZMichal NowakRewrite xferquota system test to pytestMarch 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8684Rewrite sortlist system test to pytest2024-02-23T10:04:01ZMichal NowakRewrite sortlist system test to pytestMarch 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8742Simplify pytest logging2024-02-16T15:04:29ZTom KrizekSimplify pytest loggingPreviously, `logger` (or `mlogger`) fixture had to be requested by each test, then this logger had to be passed around to other function etc. This MR simplifies this by providing a simple interface `isctest.log.debug()` (or other log lev...Previously, `logger` (or `mlogger`) fixture had to be requested by each test, then this logger had to be passed around to other function etc. This MR simplifies this by providing a simple interface `isctest.log.debug()` (or other log levels). It also unifies the different loggers and select the most specific one.March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8696Support older junit XML format in test result processing2024-02-08T13:59:25ZTom KrizekSupport older junit XML format in test result processingWhen running `make check` on a platform which has older (but still
supported) pytest, e.g. 3.4.2 on EL8, the junit to trs conversion would
fail because the junit format has different structure. Make the junit
XML processing more lenient ...When running `make check` on a platform which has older (but still
supported) pytest, e.g. 3.4.2 on EL8, the junit to trs conversion would
fail because the junit format has different structure. Make the junit
XML processing more lenient to support both the older and newer junit
XML formats.
Closes #4560March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Tom KrizekTom Krizekhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8698Use a single local port for ditch.pl2024-02-08T12:47:24ZTom KrizekUse a single local port for ditch.plThe ditch.pl script is used to generate burst traffic without waiting
for the responses. When running other tests in parallel, this can result
in a ephemeral port clash, since the ditch.pl process closes the socket
immediately. In rare o...The ditch.pl script is used to generate burst traffic without waiting
for the responses. When running other tests in parallel, this can result
in a ephemeral port clash, since the ditch.pl process closes the socket
immediately. In rare occasions when the message ID also clashes with
other tests' queries, it might result in an UnexpectedSource error from
dnspython.
Use a dedicated port EXTRAPORT8 which is reserved for each test as a
source port for the burst traffic.
Supersedes !8694
Closes #4562March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8630Add missing dnssec-validation to ns4 in xfer test2024-02-08T08:30:40ZTom KrizekAdd missing dnssec-validation to ns4 in xfer testThis file was missing explicit dnssec-validation. Seems like it was
missed in our previous efforts, probably because of the different
filename / extension. Rename it to end with *.in to reflect that it is a
template file used by copy_set...This file was missing explicit dnssec-validation. Seems like it was
missed in our previous efforts, probably because of the different
filename / extension. Rename it to end with *.in to reflect that it is a
template file used by copy_setports.
Related #950March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Tom KrizekTom Krizekhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8636Make digdelv test work in different network envs (continued)2024-02-08T08:30:35ZArаm SаrgsyаnMake digdelv test work in different network envs (continued)This MR complements the 1e7d832342aa2aaaeb8ef1710ec095dfcade4c6d commit from the !6942 MR.This MR complements the 1e7d832342aa2aaaeb8ef1710ec095dfcade4c6d commit from the !6942 MR.March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Arаm SаrgsyаnArаm Sаrgsyаnhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8420Split up the dnsrps and native variants of rpz system tests2024-02-08T08:30:31ZTom KrizekSplit up the dnsrps and native variants of rpz system testsPreviously, dnsrps test was executed as an optional part of the rpz
and rpzrecurse system tests. This was conceptually problematic, as the
test took the responsibility of running parts of the test framework -
cleaning files and setting u...Previously, dnsrps test was executed as an optional part of the rpz
and rpzrecurse system tests. This was conceptually problematic, as the
test took the responsibility of running parts of the test framework -
cleaning files and setting up servers again.
Instead, allow these tests to execute either the native variant, or the
dnsrps one. To ensure the same test coverage, trigger both of these variants
as separate test cases from pytest.March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Tom KrizekTom Krizekhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8638Allow nsupdate test rerun on FreeBSD2024-02-08T08:29:37ZTom KrizekAllow nsupdate test rerun on FreeBSDThe "exceeded time limit waiting for literal 'too many DNS UPDATEs
queued' in ns1/named.run" is prone to fail due to a timing issue.
Despite out efforts to stabilize it, the check still often fails on
FreeBSD in our CI. Allow the test to...The "exceeded time limit waiting for literal 'too many DNS UPDATEs
queued' in ns1/named.run" is prone to fail due to a timing issue.
Despite out efforts to stabilize it, the check still often fails on
FreeBSD in our CI. Allow the test to be re-run on this platform.
Related #3846March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8649Drop queryperf support from rpz system test2024-02-08T08:29:30ZMichal NowakDrop queryperf support from rpz system testThe queryperf support in the rpz system test is not utilized in the CI,
is likely not unused at all, and should be dropped.The queryperf support in the rpz system test is not utilized in the CI,
is likely not unused at all, and should be dropped.March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8668Rewrite dialup system test to pytest2024-02-08T08:29:18ZMichal NowakRewrite dialup system test to pytestMarch 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Michal NowakMichal Nowak