BIND merge requestshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests2024-01-02T22:41:27Zhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8617Draft: Resolve "Handle multiple NSEC3PARAM records in tests"2024-01-02T22:41:27ZMark AndrewsDraft: Resolve "Handle multiple NSEC3PARAM records in tests"Closes #4516Closes #4516January 2024 (9.16.46, 9.16.46-S1, 9.18.22, 9.18.22-S1, 9.19.20) (❗RECALLED❗)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8615Resolve "System tests fail with Net::DNS 1.42"2024-01-03T01:03:31ZMark AndrewsResolve "System tests fail with Net::DNS 1.42"Closes #4513Closes #4513January 2024 (9.16.46, 9.16.46-S1, 9.18.22, 9.18.22-S1, 9.19.20) (❗RECALLED❗)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8613[9.18] Rewrite spf system test to pytest2024-03-08T11:57:58ZMichal Nowak[9.18] Rewrite spf system test to pytestBackport of MR !8572
Depends on !8611Backport of MR !8572
Depends on !8611May 2024 (9.18.27, 9.18.27-S1, 9.19.24)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8612Allow the fetchlimit test to be re-run2024-02-08T08:26:24ZTom KrizekAllow the fetchlimit test to be re-runThe test is known to be unstable due to timing issues. Prevent frequent
false positives by allowing the test to be re-run by the flaky pytest
plugin.
Closes #3535The test is known to be unstable due to timing issues. Prevent frequent
false positives by allowing the test to be re-run by the flaky pytest
plugin.
Closes #3535March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8611[9.18] Implement Python helpers for using RNDC in tests2024-03-08T11:57:23ZŠtěpán Balážik[9.18] Implement Python helpers for using RNDC in testsBackport of MR !8357Backport of MR !8357May 2024 (9.18.27, 9.18.27-S1, 9.19.24)Štěpán BalážikŠtěpán Balážikhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8599[9.16] Resolve "[GL #4494] followup: regression test was too strict" !85902024-01-04T16:58:18ZMark Andrews[9.16] Resolve "[GL #4494] followup: regression test was too strict" !8590Backport of MR !8590
Closes #4498Backport of MR !8590
Closes #4498January 2024 (9.16.46, 9.16.46-S1, 9.18.22, 9.18.22-S1, 9.19.20) (❗RECALLED❗)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8598[9.18] Resolve "[GL #4494] followup: regression test was too strict"2024-01-04T16:58:18ZMark Andrews[9.18] Resolve "[GL #4494] followup: regression test was too strict"Backport of MR !8590
Closes #4498Backport of MR !8590
Closes #4498January 2024 (9.16.46, 9.16.46-S1, 9.18.22, 9.18.22-S1, 9.19.20) (❗RECALLED❗)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8590Resolve "[GL #4494] followup: regression test was too strict"2024-01-04T16:58:18ZMark AndrewsResolve "[GL #4494] followup: regression test was too strict"Closes #4498Closes #4498January 2024 (9.16.46, 9.16.46-S1, 9.18.22, 9.18.22-S1, 9.19.20) (❗RECALLED❗)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8584[9.16] Resolve "statschannel test intermittently fails with incorrect zone lo...2023-12-18T10:57:23ZArаm Sаrgsyаn[9.16] Resolve "statschannel test intermittently fails with incorrect zone loadtime"Backport of !8569.
Closes #4477Backport of !8569.
Closes #4477January 2024 (9.16.46, 9.16.46-S1, 9.18.22, 9.18.22-S1, 9.19.20) (❗RECALLED❗)Arаm SаrgsyаnArаm Sаrgsyаnhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8583[9.18] Resolve "statschannel test intermittently fails with incorrect zone lo...2023-12-18T10:24:51ZArаm Sаrgsyаn[9.18] Resolve "statschannel test intermittently fails with incorrect zone loadtime"Backport of !8569.
Closes #4477Backport of !8569.
Closes #4477January 2024 (9.16.46, 9.16.46-S1, 9.18.22, 9.18.22-S1, 9.19.20) (❗RECALLED❗)Arаm SаrgsyаnArаm Sаrgsyаnhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8572Rewrite spf system test to pytest2024-01-04T17:07:31ZMichal NowakRewrite spf system test to pytestThe `spf` system test pytest rewrite uses the isc-projects/bind9!8357 python helpers to query `named` log.
Compared to the shell version of the `spf` system test, which is around 30 lines of code, the pytest rewrite is about twice that ...The `spf` system test pytest rewrite uses the isc-projects/bind9!8357 python helpers to query `named` log.
Compared to the shell version of the `spf` system test, which is around 30 lines of code, the pytest rewrite is about twice that size.
`test_spf_missing_lines` tests use a feature discouraged in `isctest.py`: `wait_for_line()` is expected to throw a `TimeoutError` exception and the test code acts on it.January 2024 (9.16.46, 9.16.46-S1, 9.18.22, 9.18.22-S1, 9.19.20) (❗RECALLED❗)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8569Resolve "statschannel test intermittently fails with incorrect zone loadtime"2023-12-18T09:40:39ZArаm SаrgsyаnResolve "statschannel test intermittently fails with incorrect zone loadtime"The check_loaded() function compares the zone's loadtime value and
an expected loadtime value, which is based on the zone file's mtime
extracted from the filesystem.
For the secondary zones there may be cases, when the zone file isn't
r...The check_loaded() function compares the zone's loadtime value and
an expected loadtime value, which is based on the zone file's mtime
extracted from the filesystem.
For the secondary zones there may be cases, when the zone file isn't
ready yet before the zone transfer is complete and the zone file is
dumped to the disk, so a so zero value mtime is retrieved.
In such cases wait one second and retry until timeout. Also modify
the affected check to allow a possible difference of the same amount
of seconds as the chosen timeout value.
Closes #4477January 2024 (9.16.46, 9.16.46-S1, 9.18.22, 9.18.22-S1, 9.19.20) (❗RECALLED❗)Arаm SаrgsyаnArаm Sаrgsyаnhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8539[9.16] Improve assert messages in pytests2023-12-05T15:29:13ZTom Krizek[9.16] Improve assert messages in pytestsBackport of MR !8518
Closes #4452Backport of MR !8518
Closes #4452December 2023 (9.18.21, 9.18.21-S1, 9.19.19)Tom KrizekTom Krizekhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8538[9.18] Improve assert messages in pytests2023-12-05T14:26:51ZTom Krizek[9.18] Improve assert messages in pytestsBackport of MR !8518
Closes #4452Backport of MR !8518
Closes #4452December 2023 (9.18.21, 9.18.21-S1, 9.19.19)Tom KrizekTom Krizekhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8537[9.16] Add support for recording named with rr2024-01-04T16:31:21ZMichal Nowak[9.16] Add support for recording named with rrBackport of MR !8479.
Closes #3198Backport of MR !8479.
Closes #3198January 2024 (9.16.46, 9.16.46-S1, 9.18.22, 9.18.22-S1, 9.19.20) (❗RECALLED❗)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8536[9.18] Add support for recording named with rr2023-12-04T19:51:42ZMichal Nowak[9.18] Add support for recording named with rrBackport of MR !8479.
Closes #3198Backport of MR !8479.
Closes #3198December 2023 (9.18.21, 9.18.21-S1, 9.19.19)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8524Draft: clean up files in addzone system test2024-02-24T08:08:24ZEvan HuntDraft: clean up files in addzone system testsome generated files were not cleaned up after running the test.some generated files were not cleaned up after running the test.May 2024 (9.18.27, 9.18.27-S1, 9.19.24)Evan HuntEvan Hunthttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8521Ensure no test queries leak to root server2024-02-08T08:26:07ZTom KrizekEnsure no test queries leak to root serverCloses #4445Closes #4445March 2024 (9.16.49, 9.16.49-S1, 9.18.25, 9.18.25-S1, 9.19.22)Tom KrizekTom Krizekhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8519Add an async DNS server for use in system tests2024-03-20T09:41:28ZMichał KępieńAdd an async DNS server for use in system testsImplement a new Python class, AsyncDNSServer, which can be used by
ans.py scripts placed in ansX/ system test subdirectories. This enables
conveniently starting a not-necessarily-standards-compliant,
feature-limited, custom DNS server i...Implement a new Python class, AsyncDNSServer, which can be used by
ans.py scripts placed in ansX/ system test subdirectories. This enables
conveniently starting a not-necessarily-standards-compliant,
feature-limited, custom DNS server instance. It can read and serve zone
files, but it is also able to evaluate any user-provided
query-processing logic, allowing query responses to be changed, delayed,
or dropped altogether. These are all actions commonly taken by custom
DNS servers written in Python that are used in BIND 9 system tests.
Having a single "base" implementation of such a custom DNS server
reduces code duplication, improving test maintainability.
~"DO NOT MERGE" is set because this still requires adding comments and
potentially also addressing design issues.
Attached is a sample script that uses `asyncserver.py` to implement a
dynamic AXFR generator. It is not meant to be merged, but it is meant
to serve as a brief demo of how ready-to-use components can be built on
top of the mechanisms included in this MR. (`asyncserver_axfr.py` is
able to work as an `ans.py` server once it is put into a proper `ansX/`
subdirectory in `bin/tests/system/`.)
[asyncserver_axfr.py](/uploads/bbf6c86622c64f32d7ade1e085c6b645/asyncserver_axfr.py)
The script does *not* demonstrate zone loading, which is arguably one of
the most convenient features that `asyncserver.py` brings.April 2024 (9.16.50, 9.16.50-S1, 9.18.26, 9.18.26-S1, 9.19.23)Michał KępieńMichał Kępieńhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/8518Improve assert messages in pytests2023-12-05T15:29:34ZTom KrizekImprove assert messages in pytestsEnsure that all `assert` statements in pytests produce a meaningful message in case they fail.
Closes #4452Ensure that all `assert` statements in pytests produce a meaningful message in case they fail.
Closes #4452December 2023 (9.18.21, 9.18.21-S1, 9.19.19)