BIND merge requestshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests2021-10-12T07:33:22Zhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5402continued revision of master/slave terminology to primary/secondary2021-10-12T07:33:22ZEvan Huntcontinued revision of master/slave terminology to primary/secondary- updated comments and log messages
- fixed typo "seconary" in cfg_test.c- updated comments and log messages
- fixed typo "seconary" in cfg_test.cNovember 2021 (9.16.23, 9.16.23-S1, 9.17.20)Evan HuntEvan Hunthttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5485DROPME: use staging image2021-10-12T08:39:23ZOndřej SurýDROPME: use staging imageCloses #2933Closes #2933November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5213Draft: Use nosync for CI jobs2021-10-18T12:25:50ZMichal NowakDraft: Use nosync for CI jobsThe `nosync.so` library is expected at and loaded from `/usr/local/lib`.
On Debian 10 (Buster) it does not work with GCC when ASan is used,
therefore it's disabled as long as we don't update to a newer GCC.
Validation:
- Docker images:...The `nosync.so` library is expected at and loaded from `/usr/local/lib`.
On Debian 10 (Buster) it does not work with GCC when ASan is used,
therefore it's disabled as long as we don't update to a newer GCC.
Validation:
- Docker images: https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75320
- QCOW2 images: https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75294
Image code needs to be merged first: isc-projects/images!124
## `nosync`
I ran the following pipelines ([75828](https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75828), [75829](https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75829), [75830](https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75830), [75834](https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75834), [75835](https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75835), [75836](https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75836)) with `nosync` in place when no other CI consumer was present at the moment. The following tests failed (the `gcc:asan` and ` system:gcc:tarball ` jobs are not considered because of limitations in this MR):
- `inline` in ` system:gcc:centos8:amd64 `
- `random` in ` unit:gcc:softhsm2.6 `
- `rrl` in `system:clang:freebsd12:amd64 `
- `rpz` in ` system:clang:freebsd13:amd64 `
- `kasp` and `inline` in ` system:clang:openbsd:amd64 `
- `netmgr` in ` unit:clang:tsan `
- `inline` in ` system:clang:openbsd:amd64 `
- `rrl` in ` system:clang:freebsd12:amd64 `
- `fetchlimit` in ` system:clang:openbsd:amd64 `
- `serve-fail` in ` system:clang:openbsd:amd64 `
Overall 11 failed tests out of 246 unit and system test CI jobs.
## `main`
I ran the following pipelines ([75538](https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75538), [75539](https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75539), [75540](https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75540), [75541](https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75541), [75542](https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75542), [75543](https://gitlab.isc.org/isc-projects/bind9/-/pipelines/75543)) on `main` when no other CI consumer was present at the moment. The following tests failed (contrary to the run with `nosync` the `gcc:asan` and `system:gcc:tarball` jobs were run):
- `kasp` in `system:clang:openbsd:amd64`
- `random` in `unit:gcc:asan`
- `tcp` and `mkeys` in `system:clang:freebsd11:amd64`
- `padding` in `system:clang:freebsd12:amd64`
- `rpz` in `system:clang:openbsd:amd64`
- `qmin` in `system:gcc:buster:amd64`
- `rrl` in `system:clang:freebsd13:amd64`
- `kasp` in `system:clang:openbsd:amd64`
- `acl` in `system:clang:openbsd:amd64`
- `rrl` in `system:clang:freebsd13:amd64`
- `legacy` in `system:clang:freebsd11:amd64`
Overall 12 tests failed out of 264 unit and system test CI jobs.
I think this shows that `nosync` does not make unit and system tests more stable in the CI and this enterprise should not be pursued further. It also shows that 2/3 of the failures are on FreeBSD and OpenBSD (a small portion of CI jobs with OpenBSD not having system tests in merge request-triggered pipelines, so particular problem is shielded away a bit).
Closes #2752November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Michał KępieńMichał Kępieńhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5528[v9_11] Use Fedora image for GCC ASAN and TSAN CI jobs2021-10-26T08:51:03ZMichal Nowak[v9_11] Use Fedora image for GCC ASAN and TSAN CI jobsClsoe isc-projects/bind9#2454Clsoe isc-projects/bind9#2454November 2021 (9.16.23, 9.16.23-S1, 9.17.20)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/4728Run a minimal set of system tests on Windows for merge requests2021-11-02T16:10:25ZMichal NowakRun a minimal set of system tests on Windows for merge requestsSystem test on Windows is run only for scheduled runs because the test
suite on Windows is slow and takes scarce resources. However, sometimes
BIND is broken on Windows, and we find out only the day after the code
was merged. To identify...System test on Windows is run only for scheduled runs because the test
suite on Windows is slow and takes scarce resources. However, sometimes
BIND is broken on Windows, and we find out only the day after the code
was merged. To identify a potential breakage, at least a minimal subset
of the system test suite should be run for merge requests.
Fixed https://gitlab.isc.org/isc-projects/bind9/-/issues/2519 is a prerequisite.November 2021 (9.16.23, 9.16.23-S1, 9.17.20)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5557Fix incorrect version bump in statistics channels2021-11-05T06:46:15ZPetr Špačekpspacek@isc.orgFix incorrect version bump in statistics channelsSee !5455See !5455November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Michał KępieńMichał Kępieńhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5556Resolve "CID 340918: Uninitialized variables (UNINIT)"2021-11-03T14:35:20ZMark AndrewsResolve "CID 340918: Uninitialized variables (UNINIT)"Closes #2998Closes #2998November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5553retain diff output if clang-format changes something [v9_16]2021-11-02T15:02:05ZPetr Špačekpspacek@isc.orgretain diff output if clang-format changes something [v9_16]Backport: !5543Backport: !5543November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Petr Špačekpspacek@isc.orgPetr Špačekpspacek@isc.orghttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5551Resolve "Replace instances of ARRAYSIZE with ARRAY_SIZE"2021-11-02T15:03:44ZMark AndrewsResolve "Replace instances of ARRAYSIZE with ARRAY_SIZE"Closes #2993Closes #2993November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5549Fix typo in dns_name_copy-with-result.spatch2021-11-03T14:34:51ZMichal NowakFix typo in dns_name_copy-with-result.spatchA typo introduced in f3f1cab05e05c9bdd5da91f3ab159ec6658ec7f4 prevents
execution of the `dns_name_copy-with-result.spatch`. The replacement
should end with semicolon not a colon:
plus: parse error:
File "cocci/dns_name_copy-wi...A typo introduced in f3f1cab05e05c9bdd5da91f3ab159ec6658ec7f4 prevents
execution of the `dns_name_copy-with-result.spatch`. The replacement
should end with semicolon not a colon:
plus: parse error:
File "cocci/dns_name_copy-with-result.spatch", line 28, column 23, charpos = 421
around = ':',
whole content = + dns_name_copy(E1, E2):November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5548Add comparekeys to release tarball2021-11-02T14:48:29ZMichal NowakAdd comparekeys to release tarball`make dist` omits `lib/dns/tests/comparekeys/` (added in
7101afa23cfc7cd005aeeb00802481094a0b9cf5) from release tarball it
creates which makes the [`unit:gcc:tarball`](https://gitlab.isc.org/isc-projects/bind9/-/jobs/2079960) CI job perm...`make dist` omits `lib/dns/tests/comparekeys/` (added in
7101afa23cfc7cd005aeeb00802481094a0b9cf5) from release tarball it
creates which makes the [`unit:gcc:tarball`](https://gitlab.isc.org/isc-projects/bind9/-/jobs/2079960) CI job permanently fail in the
`dst` unit test.
```
[==========] Running 2 test(s).
[ RUN ] sig_test
[ OK ] sig_test
[ RUN ] cmp_test
0x26 != 0
[ LINE ] --- dst_test.c:312: error: Failure!I:dst_test:Core dump found: ./core.11249
```November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5547Resolve "Address reports by Coverity in updated OpenSSL code"2021-11-02T14:49:35ZMark AndrewsResolve "Address reports by Coverity in updated OpenSSL code"Closes #2991Closes #2991November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5546Be less strict regarding "tls" statements in the configuration file by allowi...2021-11-02T14:47:31ZArtem BoldarievBe less strict regarding "tls" statements in the configuration file by allowing both "key-file" and "cert-file" be omittedIn the 9.17.19 release "tls" statements verification code was
added. The code was too strict and assumed that every such a statement
should have both "cert-file" and "key-file" specified. This turned out
to be a regression, as in some ca...In the 9.17.19 release "tls" statements verification code was
added. The code was too strict and assumed that every such a statement
should have both "cert-file" and "key-file" specified. This turned out
to be a regression, as in some cases we plan to use the "tls"
statement to specify TLS connection parameters.
This commit fixes this behaviour; now a "tls" statement should either
have both "cert-file" and "key-file" specified, or both should be
omitted.
The issue was mentioned mentioned in #2986:
> Another issue that got me a bit confused is that on the `tls` section of the configuration file, the parameters `cert-file` and `key-file` now seem to required, which wasn't the case in the previous version.November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Artem BoldarievArtem Boldarievhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5544remove last remaining reference to _REENTRANT macro and fix DLZ example2021-11-02T14:46:53ZPetr Špačekpspacek@isc.orgremove last remaining reference to _REENTRANT macro and fix DLZ exampleNovember 2021 (9.16.23, 9.16.23-S1, 9.17.20)Petr Špačekpspacek@isc.orgPetr Špačekpspacek@isc.orghttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5543retain diff output if clang-format changes something2021-11-02T15:05:52ZPetr Špačekpspacek@isc.orgretain diff output if clang-format changes somethingNovember 2021 (9.16.23, 9.16.23-S1, 9.17.20)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5542Add placeholder for [GL !332P]2021-11-02T14:42:51ZPetr Špačekpspacek@isc.orgAdd placeholder for [GL !332P]November 2021 (9.16.23, 9.16.23-S1, 9.17.20)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5541[v9_16] Fix a bug when comparing two RSA keys2021-11-02T14:50:24ZArаm Sаrgsyаn[v9_16] Fix a bug when comparing two RSA keysWhen comparing different parameters of two RSA keys there is a typo
which causes the "p" prime factors to not being compared.
Fix the typo.
(cherry picked from commit 930e4f52a56d501ae0deefa948d7f4b6bd5d8995)
Closes #2972When comparing different parameters of two RSA keys there is a typo
which causes the "p" prime factors to not being compared.
Fix the typo.
(cherry picked from commit 930e4f52a56d501ae0deefa948d7f4b6bd5d8995)
Closes #2972November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Arаm SаrgsyаnArаm Sаrgsyаnhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5539[v9_16] Disable PyLint warning C02092021-10-28T13:40:27ZMichał Kępień[v9_16] Disable PyLint warning C0209PyLint 2.11 reports a new warning, C0209 (consider-using-f-string).
Since f-strings are only available in Python 3.6+, existing scripts
cannot be updated to use this feature just yet because they would stop
working with older Python vers...PyLint 2.11 reports a new warning, C0209 (consider-using-f-string).
Since f-strings are only available in Python 3.6+, existing scripts
cannot be updated to use this feature just yet because they would stop
working with older Python versions. Instead, disable PyLint warning
C0209 for the time being. Sort all disabled warnings in .pylintrc.
(cherry picked from commit 860ca4e0efe3d1a2d63095e4720ccb56224b34f8)November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Michał KępieńMichał Kępieńhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5538Disable PyLint warning C02092021-10-28T13:37:39ZMichał KępieńDisable PyLint warning C0209PyLint 2.11 reports a new warning, C0209 (consider-using-f-string).
Since f-strings are only available in Python 3.6+, existing scripts
cannot be updated to use this feature just yet because they would stop
working with older Python vers...PyLint 2.11 reports a new warning, C0209 (consider-using-f-string).
Since f-strings are only available in Python 3.6+, existing scripts
cannot be updated to use this feature just yet because they would stop
working with older Python versions. Instead, disable PyLint warning
C0209 for the time being. Sort all disabled warnings in .pylintrc.
Blocks #2945November 2021 (9.16.23, 9.16.23-S1, 9.17.20)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5536Merge 9.16.22 release branch2021-10-28T10:27:10ZMichał KępieńMerge 9.16.22 release branchNovember 2021 (9.16.23, 9.16.23-S1, 9.17.20)Michał KępieńMichał Kępień