BIND merge requestshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests2021-11-02T15:02:05Zhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5553retain diff output if clang-format changes something [v9_16]2021-11-02T15:02:05ZPetr Špačekpspacek@isc.orgretain diff output if clang-format changes something [v9_16]Backport: !5543Backport: !5543November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Petr Špačekpspacek@isc.orgPetr Špačekpspacek@isc.orghttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5543retain diff output if clang-format changes something2021-11-02T15:05:52ZPetr Špačekpspacek@isc.orgretain diff output if clang-format changes somethingNovember 2021 (9.16.23, 9.16.23-S1, 9.17.20)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5541[v9_16] Fix a bug when comparing two RSA keys2021-11-02T14:50:24ZArаm Sаrgsyаn[v9_16] Fix a bug when comparing two RSA keysWhen comparing different parameters of two RSA keys there is a typo
which causes the "p" prime factors to not being compared.
Fix the typo.
(cherry picked from commit 930e4f52a56d501ae0deefa948d7f4b6bd5d8995)
Closes #2972When comparing different parameters of two RSA keys there is a typo
which causes the "p" prime factors to not being compared.
Fix the typo.
(cherry picked from commit 930e4f52a56d501ae0deefa948d7f4b6bd5d8995)
Closes #2972November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Arаm SаrgsyаnArаm Sаrgsyаnhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5539[v9_16] Disable PyLint warning C02092021-10-28T13:40:27ZMichał Kępień[v9_16] Disable PyLint warning C0209PyLint 2.11 reports a new warning, C0209 (consider-using-f-string).
Since f-strings are only available in Python 3.6+, existing scripts
cannot be updated to use this feature just yet because they would stop
working with older Python vers...PyLint 2.11 reports a new warning, C0209 (consider-using-f-string).
Since f-strings are only available in Python 3.6+, existing scripts
cannot be updated to use this feature just yet because they would stop
working with older Python versions. Instead, disable PyLint warning
C0209 for the time being. Sort all disabled warnings in .pylintrc.
(cherry picked from commit 860ca4e0efe3d1a2d63095e4720ccb56224b34f8)November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Michał KępieńMichał Kępieńhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5538Disable PyLint warning C02092021-10-28T13:37:39ZMichał KępieńDisable PyLint warning C0209PyLint 2.11 reports a new warning, C0209 (consider-using-f-string).
Since f-strings are only available in Python 3.6+, existing scripts
cannot be updated to use this feature just yet because they would stop
working with older Python vers...PyLint 2.11 reports a new warning, C0209 (consider-using-f-string).
Since f-strings are only available in Python 3.6+, existing scripts
cannot be updated to use this feature just yet because they would stop
working with older Python versions. Instead, disable PyLint warning
C0209 for the time being. Sort all disabled warnings in .pylintrc.
Blocks #2945November 2021 (9.16.23, 9.16.23-S1, 9.17.20)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5536Merge 9.16.22 release branch2021-10-28T10:27:10ZMichał KępieńMerge 9.16.22 release branchNovember 2021 (9.16.23, 9.16.23-S1, 9.17.20)Michał KępieńMichał Kępieńhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5534Fix test errors that caused intermittent failures2021-10-28T12:48:06ZEvan HuntFix test errors that caused intermittent failuresNovember 2021 (9.16.23, 9.16.23-S1, 9.17.20)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5533Prevent existing catalog zone entries being incorrectly deleted2021-10-28T12:47:28ZMark AndrewsPrevent existing catalog zone entries being incorrectly deletedAfter receiving a new version of a catalog zone it is required
to merge it with the old version.
The algorithm walks through the new version's hash table and applies
the following logic:
1. If an entry from the new version does not exi...After receiving a new version of a catalog zone it is required
to merge it with the old version.
The algorithm walks through the new version's hash table and applies
the following logic:
1. If an entry from the new version does not exist in the old
version, then it's a new entry, add the entry to the `toadd` hash
table.
2. If the zone does not exist in the set of configured zones, because
it was deleted via rndc delzone or it was removed from another
catalog zone instance, then add into to the `toadd` hash table to
be reinstantiated.
3. If an entry from the new version also exists in the old version,
but is modified, then add the entry to the `tomod` hash table, then
remove it from the old version's hash table.
4. If an entry from the new version also exists in the old version and
is the same (unmodified) then just remove it from the old version's
hash table.
The algorithm then deletes all the remaining zones which still exist
in the old version's hash table (because only the ones that don't
exist in the new version should now remain there), then adds the ones
that were added to the `toadd`, and modifies the ones that were added
to the `tomod`, completing the merge.
During a recent refactoring, the part when the entry should be
removed from the old version's hash table on condition (4.) above
was accidentally omitted, so the unmodified zones were remaining
in the old version's hash table and consequently being deleted.
(cherry picked from commit 63145fb1d328eb66f9c786d2273bc2e3f6a3ecf5)
Closes #2947November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5532Resolve "Restore 'xsltproc' discovery for statistics system test 9.16"2021-11-02T14:58:23ZMark AndrewsResolve "Restore 'xsltproc' discovery for statistics system test 9.16"Closes #2976Closes #2976November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5529Fix a bug when comparing two RSA keys2021-10-28T07:31:14ZArаm SаrgsyаnFix a bug when comparing two RSA keysWhen comparing different parameters of two RSA keys there is a typo
which causes the "p" prime factors to not being compared.
Fix the typo.
Closes #2972When comparing different parameters of two RSA keys there is a typo
which causes the "p" prime factors to not being compared.
Fix the typo.
Closes #2972November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Arаm SаrgsyаnArаm Sаrgsyаnhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5527[v9_16] Use Fedora image for GCC ASAN and TSAN CI jobs2021-10-22T13:22:17ZMichal Nowak[v9_16] Use Fedora image for GCC ASAN and TSAN CI jobsNovember 2021 (9.16.23, 9.16.23-S1, 9.17.20)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5525[v9_16] Add Debian 11 (bullseye)2021-10-22T09:05:35ZMichal Nowak[v9_16] Add Debian 11 (bullseye)November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5523[v9_16] Add OpenBSD 7.02021-10-22T07:50:18ZMichal Nowak[v9_16] Add OpenBSD 7.0(cherry picked from commit 75e873ed9873c099d0eab4fef97b084e487572fa)(cherry picked from commit 75e873ed9873c099d0eab4fef97b084e487572fa)November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5520Add missing DNS_ZONEFLG_DUMPING to setmodtime()2021-10-21T10:52:49ZOndřej SurýAdd missing DNS_ZONEFLG_DUMPING to setmodtime()It was found, that the original commit adding the setmodtime() was
incompletely squashed and there was double check for
DNS_ZONEFLG_NEEDDUMP instead of check for DNS_ZONEFLG_NEEDDUMP and
DNS_ZONEFLG_DUMPING.
Change the duplicate check t...It was found, that the original commit adding the setmodtime() was
incompletely squashed and there was double check for
DNS_ZONEFLG_NEEDDUMP instead of check for DNS_ZONEFLG_NEEDDUMP and
DNS_ZONEFLG_DUMPING.
Change the duplicate check to DNS_ZONEFLG_DUMPING.
(cherry picked from commit 55ac6b7394f92cba2e924e0c11ea0ecad8b881af)November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5519Add OpenBSD 7.02021-10-27T13:12:26ZMichal NowakAdd OpenBSD 7.0November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5517Fix isc_time_add() overflow2021-10-27T12:56:49ZOndřej SurýFix isc_time_add() overflowThe isc_time_add() could overflow when t.seconds + i.seconds == UINT_MAX
and t.nanoseconds + i.nanoseconds >= NS_PER_S.
Fix the overflow in isc_time_add(), and simplify the ISC_R_RANGE checks
both in isc_time_add() and isc_time_subtract...The isc_time_add() could overflow when t.seconds + i.seconds == UINT_MAX
and t.nanoseconds + i.nanoseconds >= NS_PER_S.
Fix the overflow in isc_time_add(), and simplify the ISC_R_RANGE checks
both in isc_time_add() and isc_time_subtract() functions.
(cherry picked from commit 8c05f12bc8abd27808abc7e21fffef88d2922e8e)November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5512Add missing DNS_ZONEFLG_DUMPING to setmodtime()2021-10-27T13:00:35ZOndřej SurýAdd missing DNS_ZONEFLG_DUMPING to setmodtime()It was found, that the original commit adding the setmodtime() was
incompletely squashed and there was double check for
DNS_ZONEFLG_NEEDDUMP instead of check for DNS_ZONEFLG_NEEDDUMP and
DNS_ZONEFLG_DUMPING.
Change the duplicate check t...It was found, that the original commit adding the setmodtime() was
incompletely squashed and there was double check for
DNS_ZONEFLG_NEEDDUMP instead of check for DNS_ZONEFLG_NEEDDUMP and
DNS_ZONEFLG_DUMPING.
Change the duplicate check to DNS_ZONEFLG_DUMPING.November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5511Fix isc_time_add() overflow2021-10-27T12:56:43ZOndřej SurýFix isc_time_add() overflowThe isc_time_add() could overflow when t.seconds + i.seconds == UINT_MAX
and t.nanoseconds + i.nanoseconds >= NS_PER_S. Fix the overflow in
isc_time_add(), and simplify the ISC_R_RANGE checks both in isc_time_add()
and isc_time_sub().The isc_time_add() could overflow when t.seconds + i.seconds == UINT_MAX
and t.nanoseconds + i.nanoseconds >= NS_PER_S. Fix the overflow in
isc_time_add(), and simplify the ISC_R_RANGE checks both in isc_time_add()
and isc_time_sub().November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Ondřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5510fix qmin system test2021-10-27T12:54:48ZEvan Huntfix qmin system testNovember 2021 (9.16.23, 9.16.23-S1, 9.17.20)https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/5509fix qmin system test2021-11-05T07:58:13ZEvan Huntfix qmin system testThe qmin system test was printing spurious output. On investigation,
the test case turned out to be both broken and ineffective: its
expectations were wrong, and it was printing the output because its
wrong expectations were not met, an...The qmin system test was printing spurious output. On investigation,
the test case turned out to be both broken and ineffective: its
expectations were wrong, and it was printing the output because its
wrong expectations were not met, and those failed expectations were
not causing a test failure. All of this has been corrected.November 2021 (9.16.23, 9.16.23-S1, 9.17.20)Evan HuntEvan Hunt