Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 569
    • Issues 569
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 99
    • Merge requests 99
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !2712

Bail-out early if dig fails to finish successfully or takes too long

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ondřej Surý requested to merge 1453-the-zero-system-test-timeouts-intermittently into master Dec 05, 2019
  • Overview 0
  • Commits 1
  • Pipelines 5
  • Changes 1

Before, the zero system test could get stuck almost infinitely, because the first test sends > 300 queries with 5 seconds timeout on each in each pass. If named crashed early, it would took the test more than 4 hours to properly timeout.

This commit introduces a "watchdog" on the dig commands running in the background and failing the test on timeout, failing any test if any dig command fails to return successfully, and making the tests.sh script shellcheck clean.

Closes #1453 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1453-the-zero-system-test-timeouts-intermittently