Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
BIND
BIND
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 637
    • Issues 637
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 104
    • Merge Requests 104
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ISC Open Source Projects
  • BINDBIND
  • Merge Requests
  • !4458

Merged
Opened Dec 02, 2020 by Michał Kępień@michalMaintainer

Make netmgr initialize and cleanup Winsock itself

  • Overview 19
  • Commits 2
  • Pipelines 7
  • Changes 1

Lack of netmgr's own WSAStartup() calls was not a problem before as isc_socketmgr_create2() was called before any isc__nm_socket() calls were issued (and that function calls WSAStartup() on Windows). !4444 (merged) changed that (namely the isc__nm_test_lb_socket() calls at the beginning of isc_nm_start()), breaking Windows.

I think this does not require CHANGES - I think of it as a fixup for !4444 (merged).

Closes #2328 (closed)

Edited Dec 02, 2020 by Michał Kępień
Assignee
Assign to
Reviewer
Request review from
December 2020 (9.11.26, 9.11.26-S1, 9.16.10, 9.16.10-S1, 9.17.8)
Milestone
December 2020 (9.11.26, 9.11.26-S1, 9.16.10, 9.16.10-S1, 9.17.8) (Past due)
Assign milestone
Time tracking
Reference: isc-projects/bind9!4458
Source branch: 2328-make-netmgr-initialize-and-cleanup-winsock-itself

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.