Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 616
    • Issues 616
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 94
    • Merge requests 94
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !4913

Fix task timing race in setnsec3param()

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Ondřej Surý requested to merge 2636-timing-race-in-setnsec3param-task-ondrej/cleanup-double-createinctx-constructors-v9_16 into v9_16 Apr 19, 2021
  • Overview 3
  • Commits 2
  • Pipelines 1
  • Changes 11

When setnsec3param() is schedule from zone_postload() there's no guarantee that zone->db is not NULL yet. Thus when the setnsec3param() is called, we need to check for zone->db existence and reschedule the task, because calling rss_post() on a zone with empty .db ends up with no-op (the function just returns).

(cherry picked from commit 0127ba64)

Closes #2636 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 2636-timing-race-in-setnsec3param-task-ondrej/cleanup-double-createinctx-constructors-v9_16