Skip to content
GitLab

Improve the logging on failed TCP accept

Merged Ondřej Surý requested to merge 2700-improve-failed-tcp-accept-logging into main

Previously, when TCP accept failed, we have logged a message with ISC_LOG_ERROR level. One common case, how this could happen is that the client hits TCP client quota and is put on hold and when resumed, the client has already given up and closed the TCP connection. In such case, the named would log:

TCP connection failed: socket is not connected

This message was quite confusing because it actually doesn't say that it's related to the accepting the TCP connection and also it logs everything on the ISC_LOG_ERROR level.

Change the log message to "Accepting TCP connection failed" and for specific error states lower the severity of the log message to ISC_LOG_INFO.

Closes #2700 (closed)

Edited by Ondřej Surý