Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 633
    • Issues 633
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 88
    • Merge requests 88
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !6130

[v9_18] Unify dig +nssearch next query starting code for TCP and UDP protocols

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Arаm Sаrgsyаn requested to merge 3144-dig-+trace-or-+nssearch-with-+tcp-always-crashes-v9_18 into v9_18 Apr 14, 2022
  • Overview 1
  • Commits 3
  • Pipelines 1
  • Changes 2

In +nssearch mode dig starts the next query of the followup lookup using start_udp() or start_tcp() calls without waiting for the previous query to complete.

In UDP mode that happens in the send_done() callback of the previous query, but in TCP mode that happens in the start_tcp() call of the previous query (recursion) which doesn't work because start_tcp() attaches the lookup->current_query to the query it is starting, so a recursive call will result in an assertion failure.

Make the TCP mode to start the next query in send_done(), just like in the UDP mode. During that time the lookup->current_query is already detached by the tcp_connected()/udp_ready() callbacks.

Closes #3144 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3144-dig-+trace-or-+nssearch-with-+tcp-always-crashes-v9_18