Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 610
    • Issues 610
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !6877

Abort on UBSAN errors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michal Nowak requested to merge mnowak/abort-on-ubsan-errors into main Oct 07, 2022
  • Overview 6
  • Commits 1
  • Pipelines 7
  • Changes 1

Previously, UBSAN errors might slip undetected (e.g. when 23678758 is in).

Look for x = -2147483648:

  • clang:asan - https://gitlab.isc.org/isc-projects/bind9/-/jobs/2945224#L1029
  • gcc:asan - https://gitlab.isc.org/isc-projects/bind9/-/jobs/2945225#L1036

The builtin system test, which uses failing named -V, passed, tho error reports are somewhere in the output (look for main.c in the output):

  • system:clang:asan - https://gitlab.isc.org/isc-projects/bind9/-/jobs/2945230
  • system:gcc:asan - https://gitlab.isc.org/isc-projects/bind9/-/jobs/2945229

Validation jobs show that named -V with undefined behavior fails the test:

  • clang:asan - https://gitlab.isc.org/isc-projects/bind9/-/jobs/2945017
  • gcc:asan - https://gitlab.isc.org/isc-projects/bind9/-/jobs/2945016
  • system:clang:asan - https://gitlab.isc.org/isc-projects/bind9/-/jobs/2945053
  • system:gcc:asan - https://gitlab.isc.org/isc-projects/bind9/-/jobs/2945052
S:builtin:2022-10-07T11:19:03+0000
main.c:684:4: runtime error: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int'
main.c:684:4: runtime error: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int'
...
I:builtin:Core dump(s) found: builtin/core.25914 builtin/core.25961 
...
Edited Nov 29, 2022 by Michal Nowak
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mnowak/abort-on-ubsan-errors