diff --git a/CHANGES b/CHANGES index c7655b7fdea46a734afe4081017461fb92d29419..953764c720d7eb4a0366679cbc8fc800336ff43a 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,6 @@ +5042. [test] Make the chained delegations in reclimit behave + like they would in a regular name server. [GL #578] + 5041. [test] The chain test contains a incomplete delegation. [GL #568] diff --git a/bin/tests/system/reclimit/README b/bin/tests/system/reclimit/README index bb7f596c53bd8401dcd35e93f3a8c29b9a3b9405..02b1ba19d096dbec75f8809efb45c798d87324ad 100644 --- a/bin/tests/system/reclimit/README +++ b/bin/tests/system/reclimit/README @@ -7,7 +7,6 @@ system test for recursion limits ns1 -- root server ans2 -- for example.org: delegate to ns1.(n+1).example.org for all n, up to the value specified in ans.limit (or forever if limit is 0) - for example.net: delegate every query to 15 more name servers, with - "victim" address ns3 -- resolver under test +ans4 -- for ns*.example.com: return address records. ans7 -- "victim" server diff --git a/bin/tests/system/reclimit/ans2/ans.pl b/bin/tests/system/reclimit/ans2/ans.pl index 988445d6cfcbcef7e98d9911f8bad9c71eba2c60..da3d192a8af725bd429071617ca11cdfd39a6144 100644 --- a/bin/tests/system/reclimit/ans2/ans.pl +++ b/bin/tests/system/reclimit/ans2/ans.pl @@ -102,7 +102,7 @@ sub reply_handler { my ($ttl, $rdata) = (3600, $localaddr); my $rr = new Net::DNS::RR("$qname $ttl $qclass $qtype $rdata"); push @ans, $rr; - } + } $rcode = "NOERROR"; } elsif ($qname =~ /^ns1\.(\d+)\.example\.org$/) { my $next = $1 + 1; @@ -113,7 +113,7 @@ sub reply_handler { } else { $send_response = 1; if ($qtype eq "A") { - my ($ttl, $rdata) = (3600, $localaddr); + my ($ttl, $rdata) = (3600, "10.53.0.4"); my $rr = new Net::DNS::RR("$qname $ttl $qclass $qtype $rdata"); print("\tresponse: $qname $ttl $qclass $qtype $rdata\n"); push @ans, $rr; @@ -121,22 +121,22 @@ sub reply_handler { } $rcode = "NOERROR"; } elsif ($qname eq "direct.example.net" ) { - if ($qtype eq "A") { - my ($ttl, $rdata) = (3600, $localaddr); - my $rr = new Net::DNS::RR("$qname $ttl $qclass $qtype $rdata"); - push @ans, $rr; - } - $rcode = "NOERROR"; + if ($qtype eq "A") { + my ($ttl, $rdata) = (3600, $localaddr); + my $rr = new Net::DNS::RR("$qname $ttl $qclass $qtype $rdata"); + push @ans, $rr; + } + $rcode = "NOERROR"; } elsif( $qname =~ /^ns1\.(\d+)\.example\.net$/ ) { - my $next = ($1 + 1) * 16; - for (my $i = 1; $i < 16; $i++) { - my $s = $next + $i; - my $rr = new Net::DNS::RR("$1.example.net 86400 $qclass NS ns1.$s.example.net"); - push @auth, $rr; - $rr = new Net::DNS::RR("ns1.$s.example.net 86400 $qclass A 10.53.0.7"); - push @add, $rr; - } - $rcode = "NOERROR"; + my $next = ($1 + 1) * 16; + for (my $i = 1; $i < 16; $i++) { + my $s = $next + $i; + my $rr = new Net::DNS::RR("$1.example.net 86400 $qclass NS ns1.$s.example.net"); + push @auth, $rr; + $rr = new Net::DNS::RR("ns1.$s.example.net 86400 $qclass A 10.53.0.7"); + push @add, $rr; + } + $rcode = "NOERROR"; } else { $rcode = "NXDOMAIN"; } diff --git a/bin/tests/system/reclimit/ans4/ans.pl b/bin/tests/system/reclimit/ans4/ans.pl new file mode 100644 index 0000000000000000000000000000000000000000..57ba9621ec04b17cee94ede08d7514b2152d4fc7 --- /dev/null +++ b/bin/tests/system/reclimit/ans4/ans.pl @@ -0,0 +1,238 @@ +#!/usr/bin/env perl +# +# Copyright (C) Internet Systems Consortium, Inc. ("ISC") +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# +# See the COPYRIGHT file distributed with this work for additional +# information regarding copyright ownership. + +use strict; +use warnings; + +use IO::File; +use IO::Socket; +use Net::DNS; + +my $localaddr = "10.53.0.4"; +my $limit = getlimit(); +my $no_more_waiting = 0; +my @delayed_response; +my $timeout; + +my $localport = int($ENV{'PORT'}); +if (!$localport) { $localport = 5300; } + +my $udpsock = IO::Socket::INET->new(LocalAddr => "$localaddr", + LocalPort => $localport, Proto => "udp", Reuse => 1) or die "$!"; + +my $pidf = new IO::File "ans.pid", "w" or die "cannot open pid file: $!"; +print $pidf "$$\n" or die "cannot write pid file: $!"; +$pidf->close or die "cannot close pid file: $!"; +sub rmpid { unlink "ans.pid"; exit 1; }; + +$SIG{INT} = \&rmpid; +$SIG{TERM} = \&rmpid; + +my $count = 0; +my $send_response = 1; + +sub getlimit { + if ( -e "ans.limit") { + open(FH, "<", "ans.limit"); + my $line = ; + chomp $line; + close FH; + if ($line =~ /^\d+$/) { + return $line; + } + } + + return 0; +} + +# If $wait == 0 is returned, returned reply will be sent immediately. +# If $wait == 1 is returned, sending the returned reply might be delayed; see +# comments inside handle_UDP() for details. +sub reply_handler { + my ($qname, $qclass, $qtype) = @_; + my ($rcode, @ans, @auth, @add, $wait); + + print ("request: $qname/$qtype\n"); + STDOUT->flush(); + + $wait = 0; + $count += 1; + + if ($qname eq "count" ) { + if ($qtype eq "TXT") { + my ($ttl, $rdata) = (0, "$count"); + my $rr = new Net::DNS::RR("$qname $ttl $qclass $qtype $rdata"); + push @ans, $rr; + print ("\tcount: $count\n"); + } + $rcode = "NOERROR"; + } elsif ($qname eq "reset" ) { + $count = 0; + $send_response = 1; + $limit = getlimit(); + $rcode = "NOERROR"; + print ("\tlimit: $limit\n"); + } elsif ($qname eq "direct.example.org" ) { + if ($qtype eq "A") { + my ($ttl, $rdata) = (3600, $localaddr); + my $rr = new Net::DNS::RR("$qname $ttl $qclass $qtype $rdata"); + push @ans, $rr; + print ("\twait=$wait ans: $qname $ttl $qclass $qtype $rdata\n"); + } + $rcode = "NOERROR"; + } elsif ($qname eq "indirect1.example.org" || + $qname eq "indirect2.example.org" || + $qname eq "indirect3.example.org" || + $qname eq "indirect4.example.org" || + $qname eq "indirect5.example.org" || + $qname eq "indirect6.example.org" || + $qname eq "indirect7.example.org" || + $qname eq "indirect8.example.org") { + if ($qtype eq "A") { + my ($ttl, $rdata) = (3600, $localaddr); + my $rr = new Net::DNS::RR("$qname $ttl $qclass $qtype $rdata"); + push @ans, $rr; + print ("\twait=$wait ans: $qname $ttl $qclass $qtype $rdata\n"); + } + $rcode = "NOERROR"; + } elsif ($qname =~ /^ns1\.(\d+)\.example\.org$/) { + my $next = $1 + 1; + $wait = 1; + if ($limit == 0) { + my $rr = new Net::DNS::RR("$1.example.org 86400 $qclass NS ns1.$next.example.org"); + push @auth, $rr; + print ("\twait=$wait auth: $1.example.org 86400 $qclass NS ns1.$next.example.org\n"); + } else { + $send_response = 1; + if ($qtype eq "A") { + my ($ttl, $rdata) = (3600, $localaddr); + my $rr = new Net::DNS::RR("$qname $ttl $qclass $qtype $rdata"); + print("\tresponse: $qname $ttl $qclass $qtype $rdata\n"); + push @ans, $rr; + } + } + $rcode = "NOERROR"; + } elsif ($qname eq "direct.example.net" ) { + if ($qtype eq "A") { + my ($ttl, $rdata) = (3600, $localaddr); + my $rr = new Net::DNS::RR("$qname $ttl $qclass $qtype $rdata"); + push @ans, $rr; + print ("\twait=$wait ans: $qname $ttl $qclass $qtype $rdata\n"); + } + $rcode = "NOERROR"; + } elsif( $qname =~ /^ns1\.(\d+)\.example\.net$/ ) { + my $next = ($1 + 1) * 16; + for (my $i = 1; $i < 16; $i++) { + my $s = $next + $i; + my $rr = new Net::DNS::RR("$1.example.net 86400 $qclass NS ns1.$s.example.net"); + push @auth, $rr; + print ("\twait=$wait auth: $1.example.net 86400 $qclass NS ns1.$s.example.net\n"); + $rr = new Net::DNS::RR("ns1.$s.example.net 86400 $qclass A 10.53.0.7"); + print ("\twait=$wait add: ns1.$s.example.net 86400 $qclass A 10.53.0.7\n"); + push @add, $rr; + } + $rcode = "NOERROR"; + } else { + $rcode = "NXDOMAIN"; + print ("\twait=$wait NXDOMAIN\n"); + } + + return ($rcode, \@ans, \@auth, \@add, $wait); +} + +sub handleUDP { + my ($buf, $peer) = @_; + my ($request, $rcode, $ans, $auth, $add, $wait); + + $request = new Net::DNS::Packet(\$buf, 0); + $@ and die $@; + + my ($question) = $request->question; + my $qname = $question->qname; + my $qclass = $question->qclass; + my $qtype = $question->qtype; + + ($rcode, $ans, $auth, $add, $wait) = reply_handler($qname, $qclass, $qtype); + + my $reply = $request->reply(); + + $reply->header->rcode($rcode); + $reply->header->aa(@$ans ? 1 : 0); + $reply->header->id($request->header->id); + $reply->{answer} = $ans if $ans; + $reply->{authority} = $auth if $auth; + $reply->{additional} = $add if $add; + + if ($wait) { + # reply_handler() asked us to delay sending this reply until + # another reply with $wait == 1 is generated or a timeout + # occurs. + if (@delayed_response) { + # A delayed reply is already queued, so we can now send + # both the delayed reply and the current reply. + send_delayed_response(); + return $reply; + } elsif ($no_more_waiting) { + # It was determined before that there is no point in + # waiting for "accompanying" queries. Thus, send the + # current reply immediately. + return $reply; + } else { + # No delayed reply is queued and the client is expected + # to send an "accompanying" query shortly. Do not send + # the current reply right now, just save it for later + # and wait for an "accompanying" query to be received. + @delayed_response = ($reply, $peer); + $timeout = 0.5; + return; + } + } else { + # Send reply immediately. + return $reply; + } +} + +sub send_delayed_response { + my ($reply, $peer) = @delayed_response; + # Truncation to 512 bytes is required for triggering "NS explosion" on + # builds without IPv6 support + $udpsock->send($reply->data(512), 0, $peer); + undef @delayed_response; + undef $timeout; + print ("send_delayed_response\n"); +} + +# Main +my $rin; +my $rout; +for (;;) { + $rin = ''; + vec($rin, fileno($udpsock), 1) = 1; + + select($rout = $rin, undef, undef, $timeout); + + if (vec($rout, fileno($udpsock), 1)) { + my ($buf, $peer, $reply); + $udpsock->recv($buf, 512); + $peer = $udpsock->peername(); + $reply = handleUDP($buf, $peer); + # Truncation to 512 bytes is required for triggering "NS + # explosion" on builds without IPv6 support + $udpsock->send($reply->data(512), 0, $peer) if $reply; + } else { + # An "accompanying" query was expected to come in, but did not. + # Assume the client never sends "accompanying" queries to + # prevent pointlessly waiting for them ever again. + $no_more_waiting = 1; + # Send the delayed reply to the query which caused us to wait. + send_delayed_response(); + } +} diff --git a/bin/tests/system/reclimit/clean.sh b/bin/tests/system/reclimit/clean.sh index 7a5d73a4b5959e7a4da9d16994f3ca9a8b3eb382..1d5c9cee49298b934c74962f902780fbef43756e 100644 --- a/bin/tests/system/reclimit/clean.sh +++ b/bin/tests/system/reclimit/clean.sh @@ -12,6 +12,7 @@ rm -f dig.out* rm -f ans?/ans.run rm -f ans2/ans.limit +rm -f ans4/ans.limit rm -f ns?/named.memstats rm -f ns?/named.run rm -f ns*/named.conf diff --git a/bin/tests/system/reclimit/ns1/root.db b/bin/tests/system/reclimit/ns1/root.db index 6a04ed256e43791827f33179ac4466bffcc6a0f7..3a6f7880bab9a24a26186454ff535e93709e5e54 100644 --- a/bin/tests/system/reclimit/ns1/root.db +++ b/bin/tests/system/reclimit/ns1/root.db @@ -15,3 +15,5 @@ example.org. 60 IN NS direct.example.org. direct.example.org. 60 IN A 10.53.0.2 example.net. 60 IN NS direct.example.net. direct.example.net. 60 IN A 10.53.0.2 +example.com. 60 IN NS direct.example.com. +direct.example.com. 60 IN A 10.53.0.4 diff --git a/bin/tests/system/reclimit/tests.sh b/bin/tests/system/reclimit/tests.sh index bafdc82b50b9d73628a251ad6f52ea7f5a1e9046..9a30a20445792691deab1381c70b874c3a9e2e67 100644 --- a/bin/tests/system/reclimit/tests.sh +++ b/bin/tests/system/reclimit/tests.sh @@ -37,9 +37,12 @@ ns3_sends_aaaa_queries() { # - if ns3 sends AAAA queries, the query count should equal $2, # - if ns3 does not send AAAA queries, the query count should equal $3. check_query_count() { - count=`sed 's/[^0-9]//g;' $1` - expected_count_with_aaaa=$2 - expected_count_without_aaaa=$3 + count1=`sed 's/[^0-9]//g;' $1` + count2=`sed 's/[^0-9]//g;' $2` + count=`expr $count1 + $count2` + #echo_i "count1=$count1 count2=$count2 count=$count" + expected_count_with_aaaa=$3 + expected_count_without_aaaa=$4 if ns3_sends_aaaa_queries; then expected_count=$expected_count_with_aaaa @@ -48,7 +51,7 @@ check_query_count() { fi if [ $count -ne $expected_count ]; then - echo_i "count ($count) != $expected_count" + echo_i "count $count (actual) != $expected_count (expected)" ret=1 fi } @@ -59,11 +62,14 @@ n=`expr $n + 1` echo_i "attempt excessive-depth lookup ($n)" ret=0 echo "1000" > ans2/ans.limit +echo "1000" > ans4/ans.limit $DIG $DIGOPTS @10.53.0.2 reset > /dev/null || ret=1 +$DIG $DIGOPTS @10.53.0.4 reset > /dev/null || ret=1 $DIG $DIGOPTS @10.53.0.3 indirect1.example.org > dig.out.1.test$n || ret=1 grep "status: SERVFAIL" dig.out.1.test$n > /dev/null || ret=1 $DIG $DIGOPTS +short @10.53.0.2 count txt > dig.out.2.test$n || ret=1 -check_query_count dig.out.2.test$n 26 14 +$DIG $DIGOPTS +short @10.53.0.4 count txt > dig.out.4.test$n || ret=1 +check_query_count dig.out.2.test$n dig.out.4.test$n 27 14 if [ $ret != 0 ]; then echo_i "failed"; fi status=`expr $status + $ret` @@ -71,12 +77,15 @@ n=`expr $n + 1` echo_i "attempt permissible lookup ($n)" ret=0 echo "12" > ans2/ans.limit +echo "12" > ans4/ans.limit ns3_reset ns3/named1.conf.in $DIG $DIGOPTS @10.53.0.2 reset > /dev/null || ret=1 +$DIG $DIGOPTS @10.53.0.4 reset > /dev/null || ret=1 $DIG $DIGOPTS @10.53.0.3 indirect2.example.org > dig.out.1.test$n || ret=1 grep "status: NOERROR" dig.out.1.test$n > /dev/null || ret=1 $DIG $DIGOPTS +short @10.53.0.2 count txt > dig.out.2.test$n || ret=1 -check_query_count dig.out.2.test$n 49 26 +$DIG $DIGOPTS +short @10.53.0.4 count txt > dig.out.4.test$n || ret=1 +check_query_count dig.out.2.test$n dig.out.4.test$n 50 26 if [ $ret != 0 ]; then echo_i "failed"; fi status=`expr $status + $ret` @@ -88,10 +97,12 @@ ret=0 echo "12" > ans2/ans.limit ns3_reset ns3/named2.conf.in $DIG $DIGOPTS @10.53.0.2 reset > /dev/null || ret=1 +$DIG $DIGOPTS @10.53.0.4 reset > /dev/null || ret=1 $DIG $DIGOPTS @10.53.0.3 indirect3.example.org > dig.out.1.test$n || ret=1 grep "status: SERVFAIL" dig.out.1.test$n > /dev/null || ret=1 $DIG $DIGOPTS +short @10.53.0.2 count txt > dig.out.2.test$n || ret=1 -check_query_count dig.out.2.test$n 12 7 +$DIG $DIGOPTS +short @10.53.0.4 count txt > dig.out.4.test$n || ret=1 +check_query_count dig.out.2.test$n dig.out.4.test$n 13 7 if [ $ret != 0 ]; then echo_i "failed"; fi status=`expr $status + $ret` @@ -99,12 +110,15 @@ n=`expr $n + 1` echo_i "attempt permissible lookup ($n)" ret=0 echo "5" > ans2/ans.limit +echo "5" > ans4/ans.limit ns3_reset ns3/named2.conf.in $DIG $DIGOPTS @10.53.0.2 reset > /dev/null || ret=1 +$DIG $DIGOPTS @10.53.0.4 reset > /dev/null || ret=1 $DIG $DIGOPTS @10.53.0.3 indirect4.example.org > dig.out.1.test$n || ret=1 grep "status: NOERROR" dig.out.1.test$n > /dev/null || ret=1 $DIG $DIGOPTS +short @10.53.0.2 count txt > dig.out.2.test$n || ret=1 -check_query_count dig.out.2.test$n 21 12 +$DIG $DIGOPTS +short @10.53.0.4 count txt > dig.out.4.test$n || ret=1 +check_query_count dig.out.2.test$n dig.out.4.test$n 22 12 if [ $ret != 0 ]; then echo_i "failed"; fi status=`expr $status + $ret` @@ -114,13 +128,16 @@ n=`expr $n + 1` echo_i "attempt excessive-queries lookup ($n)" ret=0 echo "13" > ans2/ans.limit +echo "13" > ans4/ans.limit ns3_reset ns3/named3.conf.in $DIG $DIGOPTS @10.53.0.2 reset > /dev/null || ret=1 +$DIG $DIGOPTS @10.53.0.4 reset > /dev/null || ret=1 $DIG $DIGOPTS @10.53.0.3 indirect5.example.org > dig.out.1.test$n || ret=1 if ns3_sends_aaaa_queries; then grep "status: SERVFAIL" dig.out.1.test$n > /dev/null || ret=1 fi $DIG $DIGOPTS +short @10.53.0.2 count txt > dig.out.2.test$n || ret=1 +$DIG $DIGOPTS +short @10.53.0.4 count txt > dig.out.4.test$n || ret=1 eval count=`cat dig.out.2.test$n` [ $count -le 50 ] || { ret=1; echo_i "count ($count) !<= 50"; } if [ $ret != 0 ]; then echo_i "failed"; fi @@ -145,7 +162,7 @@ echo_i "set max-recursion-depth=100, max-recursion-queries=40" n=`expr $n + 1` echo_i "attempt excessive-queries lookup ($n)" ret=0 -echo "10" > ans2/ans.limit +echo "11" > ans2/ans.limit ns3_reset ns3/named4.conf.in $DIG $DIGOPTS @10.53.0.2 reset > /dev/null || ret=1 $DIG $DIGOPTS @10.53.0.3 indirect7.example.org > dig.out.1.test$n || ret=1 @@ -187,5 +204,6 @@ eval count=`cat dig.out.3.test$n` if [ $ret != 0 ]; then echo_i "failed"; fi status=`expr $status + $ret` +#grep "duplicate query" ns3/named.run echo_i "exit status: $status" [ $status -eq 0 ] || exit 1 diff --git a/util/copyrights b/util/copyrights index 3d5aa3075d6b4899f2b39129578bff92baab6849..9ec8f5bd87f2872801be578f740bb01f3d1bfe3b 100644 --- a/util/copyrights +++ b/util/copyrights @@ -1714,6 +1714,7 @@ ./bin/tests/system/qmin/tests.sh SH 2018 ./bin/tests/system/reclimit/README TXT.BRIEF 2014,2016,2017,2018 ./bin/tests/system/reclimit/ans2/ans.pl PERL 2014,2015,2016,2017,2018 +./bin/tests/system/reclimit/ans4/ans.pl PERL 2018 ./bin/tests/system/reclimit/ans7/ans.pl PERL 2014,2016,2018 ./bin/tests/system/reclimit/clean.sh SH 2014,2016,2018 ./bin/tests/system/reclimit/ns1/named.conf.in CONF-C 2014,2016,2018