Make rrset stats counting saner wrt to stale records.

Stale rrsets accounting was broken and caused underflows, as the
responsibility was in two different places. With this change all
of the responsibility for accounting stale rrsets is moved to
rbtdb, and increment function will no longer decrement anything.
53 jobs for !2034 with 1087-rrset-statistics-fixes in 10 minutes and 25 seconds (queued for 4 seconds)
latest detached
Status Job ID Name Coverage
  Precheck
passed #250294
linux amd64
🐞:sid:amd64

00:00:13

passed #250293
linux amd64
misc:sid:amd64

00:00:18

 
  Build
passed #250305
linux amd64
asan:sid:amd64

00:02:14

passed #250307
linux amd64
clang:stretch:amd64

00:03:02

passed #250308
linux i386
clang:stretch:i386

00:01:57

passed #250295
linux amd64
docs:sid:amd64

00:00:42

passed #250304
linux amd64
gcc:bionic:amd64

00:02:00

passed #250296
linux amd64
gcc:centos6:amd64

00:02:27

passed #250297
linux amd64
gcc:centos7:amd64

00:02:34

passed #250302
linux amd64
gcc:fedora29:amd64

00:02:52

passed #250298
linux amd64
gcc:jessie:amd64

00:01:02

passed #250300
linux amd64
gcc:sid:amd64

00:02:17

passed #250301
linux i386
gcc:sid:i386

00:02:15

passed #250299
linux amd64
gcc:stretch:amd64

00:02:00

passed #250303
linux amd64
gcc:xenial:amd64

00:01:07

passed #250310
linux amd64
nolibtool:sid:amd64

00:02:05

passed #250309
linux amd64
pkcs11:sid:amd64

00:02:09

passed #250306
linux amd64
rwlock:sid:amd64

00:02:01

 
  Test
failed #250481
linux amd64
system:asan:sid:amd64

passed #250327
linux amd64
system:gcc:bionic:amd64

00:06:18

passed #250311
linux amd64
system:gcc:centos6:amd64

00:06:23

passed #250313
linux amd64
system:gcc:centos7:amd64

00:06:23

failed #250485
linux amd64
system:gcc:fedora29:amd64

passed #250315
linux amd64
system:gcc:jessie:amd64

00:06:23

passed #250319
linux amd64
system:gcc:sid:amd64

00:06:16

passed #250321
linux i386
system:gcc:sid:i386

00:07:00

passed #250317
linux amd64
system:gcc:stretch:amd64

00:06:24

failed #250484
linux amd64
system:gcc:xenial:amd64

passed #250336
linux amd64
system:nolibtool:sid:amd64

00:06:32

passed #250334
linux amd64
system:pkcs11:sid:amd64

00:06:56

failed #250480
linux amd64
system:rwlock:sid:amd64

passed #250330
linux amd64
unit:asan:sid:amd64

00:01:05

passed #250333
linux amd64
unit:clang:stretch:amd64

00:00:47

passed #250328
linux amd64
unit:gcc:bionic:amd64

00:00:58

passed #250312
linux amd64
unit:gcc:centos6:amd64

00:01:00

passed #250314
linux amd64
unit:gcc:centos7:amd64

00:01:00

passed #250324
linux amd64
unit:gcc:fedora29:amd64

00:01:01

passed #250316
linux amd64
unit:gcc:jessie:amd64

00:00:31

passed #250320
linux amd64
unit:gcc:sid:amd64

00:00:47

passed #250322
linux i386
unit:gcc:sid:i386

00:01:00

passed #250318
linux amd64
unit:gcc:stretch:amd64

00:00:54

passed #250326
linux amd64
unit:gcc:xenial:amd64

00:01:01

passed #250337
linux amd64
unit:nolibtool:sid:amd64

00:01:10

passed #250335
linux amd64
unit:pkcs11:sid:amd64

00:01:02

passed #250332
linux amd64
unit:rwlock:sid:amd64

00:00:45

failed #250329
linux amd64
system:asan:sid:amd64

01:00:00

failed #250479
linux amd64
system:asan:sid:amd64

failed #250483
linux amd64
system:gcc:fedora29:amd64

failed #250323
linux amd64
system:gcc:fedora29:amd64

01:00:01

failed #250325
linux amd64
system:gcc:xenial:amd64

01:00:01

failed #250482
linux amd64
system:gcc:xenial:amd64

failed #250478
linux amd64
system:rwlock:sid:amd64

failed #250331
linux amd64
system:rwlock:sid:amd64

01:00:00

 
Name Stage Failure
failed
system:gcc:fedora29:amd64 Test There has been a missing dependency failure
No job log
failed
system:gcc:xenial:amd64 Test There has been a missing dependency failure
No job log
failed
system:asan:sid:amd64 Test There has been a missing dependency failure
No job log
failed
system:rwlock:sid:amd64 Test There has been a missing dependency failure
No job log