Assign fctx->client when fctx is created rather when the join happens.

This prevents races on fctx->client whenever a new fetch joins a existing
fetch (by calling fctx_join) as it is now invariant for the active life of
fctx.
76 jobs for !2668 with 1416-threadsanitizer-data-race-resolver-c-3384-in-findname in 35 minutes and 39 seconds (queued for 47 seconds)
latest detached
Status Job ID Name Coverage
  Precheck
passed #444173
amd64 linux
🐞:sid:amd64

00:03:00

passed #444171
amd64 linux
autoreconf:sid:amd64

00:00:31

passed #444172
amd64 linux
misc:sid:amd64

00:00:18

 
  Build
passed #444186
amd64 linux
asan:sid:amd64

00:03:47

passed #444192
amd64 freebsd
clang:freebsd11.3:amd64

00:01:16

passed #444193
amd64 freebsd
clang:freebsd12.0:amd64

00:01:05

passed #444194
amd64 openbsd
clang:openbsd6.5:amd64

00:06:54

passed #444189
amd64 linux
clang:stretch:amd64

00:01:22

passed #444190
i386 linux
clang:stretch:i386

00:01:28

passed #444174
amd64 linux
gcc:alpine3.10:amd64

00:02:15

passed #444185
amd64 linux
gcc:bionic:amd64

00:01:25

passed #444180
amd64 linux
gcc:buster:amd64

00:01:59

passed #444175
amd64 linux
gcc:centos6:amd64

00:01:48

passed #444176
amd64 linux
gcc:centos7:amd64

00:01:57

passed #444177
amd64 linux
gcc:centos8:amd64

00:02:09

passed #444183
amd64 linux
gcc:fedora30:amd64

00:02:04

passed #444178
amd64 linux
gcc:jessie:amd64

00:01:16

passed #444181
amd64 linux
gcc:sid:amd64

00:02:09

passed #444182
i386 linux
gcc:sid:i386

00:01:34

passed #444179
amd64 linux
gcc:stretch:amd64

00:01:18

passed #444184
amd64 linux
gcc:xenial:amd64

00:02:15

passed #444196
amd64 windows
msvc:windows:amd64

00:04:52

passed #444188
amd64 linux
mutexatomics:sid:amd64

00:01:19

passed #444195
amd64 linux
nolibtool:sid:amd64

00:01:34

passed #444191
amd64 linux
pkcs11:sid:amd64

00:01:24

passed #444187
amd64 linux
rwlock:sid:amd64

00:01:28

 
  Unit
passed #444209
amd64 linux
unit:asan:sid:amd64

00:03:50

passed #444213
amd64 freebsd
unit:clang:freebsd11.3:amd64

00:00:37

passed #444214
amd64 freebsd
unit:clang:freebsd12.0:amd64

00:01:15

passed #444211
amd64 linux
unit:clang:stretch:amd64

00:00:50

passed #444197
amd64 linux
unit:gcc:alpine3.10:amd64

00:02:36

passed #444208
amd64 linux
unit:gcc:bionic:amd64

00:00:50

passed #444203
amd64 linux
unit:gcc:buster:amd64

00:01:16

passed #444198
amd64 linux
unit:gcc:centos6:amd64

00:00:51

passed #444199
amd64 linux
unit:gcc:centos7:amd64

00:00:52

passed #444200
amd64 linux
unit:gcc:centos8:amd64

00:00:51

passed #444206
amd64 linux
unit:gcc:fedora30:amd64

00:01:19

passed #444201
amd64 linux
unit:gcc:jessie:amd64

00:00:28

passed #444204
amd64 linux
unit:gcc:sid:amd64

00:01:18

passed #444205
i386 linux
unit:gcc:sid:i386

00:02:03

passed #444202
amd64 linux
unit:gcc:stretch:amd64

00:00:37

passed #444207
amd64 linux
unit:gcc:xenial:amd64

00:00:51

passed #444215
amd64 linux
unit:nolibtool:sid:amd64

00:01:41

passed #444212
amd64 linux
unit:pkcs11:sid:amd64

00:01:02

passed #444210
amd64 linux
unit:rwlock:sid:amd64

00:01:31

 
  System
passed #444228
amd64 linux
system:asan:sid:amd64

00:09:23

passed #444231
amd64 freebsd
system:clang:freebsd11.3:amd64

00:09:23

failed #444321
freebsd amd64
system:clang:freebsd12.0:amd64

00:08:13

passed #444242
linux amd64
system:gcc:alpine3.10:amd64

00:08:16

passed #444227
amd64 linux
system:gcc:bionic:amd64

00:06:54

passed #444241
linux amd64
system:gcc:buster:amd64

00:06:32

passed #444243
linux amd64
system:gcc:centos6:amd64

00:06:39

passed #444218
amd64 linux
system:gcc:centos7:amd64

00:07:20

passed #444219
amd64 linux
system:gcc:centos8:amd64

00:07:20

passed #444225
amd64 linux
system:gcc:fedora30:amd64

00:07:50

passed #444244
linux amd64
system:gcc:jessie:amd64

00:06:36

passed #444223
amd64 linux
system:gcc:sid:amd64

00:08:18

passed #444224
i386 linux
system:gcc:sid:i386

00:08:30

passed #444221
amd64 linux
system:gcc:stretch:amd64

00:07:34

passed #444226
amd64 linux
system:gcc:xenial:amd64

00:07:50

passed #444233
amd64 linux
system:nolibtool:sid:amd64

00:08:29

passed #444230
amd64 linux
system:pkcs11:sid:amd64

00:07:56

passed #444229
amd64 linux
system:rwlock:sid:amd64

00:07:45

failed #444320
freebsd amd64
system:clang:freebsd12.0:amd64

00:08:15

failed #444314
amd64 freebsd
system:clang:freebsd12.0:amd64

00:00:30

failed #444313
freebsd amd64
system:clang:freebsd12.0:amd64

00:09:12

failed #444245
amd64 freebsd
system:clang:freebsd12.0:amd64

00:08:13

failed #444240
freebsd amd64
system:clang:freebsd12.0:amd64

00:08:18

failed #444232
amd64 freebsd
system:clang:freebsd12.0:amd64

00:09:47

failed #444216
amd64 linux
system:gcc:alpine3.10:amd64

00:09:29

failed #444222
amd64 linux
system:gcc:buster:amd64

00:08:21

failed #444217
amd64 linux
system:gcc:centos6:amd64

00:08:07

failed #444220
amd64 linux
system:gcc:jessie:amd64

00:07:47

 
  Docs
passed #444234
amd64 linux
docs:sid:amd64

00:00:59

 
  Postcheck
passed #444236
amd64 linux
cppcheck:gcc:sid:amd64

00:01:27

passed #444235
amd64 linux
scan-build:buster:amd64

00:09:47

 
Name Stage Failure
failed
system:clang:freebsd12.0:amd64 System
No job log