Destroy query in killoldestquery under a lock.

Fixes a race between ns_client_killoldestquery and ns_client_endrequest -
killoldestquery takes a client from `recursing` list while endrequest
destroys client object, then killoldestquery works on a destroyed client
object. Prevent it by holding reclist lock while cancelling query.
80 jobs for !3146 with 1650-fix-race-in-killoldestclient in 30 minutes and 27 seconds (queued for 6 seconds)
detached
Status Job ID Name Coverage
  Precheck
passed #732361
amd64 linux
🐞:sid:amd64

00:03:32

passed #732360
amd64 linux
💾:sid:amd64

00:00:19

passed #732358
amd64 linux
autoreconf:sid:amd64

00:00:21

passed #732359
amd64 linux
misc:sid:amd64

00:00:18

 
  Build
passed #732377
amd64 linux
asan:sid:amd64

00:03:03

passed #732384
amd64 freebsd
clang:freebsd11.3:amd64

00:01:10

passed #732385
amd64 freebsd
clang:freebsd12.0:amd64

00:00:59

passed #732386
amd64 libvirt
clang:openbsd6.6:amd64

00:05:46

passed #732381
amd64 linux
clang:stretch:amd64

00:02:12

passed #732382
i386 linux
clang:stretch:i386

00:01:20

passed #732362
amd64 linux
gcc:alpine3.11:amd64

00:02:40

passed #732376
amd64 linux
gcc:bionic:amd64

00:01:20

passed #732368
amd64 linux
gcc:buster:amd64

00:01:37

passed #732363
amd64 linux
gcc:centos6:amd64

00:02:12

passed #732364
amd64 linux
gcc:centos7:amd64

00:02:23

passed #732365
amd64 linux
gcc:centos8:amd64

00:02:28

passed #732374
amd64 linux
gcc:fedora31:amd64

00:02:34

passed #732366
amd64 linux
gcc:jessie:amd64

00:01:35

passed #732369
amd64 linux
gcc:sid:amd64

00:02:36

passed #732371
arm64 linux
gcc:sid:arm64

00:19:15

passed #732372
i386 linux
gcc:sid:i386

00:01:40

passed #732367
amd64 linux
gcc:stretch:amd64

00:01:13

passed #732373
amd64 linux
gcc:tumbleweed:amd64

00:02:22

passed #732375
amd64 linux
gcc:xenial:amd64

00:01:42

passed #732388
amd64 windows
msvc:windows:amd64

00:02:32

passed #732380
amd64 linux
mutexatomics:sid:amd64

00:01:16

passed #732387
amd64 linux
nolibtool:sid:amd64

00:01:52

passed #732370
amd64 linux
oot:sid:amd64

00:02:31

passed #732383
amd64 linux
pkcs11:sid:amd64

00:02:57

passed #732379
amd64 linux
rwlock:sid:amd64

00:02:55

passed #732378
amd64 linux
tsan:buster:amd64

00:03:38

 
  Unit
passed #732403
amd64 linux
unit:asan:sid:amd64

00:01:05

passed #732409
amd64 freebsd
unit:clang:freebsd11.3:amd64

00:00:34

passed #732410
amd64 freebsd
unit:clang:freebsd12.0:amd64

00:00:38

passed #732407
amd64 linux
unit:clang:stretch:amd64

00:00:51

passed #732389
amd64 linux
unit:gcc:alpine3.11:amd64

00:01:00

passed #732402
amd64 linux
unit:gcc:bionic:amd64

00:00:44

passed #732395
amd64 linux
unit:gcc:buster:amd64

00:00:52

passed #732390
amd64 linux
unit:gcc:centos6:amd64

00:00:54

passed #732391
amd64 linux
unit:gcc:centos7:amd64

00:00:55

passed #732392
amd64 linux
unit:gcc:centos8:amd64

00:00:52

passed #732400
amd64 linux
unit:gcc:fedora31:amd64

00:01:00

passed #732393
amd64 linux
unit:gcc:jessie:amd64

00:00:30

passed #732396
amd64 linux
unit:gcc:sid:amd64

00:00:50

passed #732397
arm64 linux
unit:gcc:sid:arm64

00:00:58

passed #732398
i386 linux
unit:gcc:sid:i386

00:00:52

passed #732394
amd64 linux
unit:gcc:stretch:amd64

00:00:41

passed #732399
amd64 linux
unit:gcc:tumbleweed:amd64

00:00:50

passed #732401
amd64 linux
unit:gcc:xenial:amd64

00:00:55

passed #732406
amd64 linux
unit:mutexatomics:sid:amd64

00:00:44

passed #732411
amd64 linux
unit:nolibtool:sid:amd64

00:01:10

passed #732408
amd64 linux
unit:pkcs11:sid:amd64

00:00:58

passed #732405
amd64 linux
unit:rwlock:sid:amd64

00:00:57

failed #732404
amd64 linux allowed to fail
unit:tsan:buster:amd64

00:02:18

 
  System
passed #732426
amd64 linux
system:asan:sid:amd64

00:11:53

passed #732431
amd64 freebsd
system:clang:freebsd11.3:amd64

00:11:19

passed #732432
amd64 freebsd
system:clang:freebsd12.0:amd64

00:11:27

passed #732412
amd64 linux
system:gcc:alpine3.11:amd64

00:11:07

passed #732425
amd64 linux
system:gcc:bionic:amd64

00:09:54

passed #732418
amd64 linux
system:gcc:buster:amd64

00:09:21

passed #732413
amd64 linux
system:gcc:centos6:amd64

00:10:20

passed #732414
amd64 linux
system:gcc:centos7:amd64

00:09:38

passed #732415
amd64 linux
system:gcc:centos8:amd64

00:10:22

passed #732423
amd64 linux
system:gcc:fedora31:amd64

00:10:09

passed #732416
amd64 linux
system:gcc:jessie:amd64

00:10:37

passed #732419
amd64 linux
system:gcc:sid:amd64

00:10:30

passed #732420
arm64 linux
system:gcc:sid:arm64

00:10:45

passed #732421
i386 linux
system:gcc:sid:i386

00:10:33

passed #732417
amd64 linux
system:gcc:stretch:amd64

00:09:20

passed #732422
amd64 linux
system:gcc:tumbleweed:amd64

00:10:16

passed #732424
amd64 linux
system:gcc:xenial:amd64

00:09:41

passed #732429
amd64 linux
system:mutexatomics:sid:amd64

00:10:20

passed #732433
amd64 linux
system:nolibtool:sid:amd64

00:11:04

passed #732430
amd64 linux
system:pkcs11:sid:amd64

00:11:00

passed #732428
amd64 linux
system:rwlock:sid:amd64

00:10:03

failed #732427
amd64 linux allowed to fail
system:tsan:buster:amd64

00:14:23

 
  Docs
passed #732434
amd64 linux
docs:sid:amd64

00:01:10

 
  Postcheck
passed #732436
amd64 linux
cppcheck:gcc:sid:amd64

00:01:58

passed #732437
arm64 linux
cppcheck:gcc:sid:arm64

00:02:06

passed #732435
amd64 linux
scan-build:buster:amd64

00:10:17

 
Name Stage Failure
failed
system:tsan:buster:amd64 System
No job log
failed
unit:tsan:buster:amd64 Unit
No job log