Drop $SYSTEMTESTTOP from bin/tests/system/

The $SYSTEMTESTTOP shell variable if often set to .. in various shell
scripts inside bin/tests/system/, but most of the time it is only
used one line later, while sourcing conf.sh. This hardly improves
code readability.

$SYSTEMTESTTOP is also used for the purpose of referencing
scripts/files living in bin/tests/system/, but given that the
variable is always set to a short, relative path, we can drop it and
replace all of its occurrences with the relative path without adversely
affecting code readability.
81 jobs for !3623 with 48-drop-systemtesttop-from-bin-tests-system in 27 minutes and 52 seconds (queued for 6 seconds)
detached
Status Job ID Name Coverage
  Autoconf
passed #921336
amd64 linux
autoreconf

00:01:26

 
  Precheck
passed #921338
amd64 linux
clang-format

00:00:45

passed #921339
amd64 linux
coccinelle

00:04:39

failed #921418
linux amd64
danger

00:01:10

passed #921337
amd64 linux
misc

00:01:22

failed #921340
amd64 linux
danger

00:00:43

 
  Build
passed #921356
amd64 linux
clang:asan

00:03:28

passed #921360
amd64 linux
clang:buster:amd64

00:02:29

passed #921362
amd64 libvirt
clang:freebsd11.3:amd64

00:01:32

passed #921363
amd64 libvirt
clang:freebsd12.1:amd64

00:01:47

passed #921364
amd64 libvirt
clang:openbsd6.6:amd64

00:03:34

passed #921358
amd64 linux
clang:tsan

00:02:33

passed #921341
amd64 linux
gcc:alpine3.11:amd64

00:02:07

passed #921355
amd64 linux
gcc:asan

00:03:46

passed #921354
amd64 linux
gcc:bionic:amd64

00:01:56

passed #921346
amd64 linux
gcc:buster:amd64

00:02:29

passed #921342
amd64 linux
gcc:centos6:amd64

00:02:10

passed #921343
amd64 linux
gcc:centos7:amd64

00:02:05

passed #921344
amd64 linux
gcc:centos8:amd64

00:02:10

passed #921352
amd64 linux
gcc:fedora31:amd64

00:02:27

passed #921359
amd64 linux
gcc:mutexatomics

00:02:08

passed #921348
amd64 linux
gcc:out-of-tree

00:01:42

passed #921361
amd64 linux
gcc:pkcs11

00:02:27

passed #921347
amd64 linux
gcc:sid:amd64

00:02:58

passed #921349
arm64 linux
gcc:sid:arm64

00:02:15

passed #921350
i386 linux
gcc:sid:i386

00:02:26

passed #921345
amd64 linux
gcc:stretch:amd64

00:02:06

passed #921357
amd64 linux
gcc:tsan

00:02:40

passed #921351
amd64 linux
gcc:tumbleweed:amd64

00:02:43

passed #921353
amd64 linux
gcc:xenial:amd64

00:02:48

passed #921365
amd64 windows
msvc:windows:amd64

00:02:11

 
  Unit
passed #921380
amd64 linux
unit:clang:asan

00:02:57

passed #921384
amd64 linux
unit:clang:buster:amd64

00:02:03

passed #921386
amd64 libvirt
unit:clang:freebsd11.3:amd64

00:01:43

passed #921387
amd64 libvirt
unit:clang:freebsd12.1:amd64

00:01:37

failed #921382
amd64 linux allowed to fail
unit:clang:tsan

00:01:06

passed #921366
amd64 linux
unit:gcc:alpine3.11:amd64

00:02:43

passed #921379
amd64 linux
unit:gcc:asan

00:02:36

passed #921378
amd64 linux
unit:gcc:bionic:amd64

00:02:04

passed #921419
linux amd64
unit:gcc:buster:amd64

00:01:25

passed #921367
amd64 linux
unit:gcc:centos6:amd64

00:02:19

passed #921368
amd64 linux
unit:gcc:centos7:amd64

00:02:33

passed #921369
amd64 linux
unit:gcc:centos8:amd64

00:02:12

passed #921376
amd64 linux
unit:gcc:fedora31:amd64

00:02:08

passed #921383
amd64 linux
unit:gcc:mutexatomics

00:01:44

passed #921385
amd64 linux
unit:gcc:pkcs11

00:02:05

passed #921372
amd64 linux
unit:gcc:sid:amd64

00:02:10

passed #921373
arm64 linux
unit:gcc:sid:arm64

00:01:15

passed #921374
i386 linux
unit:gcc:sid:i386

00:02:10

passed #921370
amd64 linux
unit:gcc:stretch:amd64

00:02:12

failed #921381
amd64 linux allowed to fail
unit:gcc:tsan

00:06:21

passed #921375
amd64 linux
unit:gcc:tumbleweed:amd64

00:02:04

passed #921377
amd64 linux
unit:gcc:xenial:amd64

00:02:08

failed #921371
amd64 linux
unit:gcc:buster:amd64

00:02:12

 
  System
passed #921402
amd64 linux
system:clang:asan

00:16:38

passed #921406
amd64 linux
system:clang:buster:amd64

00:14:24

passed #921408
amd64 libvirt
system:clang:freebsd11.3:amd64

00:13:32

passed #921409
amd64 libvirt
system:clang:freebsd12.1:amd64

00:13:35

failed #921404
amd64 linux allowed to fail
system:clang:tsan

00:11:51

passed #921388
amd64 linux
system:gcc:alpine3.11:amd64

00:15:36

passed #921401
amd64 linux
system:gcc:asan

00:16:53

passed #921400
amd64 linux
system:gcc:bionic:amd64

00:17:17

passed #921393
amd64 linux
system:gcc:buster:amd64

00:15:36

passed #921389
amd64 linux
system:gcc:centos6:amd64

00:13:59

passed #921390
amd64 linux
system:gcc:centos7:amd64

00:14:21

passed #921391
amd64 linux
system:gcc:centos8:amd64

00:15:31

passed #921398
amd64 linux
system:gcc:fedora31:amd64

00:15:18

failed #921405
amd64 linux
system:gcc:mutexatomics

00:19:09

passed #921407
amd64 linux
system:gcc:pkcs11

00:18:36

passed #921394
amd64 linux
system:gcc:sid:amd64

00:16:05

passed #921395
arm64 linux
system:gcc:sid:arm64

00:11:29

passed #921396
i386 linux
system:gcc:sid:i386

00:15:38

passed #921392
amd64 linux
system:gcc:stretch:amd64

00:15:08

failed #921403
amd64 linux allowed to fail
system:gcc:tsan

00:22:15

passed #921397
amd64 linux
system:gcc:tumbleweed:amd64

00:14:58

passed #921399
amd64 linux
system:gcc:xenial:amd64

00:14:50

 
  Docs
passed #921410
amd64 linux
docs

00:03:12

 
  Postcheck
passed #921414
amd64 linux
cppcheck

00:01:51

passed #921411
amd64 linux
flake8

00:01:21

passed #921412
amd64 linux
pylint

00:01:41

passed #921413
amd64 linux
scan-build

00:07:20

 
Name Stage Failure
failed
system:gcc:tsan System

$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
bin/tests/system/*/tsan.*: found 38 matching files

bin/tests/system/*/*/tsan.*: found 241 matching files

tsan/: found 206 matching files

Uploading artifacts to coordinator... ok
id=921403 responseStatus=201 Created token=bCgHLax5
ERROR: Job failed: exit code 1
failed
system:gcc:mutexatomics System
R:kasp:FAIL
E:kasp:2020-06-02T15:55:44+0000
FAIL kasp (exit status: 1)

Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4384 files

Uploading artifacts to coordinator... ok
id=921405 responseStatus=201 Created token=A37dEy41
ERROR: Job failed: exit code 1
failed
danger Precheck
    output=stdout, stderr=stderr)


Failing the build, there is 1 fail.
Feedback: https://gitlab.isc.org/isc-projects/bind9/merge_requests/3623#note_136514

Running after_script
Uploading artifacts for failed job
ERROR: Job failed: exit code 1
failed
system:clang:tsan System

$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
bin/tests/system/*/tsan.*: found 734 matching files

bin/tests/system/*/*/tsan.*: found 1031 matching files

tsan/: found 1 matching files

Uploading artifacts to coordinator... ok
id=921404 responseStatus=201 Created token=QtrmxbyG
ERROR: Job failed: exit code 1
failed
unit:gcc:tsan Unit
Running after_script
Running after script...
$ find lib -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
lib/*/tests/tsan.*: found 1 matching files

tsan/: found 5 matching files

Uploading artifacts to coordinator... ok
id=921381 responseStatus=201 Created token=txsynxDk
ERROR: Job failed: exit code 1
failed
unit:clang:tsan Unit
Running after_script
Running after script...
$ find lib -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
lib/*/tests/tsan.*: found 63 matching files

tsan/: found 1 matching files

Uploading artifacts to coordinator... ok
id=921382 responseStatus=201 Created token=Qj9s8BsV
ERROR: Job failed: exit code 1