Address potential thread issues:

Assign and then check node for NULL to address another thread
changing radix->head in the meantime.

Move 'node != NULL' check into while loop test to silence cppcheck
false positive.

Fix pointer != NULL style.

(cherry picked from commit 51f08d20)
83 jobs for !3747 with 1969-silence-cppcheck-warnings-v9_11 in 43 minutes and 1 second (queued for 6 seconds)
detached
Status Job ID Name Coverage
  Precheck
passed autoreconf #977680
amd64 linux

00:00:24

passed clang-format #977682
amd64 linux

00:00:13

passed coccinelle #977683
amd64 linux

00:01:05

passed danger #977763
linux amd64

00:00:11

passed misc #977681
amd64 linux

00:00:18

passed danger #977684
amd64 linux

00:00:19

 
  Build
passed clang:asan #977700
amd64 linux

00:04:52

passed clang:buster:amd64 #977704
amd64 linux

00:03:08

passed clang:freebsd11.3:amd64 #977706
amd64 libvirt

00:02:34

passed clang:freebsd12.1:amd64 #977707
amd64 libvirt

00:02:27

passed clang:openbsd6.6:amd64 #977708
amd64 libvirt

00:05:11

passed clang:tsan #977702
amd64 linux

00:03:49

passed gcc:alpine3.11:amd64 #977685
amd64 linux

00:01:51

passed gcc:asan #977699
amd64 linux

00:05:23

passed gcc:bionic:amd64 #977698
amd64 linux

00:01:54

passed gcc:buster:amd64 #977690
amd64 linux

00:02:08

passed gcc:centos6:amd64 #977686
amd64 linux

00:01:51

passed gcc:centos7:amd64 #977687
amd64 linux

00:02:43

passed gcc:centos8:amd64 #977688
amd64 linux

00:02:02

passed gcc:fedora31:amd64 #977696
amd64 linux

00:02:08

passed gcc:mutexatomics #977703
amd64 linux

00:02:08

passed gcc:out-of-tree #977692
amd64 linux

00:01:40

passed gcc:pkcs11 #977705
amd64 linux

00:02:53

passed gcc:sid:amd64 #977691
amd64 linux

00:03:30

passed gcc:sid:arm64 #977693
arm64 linux

00:03:27

passed gcc:sid:i386 #977694
i386 linux

00:03:01

passed gcc:stretch:amd64 #977689
amd64 linux

00:03:08

passed gcc:tsan #977701
amd64 linux

00:01:55

passed gcc:tumbleweed:amd64 #977695
amd64 linux

00:02:17

passed gcc:xenial:amd64 #977697
amd64 linux

00:02:08

passed msvc:windows:amd64 #977710
amd64 windows

00:02:50

passed nolibtool:sid:amd64 #977709
amd64 linux

00:02:33

 
  Unit
passed unit:clang:asan #977725
amd64 linux

00:01:14

passed unit:clang:buster:amd64 #977729
amd64 linux

00:00:32

passed unit:clang:freebsd11.3:amd64 #977731
amd64 libvirt

00:01:05

passed unit:clang:freebsd12.1:amd64 #977732
amd64 libvirt

00:01:00

failed unit:clang:tsan #977727
amd64 linux allowed to fail

00:10:36

passed unit:gcc:alpine3.11:amd64 #977711
amd64 linux

00:00:31

passed unit:gcc:asan #977724
amd64 linux

00:01:51

passed unit:gcc:bionic:amd64 #977723
amd64 linux

00:00:36

passed unit:gcc:buster:amd64 #977716
amd64 linux

00:00:31

passed unit:gcc:centos6:amd64 #977712
amd64 linux

00:00:49

passed unit:gcc:centos7:amd64 #977713
amd64 linux

00:00:44

passed unit:gcc:centos8:amd64 #977714
amd64 linux

00:00:47

passed unit:gcc:fedora31:amd64 #977721
amd64 linux

00:00:35

passed unit:gcc:mutexatomics #977728
amd64 linux

00:00:31

passed unit:gcc:pkcs11 #977730
amd64 linux

00:00:32

passed unit:gcc:sid:amd64 #977717
amd64 linux

00:00:32

passed unit:gcc:sid:arm64 #977718
arm64 linux

00:00:51

passed unit:gcc:sid:i386 #977719
i386 linux

00:00:33

passed unit:gcc:stretch:amd64 #977715
amd64 linux

00:00:42

failed unit:gcc:tsan #977726
amd64 linux allowed to fail

00:10:41

passed unit:gcc:tumbleweed:amd64 #977720
amd64 linux

00:00:30

passed unit:gcc:xenial:amd64 #977722
amd64 linux

00:00:35

passed unit:nolibtool:sid:amd64 #977733
amd64 linux

00:00:52

 
  System
passed system:clang:asan #977748
amd64 linux

00:11:02

passed system:clang:buster:amd64 #977753
amd64 linux

00:08:40

passed system:clang:freebsd11.3:amd64 #977755
amd64 libvirt

00:09:27

failed system:clang:freebsd12.1:amd64 #977756
amd64 libvirt

00:09:11

failed system:clang:tsan #977751
amd64 linux allowed to fail

00:38:34

passed system:gcc:alpine3.11:amd64 #977734
amd64 linux

00:08:59

passed system:gcc:asan #977747
amd64 linux

00:10:54

passed system:gcc:bionic:amd64 #977746
amd64 linux

00:07:22

passed system:gcc:buster:amd64 #977739
amd64 linux

00:07:09

passed system:gcc:centos6:amd64 #977735
amd64 linux

00:07:22

passed system:gcc:centos7:amd64 #977736
amd64 linux

00:07:04

passed system:gcc:centos8:amd64 #977737
amd64 linux

00:07:22

passed system:gcc:fedora31:amd64 #977744
amd64 linux

00:07:10

passed system:gcc:mutexatomics #977752
amd64 linux

00:07:20

passed system:gcc:pkcs11 #977754
amd64 linux

00:09:27

passed system:gcc:sid:amd64 #977740
amd64 linux

00:07:01

passed system:gcc:sid:arm64 #977741
arm64 linux

00:08:47

passed system:gcc:sid:i386 #977742
i386 linux

00:08:50

passed system:gcc:stretch:amd64 #977738
amd64 linux

00:08:40

failed system:gcc:tsan #977749
amd64 linux allowed to fail

00:22:33

passed system:gcc:tumbleweed:amd64 #977743
amd64 linux

00:06:58

passed system:gcc:xenial:amd64 #977745
amd64 linux

00:06:55

passed system:nolibtool:sid:amd64 #977757
amd64 linux

00:07:24

 
  Docs
passed docs #977758
amd64 linux

00:00:45

 
  Postcheck
passed cppcheck #977762
amd64 linux

00:00:37

passed flake8 #977759
amd64 linux

00:00:35

passed pylint #977760
amd64 linux

00:00:45

passed scan-build #977761
amd64 linux

00:12:49

 
Name Stage Failure
failed
system:clang:freebsd12.1:amd64 System
No job log
failed
system:gcc:tsan System
No job log
failed
unit:clang:tsan Unit
No job log
failed
system:clang:tsan System
No job log
failed
unit:gcc:tsan Unit
No job log