remove redundant rctx != NULL check

79 jobs for !3791 with 1991-cleanup-redundant-non-null-check in 25 minutes and 32 seconds (queued for 39 seconds)
detached
Status Job ID Name Coverage
  Autoconf
passed #1001075
amd64 linux
autoreconf

00:00:20

 
  Precheck
passed #1001077
amd64 linux
clang-format

00:00:20

passed #1001078
amd64 linux
coccinelle

00:03:24

failed #1001079
amd64 linux
danger

00:00:10

passed #1001076
amd64 linux
misc

00:00:10

 
  Build
passed #1001095
amd64 linux
clang:asan

00:02:04

passed #1001103
amd64 linux
clang:buster:amd64

00:01:19

passed #1001109
amd64 libvirt
clang:freebsd11.4:amd64

00:01:24

passed #1001111
amd64 libvirt
clang:freebsd12.1:amd64

00:01:23

passed #1001113
amd64 libvirt
clang:openbsd6.7:amd64

00:03:08

passed #1001099
amd64 linux
clang:tsan

00:01:06

passed #1001080
amd64 linux
gcc:alpine3.12:amd64

00:01:08

passed #1001094
amd64 linux
gcc:asan

00:02:11

passed #1001085
amd64 linux
gcc:buster:amd64

00:00:49

passed #1001081
amd64 linux
gcc:centos6:amd64

00:00:57

passed #1001082
amd64 linux
gcc:centos7:amd64

00:00:42

passed #1001083
amd64 linux
gcc:centos8:amd64

00:00:44

passed #1001092
amd64 linux
gcc:focal:amd64

00:00:44

passed #1001101
amd64 linux
gcc:mutexatomics

00:00:45

passed #1001087
amd64 linux
gcc:out-of-tree

00:00:52

passed #1001086
amd64 linux
gcc:sid:amd64

00:00:56

passed #1001088
arm64 linux
gcc:sid:arm64

00:02:15

passed #1001089
i386 linux
gcc:sid:i386

00:01:09

passed #1001105
amd64 linux
gcc:softhsm2.4

00:00:45

passed #1001107
amd64 linux
gcc:softhsm2.6

00:01:08

passed #1001084
amd64 linux
gcc:stretch:amd64

00:01:13

passed #1001097
amd64 linux
gcc:tsan

00:01:11

passed #1001090
amd64 linux
gcc:tumbleweed:amd64

00:00:45

passed #1001091
amd64 linux
gcc:xenial:amd64

00:01:15

passed #1001115
amd64 windows
msvc:windows:amd64

00:02:12

 
  Unit
passed #1001145
amd64 linux
unit:clang:asan

00:01:20

passed #1001153
amd64 linux
unit:clang:buster:amd64

00:01:03

passed #1001159
amd64 libvirt
unit:clang:freebsd11.4:amd64

00:01:30

passed #1001161
amd64 libvirt
unit:clang:freebsd12.1:amd64

00:01:27

passed #1001149
amd64 linux
unit:clang:tsan

00:03:37

passed #1001117
amd64 linux
unit:gcc:alpine3.12:amd64

00:01:20

passed #1001143
amd64 linux
unit:gcc:asan

00:01:13

passed #1001128
amd64 linux
unit:gcc:buster:amd64

00:00:53

passed #1001120
amd64 linux
unit:gcc:centos6:amd64

00:00:52

passed #1001122
amd64 linux
unit:gcc:centos7:amd64

00:00:59

passed #1001124
amd64 linux
unit:gcc:centos8:amd64

00:00:53

passed #1001141
amd64 linux
unit:gcc:focal:amd64

00:00:54

passed #1001151
amd64 linux
unit:gcc:mutexatomics

00:01:06

passed #1001130
amd64 linux
unit:gcc:sid:amd64

00:01:02

passed #1001132
arm64 linux
unit:gcc:sid:arm64

00:01:08

passed #1001134
i386 linux
unit:gcc:sid:i386

00:01:30

passed #1001155
amd64 linux
unit:gcc:softhsm2.4

00:00:51

passed #1001157
amd64 linux
unit:gcc:softhsm2.6

00:01:03

passed #1001126
amd64 linux
unit:gcc:stretch:amd64

00:01:02

passed #1001147
amd64 linux
unit:gcc:tsan

00:03:53

passed #1001136
amd64 linux
unit:gcc:tumbleweed:amd64

00:01:02

passed #1001138
amd64 linux
unit:gcc:xenial:amd64

00:00:54

 
  System
passed #1001189
amd64 linux
system:clang:asan

00:13:37

passed #1001197
amd64 linux
system:clang:buster:amd64

00:10:07

passed #1001204
amd64 libvirt
system:clang:freebsd11.4:amd64

00:12:21

passed #1001206
amd64 libvirt
system:clang:freebsd12.1:amd64

00:12:33

failed #1001193
amd64 linux allowed to fail
system:clang:tsan

00:20:49

passed #1001163
amd64 linux
system:gcc:alpine3.12:amd64

00:11:14

passed #1001187
amd64 linux
system:gcc:asan

00:14:19

passed #1001174
amd64 linux
system:gcc:buster:amd64

00:10:20

failed #1001165
amd64 linux
system:gcc:centos6:amd64

00:11:31

passed #1001168
amd64 linux
system:gcc:centos7:amd64

00:10:33

passed #1001170
amd64 linux
system:gcc:centos8:amd64

00:12:28

passed #1001185
amd64 linux
system:gcc:focal:amd64

00:11:31

passed #1001195
amd64 linux
system:gcc:mutexatomics

00:10:01

passed #1001177
amd64 linux
system:gcc:sid:amd64

00:10:11

passed #1001179
arm64 linux
system:gcc:sid:arm64

00:11:48

passed #1001180
i386 linux
system:gcc:sid:i386

00:11:27

passed #1001200
amd64 linux
system:gcc:softhsm2.4

00:11:08

passed #1001202
amd64 linux
system:gcc:softhsm2.6

00:11:33

passed #1001172
amd64 linux
system:gcc:stretch:amd64

00:15:50

failed #1001191
amd64 linux allowed to fail
system:gcc:tsan

00:17:16

passed #1001182
amd64 linux
system:gcc:tumbleweed:amd64

00:12:28

passed #1001184
amd64 linux
system:gcc:xenial:amd64

00:10:08

 
  Docs
passed #1001208
amd64 linux
docs

00:00:34

 
  Postcheck
passed #1001216
amd64 linux
cppcheck

00:00:40

passed #1001210
amd64 linux
flake8

00:00:18

passed #1001212
amd64 linux
pylint

00:00:32

passed #1001214
amd64 linux
scan-build

00:06:15

 
Name Stage Failure
failed
system:clang:tsan System

$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
bin/tests/system/*/tsan.*: found 38 matching files and directories

bin/tests/system/*/*/tsan.*: found 247 matching files and directories

tsan/: found 195 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=1001193 responseStatus=201 Created token=5eCAs7Qb
ERROR: Job failed: exit code 1
failed
system:gcc:tsan System

$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
bin/tests/system/*/tsan.*: found 38 matching files and directories

bin/tests/system/*/*/tsan.*: found 230 matching files and directories

tsan/: found 195 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=1001191 responseStatus=201 Created token=HHyNWChe
ERROR: Job failed: exit code 1
failed
system:gcc:centos6:amd64 System
R:shutdown:FAIL
E:shutdown:2020-07-02T08:11:22+0000
FAIL shutdown (exit status: 1)

Uploading artifacts for failed job
Uploading artifacts...
untracked: found 1495 files

Uploading artifacts as "archive" to coordinator... ok
id=1001165 responseStatus=201 Created token=P4EBTFWi
ERROR: Job failed: exit code 1
failed
danger Precheck
    return DangerDSLJSONType(**input_json["danger"])
File "/usr/local/lib/python3.7/dist-packages/pydantic/main.py", line 338, in __init__
raise validation_error


Failing the build, there is 1 fail.
Feedback: https://gitlab.isc.org/isc-projects/bind9/merge_requests/3791#note_144998

ERROR: Job failed: exit code 1