Always enqueue netmgr events

Previously, there was a microoptimization that would execute the
requested event directly if the current thread would match the socket
thread.  With increasing numbers of networking threads, the benefit of
doing so gets smaller, but the increased complexity in the source code
stays the same.  We remove the optimization for the sake of simplicity
for the network manager design.
74 jobs for !4208 with ondrej/simplify-netmgr in 16 minutes and 7 seconds (queued for 8 seconds)
detached
Status Job ID Name Coverage
  Autoconf
passed #1195847
amd64 linux
autoreconf

00:00:16

 
  Precheck
passed #1195849
amd64 linux
clang-format

00:00:17

passed #1195850
amd64 linux
coccinelle

00:03:23

passed #1195851
amd64 linux
danger

00:00:12

passed #1195848
amd64 linux
misc

00:00:16

passed #1195852
amd64 linux
tarball-create

00:01:30

 
  Build
passed #1195865
amd64 linux
clang:asan

00:01:55

passed #1195869
amd64 linux
clang:buster:amd64

00:01:00

passed #1195872
amd64 libvirt
clang:freebsd11:amd64

00:01:08

passed #1195873
amd64 libvirt
clang:freebsd12:amd64

00:01:17

passed #1195874
amd64 libvirt
clang:openbsd:amd64

00:02:17

passed #1195867
amd64 linux
clang:tsan

00:01:23

passed #1195853
amd64 linux
gcc:alpine3.12:amd64

00:00:53

passed #1195864
amd64 linux
gcc:asan

00:01:42

passed #1195857
amd64 linux
gcc:buster:amd64

00:00:56

passed #1195854
amd64 linux
gcc:centos7:amd64

00:00:56

passed #1195855
amd64 linux
gcc:centos8:amd64

00:01:00

passed #1195863
amd64 linux
gcc:focal:amd64

00:01:02

passed #1195868
amd64 linux
gcc:mutexatomics

00:00:57

passed #1195859
amd64 linux
gcc:out-of-tree

00:01:04

passed #1195858
amd64 linux
gcc:sid:amd64

00:01:17

passed #1195860
i386 linux
gcc:sid:i386

00:00:54

passed #1195870
amd64 linux
gcc:softhsm2.4

00:00:52

passed #1195871
amd64 linux
gcc:softhsm2.6

00:00:46

passed #1195856
amd64 linux
gcc:stretch:amd64

00:01:05

passed #1195866
amd64 linux
gcc:tsan

00:01:18

passed #1195861
amd64 linux
gcc:tumbleweed:amd64

00:00:58

passed #1195862
amd64 linux
gcc:xenial:amd64

00:00:54

passed #1195875
amd64 windows
msvc:windows:amd64

00:00:44

 
  Unit
passed #1195887
amd64 linux
unit:clang:asan

00:01:14

passed #1195891
amd64 linux
unit:clang:buster:amd64

00:01:00

passed #1195894
amd64 libvirt
unit:clang:freebsd11:amd64

00:01:23

passed #1195895
amd64 libvirt
unit:clang:freebsd12:amd64

00:01:17

passed #1195889
amd64 linux
unit:clang:tsan

00:03:02

passed #1195876
amd64 linux
unit:gcc:alpine3.12:amd64

00:00:59

passed #1195886
amd64 linux
unit:gcc:asan

00:01:15

passed #1195880
amd64 linux
unit:gcc:buster:amd64

00:00:58

passed #1195877
amd64 linux
unit:gcc:centos7:amd64

00:01:03

passed #1195878
amd64 linux
unit:gcc:centos8:amd64

00:00:57

passed #1195885
amd64 linux
unit:gcc:focal:amd64

00:01:03

passed #1195890
amd64 linux
unit:gcc:mutexatomics

00:01:01

passed #1195881
amd64 linux
unit:gcc:sid:amd64

00:00:57

passed #1195882
i386 linux
unit:gcc:sid:i386

00:01:06

passed #1195892
amd64 linux
unit:gcc:softhsm2.4

00:01:00

passed #1195893
amd64 linux
unit:gcc:softhsm2.6

00:00:57

passed #1195879
amd64 linux
unit:gcc:stretch:amd64

00:01:01

passed #1195888
amd64 linux
unit:gcc:tsan

00:03:59

passed #1195883
amd64 linux
unit:gcc:tumbleweed:amd64

00:00:58

passed #1195884
amd64 linux
unit:gcc:xenial:amd64

00:01:01

 
  System
failed #1195907
amd64 linux
system:clang:asan

00:12:57

failed #1195911
amd64 linux
system:clang:buster:amd64

00:11:20

failed #1195914
amd64 libvirt
system:clang:freebsd11:amd64

00:10:09

failed #1195915
amd64 libvirt
system:clang:freebsd12:amd64

00:10:14

failed #1195909
amd64 linux allowed to fail
system:clang:tsan

00:13:44

failed #1195896
amd64 linux
system:gcc:alpine3.12:amd64

00:11:56

failed #1195906
amd64 linux
system:gcc:asan

00:13:07

failed #1195900
amd64 linux
system:gcc:buster:amd64

00:10:24

failed #1195897
amd64 linux
system:gcc:centos7:amd64

00:10:52

failed #1195898
amd64 linux
system:gcc:centos8:amd64

00:11:32

failed #1195905
amd64 linux
system:gcc:focal:amd64

00:10:47

failed #1195910
amd64 linux
system:gcc:mutexatomics

00:11:40

failed #1195901
amd64 linux
system:gcc:sid:amd64

00:11:27

failed #1195902
i386 linux
system:gcc:sid:i386

00:10:59

failed #1195912
amd64 linux
system:gcc:softhsm2.4

00:11:27

failed #1195913
amd64 linux
system:gcc:softhsm2.6

00:11:10

failed #1195899
amd64 linux
system:gcc:stretch:amd64

00:10:30

failed #1195908
amd64 linux allowed to fail
system:gcc:tsan

00:13:42

failed #1195903
amd64 linux
system:gcc:tumbleweed:amd64

00:10:28

failed #1195904
amd64 linux
system:gcc:xenial:amd64

00:10:28

 
  Docs
passed #1195916
amd64 linux
docs

00:00:40

 
  Postcheck
passed #1195920
amd64 linux
cppcheck

00:00:40

passed #1195917
amd64 linux
flake8

00:00:21

passed #1195918
amd64 linux
pylint

00:00:21

passed #1195919
amd64 linux
scan-build

00:04:16

 
Name Stage Failure
failed
system:clang:tsan System
FAIL shutdown (exit status: 1)

$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 1537 files

Uploading artifacts as "archive" to coordinator... ok
id=1195909 responseStatus=201 Created token=NCC-4YbN
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:tsan System
FAIL shutdown (exit status: 1)

$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 1536 files

Uploading artifacts as "archive" to coordinator... ok
id=1195908 responseStatus=201 Created token=QZR5d3Uk
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:asan System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4560 files

Uploading artifacts as "archive" to coordinator... ok
id=1195906 responseStatus=201 Created token=42zmxa9Q
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:clang:asan System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4497 files

Uploading artifacts as "archive" to coordinator... ok
id=1195907 responseStatus=201 Created token=Dy1TmV9h
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:sid:amd64 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4540 files

Uploading artifacts as "archive" to coordinator... ok
id=1195901 responseStatus=201 Created token=krgwe71f
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:clang:buster:amd64 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4521 files

Uploading artifacts as "archive" to coordinator... ok
id=1195911 responseStatus=201 Created token=gGzQxyJA
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:alpine3.12:amd64 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4434 files

Uploading artifacts as "archive" to coordinator... ok
id=1195896 responseStatus=201 Created token=PeTJ315L
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:mutexatomics System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 5022 files

Uploading artifacts as "archive" to coordinator... ok
id=1195910 responseStatus=201 Created token=Ekn3u74-
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:centos8:amd64 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4258 files

Uploading artifacts as "archive" to coordinator... ok
id=1195898 responseStatus=201 Created token=HCapHpmz
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:softhsm2.4 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4539 files

Uploading artifacts as "archive" to coordinator... ok
id=1195912 responseStatus=201 Created token=eeruxD1s
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:focal:amd64 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4402 files

Uploading artifacts as "archive" to coordinator... ok
id=1195905 responseStatus=201 Created token=R-H4soYp
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:softhsm2.6 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 3736 files

Uploading artifacts as "archive" to coordinator... ok
id=1195913 responseStatus=201 Created token=RRyEfmQH
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:clang:freebsd12:amd64 System
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
Runtime platform
arch=amd64 os=freebsd pid=58921 revision=86ad88ea version=13.3.0
untracked: found 4529 files

Uploading artifacts as "archive" to coordinator... ok
id=1195915 responseStatus=201 Created token=nRURuJkQ
Cleaning up file based variables
Unsupported run stage 'cleanup_file_variables'
ERROR: Job failed: exit status 1
failed
system:gcc:sid:i386 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4488 files

Uploading artifacts as "archive" to coordinator... ok
id=1195902 responseStatus=201 Created token=xXsHKK_K
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:centos7:amd64 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4544 files

Uploading artifacts as "archive" to coordinator... ok
id=1195897 responseStatus=201 Created token=1oqGnhXd
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:stretch:amd64 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4440 files

Uploading artifacts as "archive" to coordinator... ok
id=1195899 responseStatus=201 Created token=8PJDuEtW
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:tumbleweed:amd64 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4467 files

Uploading artifacts as "archive" to coordinator... ok
id=1195903 responseStatus=201 Created token=ajxXrpfn
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:clang:freebsd11:amd64 System
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
Runtime platform
arch=amd64 os=freebsd pid=54294 revision=86ad88ea version=13.3.0
untracked: found 4440 files

Uploading artifacts as "archive" to coordinator... ok
id=1195914 responseStatus=201 Created token=yoe2tJQQ
Cleaning up file based variables
Unsupported run stage 'cleanup_file_variables'
ERROR: Job failed: exit status 1
failed
system:gcc:xenial:amd64 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4402 files

Uploading artifacts as "archive" to coordinator... ok
id=1195904 responseStatus=201 Created token=xJB95Ntx
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:buster:amd64 System
FAIL shutdown (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 4510 files

Uploading artifacts as "archive" to coordinator... ok
id=1195900 responseStatus=201 Created token=G7EhkK2p
Cleaning up file based variables
ERROR: Job failed: exit code 1