Skip to content

GitLab

Add missing lock calls in isc__nm_tcpdns_stoplistening() 

isc__nmsocket_clearcb() can update a socket being processed
on a different thread and without the lock calls tsan errors
can be produced between isc__nm_tcpdns_stoplistening() and
processbuffer().
74 jobs for !4215 with marka-missing-lock-in-isc__nm_tcpdns_stoplistening in 19 minutes and 31 seconds (queued for 7 seconds)
detached
430d74b1
1 related merge request: !4215 Add missing lock calls in isc__nm_tcpdns_stoplistening()
Status Job ID Name Coverage
  Autoconf
passed #1209643
amd64 linux
autoreconf

00:00:18

 
  Precheck
passed #1209645
amd64 linux
clang-format

00:00:17

passed #1209646
amd64 linux
coccinelle

00:03:23

passed #1209647
amd64 linux
danger

00:00:13

passed #1209644
amd64 linux
misc

00:00:12

passed #1209648
amd64 linux
tarball-create

00:01:24

 
  Build
passed #1209661
amd64 linux
clang:asan

00:02:01

passed #1209665
amd64 linux
clang:buster:amd64

00:01:02

passed #1209668
amd64 libvirt
clang:freebsd11:amd64

00:01:10

passed #1209669
amd64 libvirt
clang:freebsd12:amd64

00:01:03

passed #1209670
amd64 libvirt
clang:openbsd:amd64

00:02:27

passed #1209663
amd64 linux
clang:tsan

00:01:16

passed #1209649
amd64 linux
gcc:alpine3.12:amd64

00:01:03

passed #1209660
amd64 linux
gcc:asan

00:01:54

passed #1209653
amd64 linux
gcc:buster:amd64

00:00:45

passed #1209650
amd64 linux
gcc:centos7:amd64

00:00:43

passed #1209651
amd64 linux
gcc:centos8:amd64

00:00:47

passed #1209659
amd64 linux
gcc:focal:amd64

00:01:01

passed #1209664
amd64 linux
gcc:mutexatomics

00:00:49

passed #1209655
amd64 linux
gcc:out-of-tree

00:00:51

passed #1209654
amd64 linux
gcc:sid:amd64

00:01:04

passed #1209656
i386 linux
gcc:sid:i386

00:00:51

passed #1209666
amd64 linux
gcc:softhsm2.4

00:00:53

passed #1209667
amd64 linux
gcc:softhsm2.6

00:00:48

passed #1209652
amd64 linux
gcc:stretch:amd64

00:01:02

passed #1209662
amd64 linux
gcc:tsan

00:01:10

passed #1209657
amd64 linux
gcc:tumbleweed:amd64

00:00:44

passed #1209658
amd64 linux
gcc:xenial:amd64

00:00:53

passed #1209671
amd64 windows
msvc:windows:amd64

00:00:44

 
  Unit
passed #1209683
amd64 linux
unit:clang:asan

00:01:25

passed #1209687
amd64 linux
unit:clang:buster:amd64

00:00:54

passed #1209690
amd64 libvirt
unit:clang:freebsd11:amd64

00:01:20

passed #1209691
amd64 libvirt
unit:clang:freebsd12:amd64

00:01:23

passed #1209685
amd64 linux
unit:clang:tsan

00:03:08

passed #1209672
amd64 linux
unit:gcc:alpine3.12:amd64

00:00:55

passed #1209682
amd64 linux
unit:gcc:asan

00:01:20

passed #1209676
amd64 linux
unit:gcc:buster:amd64

00:01:01

passed #1209673
amd64 linux
unit:gcc:centos7:amd64

00:00:56

passed #1209674
amd64 linux
unit:gcc:centos8:amd64

00:00:59

passed #1209681
amd64 linux
unit:gcc:focal:amd64

00:01:00

passed #1209686
amd64 linux
unit:gcc:mutexatomics

00:01:02

passed #1209677
amd64 linux
unit:gcc:sid:amd64

00:00:59

passed #1209678
i386 linux
unit:gcc:sid:i386

00:01:03

passed #1209688
amd64 linux
unit:gcc:softhsm2.4

00:00:59

passed #1209689
amd64 linux
unit:gcc:softhsm2.6

00:00:58

passed #1209675
amd64 linux
unit:gcc:stretch:amd64

00:00:58

passed #1209684
amd64 linux
unit:gcc:tsan

00:04:13

passed #1209679
amd64 linux
unit:gcc:tumbleweed:amd64

00:00:56

passed #1209680
amd64 linux
unit:gcc:xenial:amd64

00:00:58

 
  System
passed #1209703
amd64 linux
system:clang:asan

00:12:56

failed #1209707
amd64 linux
system:clang:buster:amd64

00:11:42

passed #1209710
amd64 libvirt
system:clang:freebsd11:amd64

00:10:19

failed #1209711
amd64 libvirt
system:clang:freebsd12:amd64

00:10:37

failed #1209705
amd64 linux allowed to fail
system:clang:tsan

00:14:54

passed #1209692
amd64 linux
system:gcc:alpine3.12:amd64

00:11:51

passed #1209702
amd64 linux
system:gcc:asan

00:13:22

passed #1209696
amd64 linux
system:gcc:buster:amd64

00:10:45

passed #1209693
amd64 linux
system:gcc:centos7:amd64

00:11:42

passed #1209694
amd64 linux
system:gcc:centos8:amd64

00:11:56

passed #1209701
amd64 linux
system:gcc:focal:amd64

00:11:54

passed #1209706
amd64 linux
system:gcc:mutexatomics

00:11:29

passed #1209697
amd64 linux
system:gcc:sid:amd64

00:11:56

passed #1209698
i386 linux
system:gcc:sid:i386

00:11:42

passed #1209708
amd64 linux
system:gcc:softhsm2.4

00:11:37

passed #1209709
amd64 linux
system:gcc:softhsm2.6

00:11:55

passed #1209695
amd64 linux
system:gcc:stretch:amd64

00:11:25

passed #1209704
amd64 linux
system:gcc:tsan

00:15:11

passed #1209699
amd64 linux
system:gcc:tumbleweed:amd64

00:10:52

passed #1209700
amd64 linux
system:gcc:xenial:amd64

00:09:52

 
  Docs
passed #1209712
amd64 linux
docs

00:00:29

 
  Postcheck
passed #1209716
amd64 linux
cppcheck

00:00:45

passed #1209713
amd64 linux
flake8

00:00:17

passed #1209714
amd64 linux
pylint

00:00:22

passed #1209715
amd64 linux
scan-build

00:04:17

 
Name Stage Failure
failed
system:clang:tsan System 
FAIL shutdown (exit status: 1)

$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 1515 files                        
Uploading artifacts as "archive" to coordinator... ok  id=1209705 responseStatus=201 Created token=pXyhiFDD
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:clang:buster:amd64 System 
FAIL inline (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 2072 files                        
Uploading artifacts as "archive" to coordinator... ok  id=1209707 responseStatus=201 Created token=7JBaoHtC
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:clang:freebsd12:amd64 System 
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
Runtime platform                                    arch=amd64 os=freebsd pid=60044 revision=86ad88ea version=13.3.0
untracked: found 1523 files                        
Uploading artifacts as "archive" to coordinator... ok  id=1209711 responseStatus=201 Created token=ZCxfGFHv
Cleaning up file based variables
Unsupported run stage 'cleanup_file_variables'
ERROR: Job failed: exit status 1