Clone the csock in accept_connection(), not in callback

If we clone the csock (children socket) in TCP accept_connection()
instead of passing the ssock (server socket) to the call back and
cloning it there we unbreak the assumption that every socket is handled
inside it's own worker thread and therefore we can get rid of (at least)
callback locking.
74 jobs for !4220 with ondrej/clean-netmgr-callback-locks in 17 minutes and 42 seconds (queued for 7 seconds)
detached
Status Job ID Name Coverage
  Autoconf
passed #1210228
amd64 linux
autoreconf

00:00:16

 
  Precheck
passed #1210230
amd64 linux
clang-format

00:00:17

passed #1210231
amd64 linux
coccinelle

00:03:21

passed #1210232
amd64 linux
danger

00:00:14

passed #1210229
amd64 linux
misc

00:00:12

passed #1210233
amd64 linux
tarball-create

00:01:37

 
  Build
passed #1210246
amd64 linux
clang:asan

00:02:06

passed #1210250
amd64 linux
clang:buster:amd64

00:01:00

passed #1210253
amd64 libvirt
clang:freebsd11:amd64

00:01:06

passed #1210254
amd64 libvirt
clang:freebsd12:amd64

00:01:03

passed #1210255
amd64 libvirt
clang:openbsd:amd64

00:02:35

passed #1210248
amd64 linux
clang:tsan

00:01:15

passed #1210234
amd64 linux
gcc:alpine3.12:amd64

00:00:50

passed #1210245
amd64 linux
gcc:asan

00:01:33

passed #1210238
amd64 linux
gcc:buster:amd64

00:00:59

passed #1210235
amd64 linux
gcc:centos7:amd64

00:00:51

passed #1210236
amd64 linux
gcc:centos8:amd64

00:00:59

passed #1210244
amd64 linux
gcc:focal:amd64

00:00:56

passed #1210249
amd64 linux
gcc:mutexatomics

00:01:00

passed #1210240
amd64 linux
gcc:out-of-tree

00:00:55

passed #1210239
amd64 linux
gcc:sid:amd64

00:01:00

passed #1210241
i386 linux
gcc:sid:i386

00:00:55

passed #1210251
amd64 linux
gcc:softhsm2.4

00:00:59

passed #1210252
amd64 linux
gcc:softhsm2.6

00:01:00

passed #1210237
amd64 linux
gcc:stretch:amd64

00:01:05

passed #1210247
amd64 linux
gcc:tsan

00:01:04

passed #1210242
amd64 linux
gcc:tumbleweed:amd64

00:00:58

passed #1210243
amd64 linux
gcc:xenial:amd64

00:01:00

passed #1210256
amd64 windows
msvc:windows:amd64

00:00:44

 
  Unit
passed #1210268
amd64 linux
unit:clang:asan

00:01:18

passed #1210272
amd64 linux
unit:clang:buster:amd64

00:01:00

passed #1210275
amd64 libvirt
unit:clang:freebsd11:amd64

00:01:19

passed #1210276
amd64 libvirt
unit:clang:freebsd12:amd64

00:01:21

passed #1210270
amd64 linux
unit:clang:tsan

00:03:03

passed #1210257
amd64 linux
unit:gcc:alpine3.12:amd64

00:01:07

passed #1210267
amd64 linux
unit:gcc:asan

00:01:17

passed #1210261
amd64 linux
unit:gcc:buster:amd64

00:00:59

passed #1210258
amd64 linux
unit:gcc:centos7:amd64

00:00:59

passed #1210259
amd64 linux
unit:gcc:centos8:amd64

00:00:58

passed #1210266
amd64 linux
unit:gcc:focal:amd64

00:00:58

passed #1210271
amd64 linux
unit:gcc:mutexatomics

00:01:01

passed #1210262
amd64 linux
unit:gcc:sid:amd64

00:01:02

passed #1210263
i386 linux
unit:gcc:sid:i386

00:00:59

passed #1210273
amd64 linux
unit:gcc:softhsm2.4

00:01:03

passed #1210274
amd64 linux
unit:gcc:softhsm2.6

00:01:01

passed #1210260
amd64 linux
unit:gcc:stretch:amd64

00:01:04

passed #1210269
amd64 linux
unit:gcc:tsan

00:04:00

passed #1210264
amd64 linux
unit:gcc:tumbleweed:amd64

00:00:59

passed #1210265
amd64 linux
unit:gcc:xenial:amd64

00:01:00

 
  System
passed #1210288
amd64 linux
system:clang:asan

00:12:34

passed #1210292
amd64 linux
system:clang:buster:amd64

00:11:08

passed #1210295
amd64 libvirt
system:clang:freebsd11:amd64

00:10:18

passed #1210296
amd64 libvirt
system:clang:freebsd12:amd64

00:10:26

passed #1210290
amd64 linux
system:clang:tsan

00:14:39

passed #1210277
amd64 linux
system:gcc:alpine3.12:amd64

00:12:07

passed #1210287
amd64 linux
system:gcc:asan

00:13:24

passed #1210281
amd64 linux
system:gcc:buster:amd64

00:10:46

passed #1210278
amd64 linux
system:gcc:centos7:amd64

00:11:38

passed #1210279
amd64 linux
system:gcc:centos8:amd64

00:11:52

passed #1210286
amd64 linux
system:gcc:focal:amd64

00:11:19

passed #1210291
amd64 linux
system:gcc:mutexatomics

00:11:19

passed #1210282
amd64 linux
system:gcc:sid:amd64

00:11:15

passed #1210283
i386 linux
system:gcc:sid:i386

00:12:47

passed #1210293
amd64 linux
system:gcc:softhsm2.4

00:11:20

passed #1210294
amd64 linux
system:gcc:softhsm2.6

00:11:02

passed #1210280
amd64 linux
system:gcc:stretch:amd64

00:11:49

passed #1210289
amd64 linux
system:gcc:tsan

00:15:15

passed #1210284
amd64 linux
system:gcc:tumbleweed:amd64

00:11:14

passed #1210285
amd64 linux
system:gcc:xenial:amd64

00:11:01

 
  Docs
passed #1210297
amd64 linux
docs

00:00:41

 
  Postcheck
passed #1210301
amd64 linux
cppcheck

00:00:53

passed #1210298
amd64 linux
flake8

00:00:28

passed #1210299
amd64 linux
pylint

00:00:25

passed #1210300
amd64 linux
scan-build

00:04:27