Skip to content

GitLab

BIND
BIND

Clone the csock in accept_connection(), not in callback 

If we clone the csock (children socket) in TCP accept_connection()
instead of passing the ssock (server socket) to the call back and
cloning it there we unbreak the assumption that every socket is handled
inside it's own worker thread and therefore we can get rid of (at least)
callback locking.

(cherry picked from commit e8b56acb)
82 jobs for !4252 with ondrej/clean-netmgr-callback-locks-v9_16 in 30 minutes and 17 seconds (queued for 26 seconds)
detached
53d6a11a
1 related merge request: !4252 Clean netmgr callback locks (v9.16)
Status Job ID Name Coverage
  Precheck
passed #1210696
amd64 linux
autoreconf

00:00:16

passed #1210698
amd64 linux
clang-format

00:00:19

passed #1210699
amd64 linux
coccinelle

00:03:28

passed #1210700
amd64 linux
danger

00:00:14

passed #1210697
amd64 linux
misc

00:00:13

 
  Build
passed #1210714
amd64 linux
clang:asan

00:03:51

passed #1210718
amd64 linux
clang:buster:amd64

00:01:46

passed #1210721
amd64 libvirt
clang:freebsd11:amd64

00:02:00

passed #1210722
amd64 libvirt
clang:freebsd12:amd64

00:01:39

passed #1210723
amd64 libvirt
clang:openbsd:amd64

00:03:54

passed #1210716
amd64 linux
clang:tsan

00:02:22

passed #1210701
amd64 linux
gcc:alpine3.12:amd64

00:01:41

passed #1210713
amd64 linux
gcc:asan

00:03:26

passed #1210706
amd64 linux
gcc:buster:amd64

00:01:57

passed #1210702
amd64 linux
gcc:centos6:amd64

00:01:23

passed #1210703
amd64 linux
gcc:centos7:amd64

00:01:32

passed #1210704
amd64 linux
gcc:centos8:amd64

00:01:38

passed #1210712
amd64 linux
gcc:focal:amd64

00:01:36

passed #1210717
amd64 linux
gcc:mutexatomics

00:02:01

passed #1210708
amd64 linux
gcc:out-of-tree

00:01:56

passed #1210707
amd64 linux
gcc:sid:amd64

00:02:16

passed #1210709
i386 linux
gcc:sid:i386

00:01:43

passed #1210719
amd64 linux
gcc:softhsm2.4

00:01:40

passed #1210720
amd64 linux
gcc:softhsm2.6

00:01:26

passed #1210705
amd64 linux
gcc:stretch:amd64

00:01:59

passed #1210715
amd64 linux
gcc:tsan

00:01:59

passed #1210710
amd64 linux
gcc:tumbleweed:amd64

00:01:35

passed #1210711
amd64 linux
gcc:xenial:amd64

00:01:48

passed #1210725
amd64 windows
msvc:windows:amd64

00:01:08

passed #1210724
amd64 linux
nolibtool:sid:amd64

00:02:10

 
  Unit
passed #1210738
amd64 linux
unit:clang:asan

00:00:54

passed #1210742
amd64 linux
unit:clang:buster:amd64

00:00:32

passed #1210745
amd64 libvirt
unit:clang:freebsd11:amd64

00:01:02

passed #1210746
amd64 libvirt
unit:clang:freebsd12:amd64

00:01:00

passed #1210740
amd64 linux
unit:clang:tsan

00:01:22

passed #1210726
amd64 linux
unit:gcc:alpine3.12:amd64

00:00:44

passed #1210737
amd64 linux
unit:gcc:asan

00:00:51

passed #1210731
amd64 linux
unit:gcc:buster:amd64

00:00:36

passed #1210727
amd64 linux
unit:gcc:centos6:amd64

00:00:36

passed #1210728
amd64 linux
unit:gcc:centos7:amd64

00:00:39

passed #1210729
amd64 linux
unit:gcc:centos8:amd64

00:00:44

passed #1210736
amd64 linux
unit:gcc:focal:amd64

00:00:38

passed #1210741
amd64 linux
unit:gcc:mutexatomics

00:00:37

passed #1210732
amd64 linux
unit:gcc:sid:amd64

00:00:34

passed #1210733
i386 linux
unit:gcc:sid:i386

00:00:42

passed #1210743
amd64 linux
unit:gcc:softhsm2.4

00:00:38

passed #1210744
amd64 linux
unit:gcc:softhsm2.6

00:00:40

passed #1210730
amd64 linux
unit:gcc:stretch:amd64

00:00:38

passed #1210739
amd64 linux
unit:gcc:tsan

00:01:47

passed #1210734
amd64 linux
unit:gcc:tumbleweed:amd64

00:00:35

passed #1210735
amd64 linux
unit:gcc:xenial:amd64

00:00:38

passed #1210747
amd64 linux
unit:nolibtool:sid:amd64

00:00:48

 
  System
passed #1210760
amd64 linux
system:clang:asan

00:12:27

passed #1210764
amd64 linux
system:clang:buster:amd64

00:11:13

passed #1210767
amd64 libvirt
system:clang:freebsd11:amd64

00:10:16

passed #1210768
amd64 libvirt
system:clang:freebsd12:amd64

00:10:17

passed #1210762
amd64 linux
system:clang:tsan

00:14:48

passed #1210748
amd64 linux
system:gcc:alpine3.12:amd64

00:11:52

passed #1210759
amd64 linux
system:gcc:asan

00:13:11

passed #1210753
amd64 linux
system:gcc:buster:amd64

00:11:30

passed #1210749
amd64 linux
system:gcc:centos6:amd64

00:11:36

passed #1210750
amd64 linux
system:gcc:centos7:amd64

00:10:59

passed #1210751
amd64 linux
system:gcc:centos8:amd64

00:11:31

passed #1210758
amd64 linux
system:gcc:focal:amd64

00:11:30

passed #1210763
amd64 linux
system:gcc:mutexatomics

00:10:50

passed #1210754
amd64 linux
system:gcc:sid:amd64

00:10:40

passed #1210755
i386 linux
system:gcc:sid:i386

00:10:36

passed #1210765
amd64 linux
system:gcc:softhsm2.4

00:10:58

passed #1210766
amd64 linux
system:gcc:softhsm2.6

00:11:26

passed #1210752
amd64 linux
system:gcc:stretch:amd64

00:11:07

passed #1210761
amd64 linux
system:gcc:tsan

00:14:36

passed #1211083
amd64 linux
system:gcc:tumbleweed:amd64

00:10:15

passed #1210757
amd64 linux
system:gcc:xenial:amd64

00:10:47

passed #1210769
amd64 linux
system:nolibtool:sid:amd64

00:11:30

failed #1210998
linux amd64
system:gcc:tumbleweed:amd64

00:11:43

failed #1210756
amd64 linux
system:gcc:tumbleweed:amd64

00:11:08

 
  Docs
passed #1210999
linux amd64
docs

00:02:20

failed #1210770
amd64 linux
docs

00:02:01

 
  Postcheck
passed #1210774
amd64 linux
cppcheck

00:00:21

passed #1210771
amd64 linux
flake8

00:00:17

passed #1210772
amd64 linux
pylint

00:00:21

passed #1210773
amd64 linux
scan-build

00:09:20