Convert add_quota() to a function

cppcheck 2.2 reports the following false positive:

    lib/isc/tests/quota_test.c:71:21: error: Array 'quotas[101]' accessed at index 110, which is out of bounds. [arrayIndexOutOfBounds]
     isc_quota_t *quotas[110];
                        ^

The above is not even an array access, so this report is obviously
caused by a cppcheck bug.  Yet, it seems to be triggered by the presence
of the add_quota() macro, which should really be a function.  Convert
the add_quota() macro to a function in order to make the code cleaner
and to prevent the above cppcheck 2.2 false positive from being
triggered.
75 jobs for !4292 with michal/fix-cppcheck-2.2-issues in 18 minutes and 44 seconds (queued for 10 seconds)
detached
Status Job ID Name Coverage
  Autoconf
passed #1239478
amd64 linux
autoreconf

00:00:19

 
  Precheck
failed #1239480
amd64 linux
clang-format

00:00:17

passed #1239481
amd64 linux
coccinelle

00:03:36

passed #1239482
amd64 linux
danger

00:00:14

passed #1239479
amd64 linux
misc

00:00:13

passed #1239483
amd64 linux
tarball-create

00:01:29

 
  Build
passed #1239496
amd64 linux
clang:asan

00:01:56

passed #1239500
amd64 linux
clang:buster:amd64

00:00:58

passed #1239503
amd64 libvirt
clang:freebsd11:amd64

00:01:09

passed #1239504
amd64 libvirt
clang:freebsd12:amd64

00:01:13

passed #1239505
amd64 libvirt
clang:openbsd:amd64

00:02:33

passed #1239498
amd64 linux
clang:tsan

00:01:16

passed #1239484
amd64 linux
gcc:alpine3.12:amd64

00:00:53

passed #1239495
amd64 linux
gcc:asan

00:01:47

passed #1239488
amd64 linux
gcc:buster:amd64

00:00:54

passed #1239485
amd64 linux
gcc:centos7:amd64

00:00:51

passed #1239486
amd64 linux
gcc:centos8:amd64

00:00:50

passed #1239494
amd64 linux
gcc:focal:amd64

00:00:51

passed #1239499
amd64 linux
gcc:mutexatomics

00:00:58

passed #1239490
amd64 linux
gcc:out-of-tree

00:00:54

passed #1239489
amd64 linux
gcc:sid:amd64

00:01:08

passed #1239491
i386 linux
gcc:sid:i386

00:01:02

passed #1239501
amd64 linux
gcc:softhsm2.4

00:00:51

passed #1239502
amd64 linux
gcc:softhsm2.6

00:00:51

passed #1239487
amd64 linux
gcc:stretch:amd64

00:00:56

passed #1239497
amd64 linux
gcc:tsan

00:01:02

passed #1239492
amd64 linux
gcc:tumbleweed:amd64

00:00:51

passed #1239493
amd64 linux
gcc:xenial:amd64

00:00:59

passed #1239506
amd64 windows
msvc:windows:amd64

00:01:55

 
  Unit
passed #1239518
amd64 linux
unit:clang:asan

00:01:25

passed #1239522
amd64 linux
unit:clang:buster:amd64

00:01:01

passed #1239525
amd64 libvirt
unit:clang:freebsd11:amd64

00:01:33

passed #1239526
amd64 libvirt
unit:clang:freebsd12:amd64

00:01:23

passed #1239527
amd64 libvirt
unit:clang:openbsd:amd64

00:02:45

passed #1239520
amd64 linux
unit:clang:tsan

00:03:24

passed #1239507
amd64 linux
unit:gcc:alpine3.12:amd64

00:01:07

passed #1239517
amd64 linux
unit:gcc:asan

00:01:17

passed #1239511
amd64 linux
unit:gcc:buster:amd64

00:01:02

passed #1239508
amd64 linux
unit:gcc:centos7:amd64

00:00:57

passed #1239509
amd64 linux
unit:gcc:centos8:amd64

00:00:58

passed #1239516
amd64 linux
unit:gcc:focal:amd64

00:00:59

passed #1239521
amd64 linux
unit:gcc:mutexatomics

00:00:59

passed #1239512
amd64 linux
unit:gcc:sid:amd64

00:00:59

passed #1239513
i386 linux
unit:gcc:sid:i386

00:01:07

passed #1239523
amd64 linux
unit:gcc:softhsm2.4

00:00:59

passed #1239524
amd64 linux
unit:gcc:softhsm2.6

00:01:01

passed #1239510
amd64 linux
unit:gcc:stretch:amd64

00:00:56

passed #1239519
amd64 linux
unit:gcc:tsan

00:04:02

passed #1239514
amd64 linux
unit:gcc:tumbleweed:amd64

00:00:57

passed #1239515
amd64 linux
unit:gcc:xenial:amd64

00:01:04

 
  System
passed #1239539
amd64 linux
system:clang:asan

00:12:54

passed #1239543
amd64 linux
system:clang:buster:amd64

00:12:07

passed #1239546
amd64 libvirt
system:clang:freebsd11:amd64

00:10:16

passed #1239547
amd64 libvirt
system:clang:freebsd12:amd64

00:10:43

passed #1239541
amd64 linux
system:clang:tsan

00:13:57

passed #1239528
amd64 linux
system:gcc:alpine3.12:amd64

00:11:34

passed #1239538
amd64 linux
system:gcc:asan

00:13:27

passed #1239532
amd64 linux
system:gcc:buster:amd64

00:11:18

passed #1239529
amd64 linux
system:gcc:centos7:amd64

00:11:25

passed #1239530
amd64 linux
system:gcc:centos8:amd64

00:12:06

passed #1239537
amd64 linux
system:gcc:focal:amd64

00:11:34

passed #1239542
amd64 linux
system:gcc:mutexatomics

00:11:42

passed #1239533
amd64 linux
system:gcc:sid:amd64

00:11:01

passed #1239534
i386 linux
system:gcc:sid:i386

00:11:44

passed #1239544
amd64 linux
system:gcc:softhsm2.4

00:12:19

passed #1239545
amd64 linux
system:gcc:softhsm2.6

00:11:36

passed #1239531
amd64 linux
system:gcc:stretch:amd64

00:12:16

passed #1239540
amd64 linux
system:gcc:tsan

00:15:28

passed #1239535
amd64 linux
system:gcc:tumbleweed:amd64

00:11:08

passed #1239536
amd64 linux
system:gcc:xenial:amd64

00:11:26

 
  Docs
passed #1239548
amd64 linux
docs

00:00:35

 
  Postcheck
failed #1239552
amd64 linux
cppcheck

00:00:48

passed #1239549
amd64 linux
flake8

00:00:18

passed #1239550
amd64 linux
pylint

00:00:24

passed #1239551
amd64 linux
scan-build

00:04:29

 
Name Stage Failure
failed
cppcheck Postcheck
Open 'cppcheck_html//index.html' to see the results.
Uploading artifacts for failed job
Uploading artifacts...
compile_commands.json: found 1 matching files and directories

cppcheck.results: found 1 matching files and directories

cppcheck_html/: found 30 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=1239552 responseStatus=201 Created token=TMT6csc2
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
clang-format Precheck
Removing util/check-make-install

Skipping Git submodules setup
Executing "step_script" stage of the job script
$ if [ -r .clang-format ]; then "${CLANG_FORMAT}" -i -style=file $(git ls-files '*.c' '*.h'); fi
$ if test "$(git status --porcelain | grep -Ev '\?\?' | wc -l)" -gt "0"; then git status --short; exit 1; fi
M lib/isc/tests/quota_test.c
Cleaning up file based variables
ERROR: Job failed: exit code 1