Move logging of salt in separate function

There may be a desire to log the salt without losing the context
of log module, level, and category.
76 jobs for !4299 with 1620-dnssec-policy-nsec3-saltlen in 17 minutes and 8 seconds (queued for 9 seconds)
detached
Status Job ID Name Coverage
  Autoconf
passed #1251074
amd64 linux
autoreconf

00:00:17

 
  Precheck
passed #1251076
amd64 linux
clang-format

00:00:17

passed #1251077
amd64 linux
coccinelle

00:03:37

failed #1251078
amd64 linux
danger

00:00:16

failed #1251075
amd64 linux
misc

00:00:11

passed #1251079
amd64 linux
tarball-create

00:01:27

 
  Build
passed #1251092
amd64 linux
clang:asan

00:02:07

passed #1251096
amd64 linux
clang:buster:amd64

00:00:56

passed #1251099
amd64 libvirt
clang:freebsd11:amd64

00:01:17

passed #1251100
amd64 libvirt
clang:freebsd12:amd64

00:01:17

passed #1251101
amd64 libvirt
clang:openbsd:amd64

00:02:28

passed #1251094
amd64 linux
clang:tsan

00:01:12

passed #1251080
amd64 linux
gcc:alpine3.12:amd64

00:00:55

passed #1251091
amd64 linux
gcc:asan

00:01:55

passed #1251084
amd64 linux
gcc:buster:amd64

00:00:48

passed #1251081
amd64 linux
gcc:centos7:amd64

00:00:53

passed #1251082
amd64 linux
gcc:centos8:amd64

00:00:51

passed #1251090
amd64 linux
gcc:focal:amd64

00:00:47

passed #1251095
amd64 linux
gcc:mutexatomics

00:00:59

passed #1251086
amd64 linux
gcc:out-of-tree

00:01:01

passed #1251085
amd64 linux
gcc:sid:amd64

00:01:06

passed #1251087
i386 linux
gcc:sid:i386

00:00:59

passed #1251097
amd64 linux
gcc:softhsm2.4

00:00:55

passed #1251098
amd64 linux
gcc:softhsm2.6

00:00:52

passed #1251083
amd64 linux
gcc:stretch:amd64

00:01:07

passed #1251093
amd64 linux
gcc:tsan

00:01:13

passed #1251088
amd64 linux
gcc:tumbleweed:amd64

00:01:00

passed #1251089
amd64 linux
gcc:xenial:amd64

00:00:57

passed #1251102
amd64 windows
msvc:windows:amd64

00:02:00

 
  Unit
passed #1251114
amd64 linux
unit:clang:asan

00:01:15

passed #1251118
amd64 linux
unit:clang:buster:amd64

00:00:57

passed #1251121
amd64 libvirt
unit:clang:freebsd11:amd64

00:01:29

passed #1251122
amd64 libvirt
unit:clang:freebsd12:amd64

00:01:24

passed #1251123
amd64 libvirt
unit:clang:openbsd:amd64

00:02:45

passed #1251116
amd64 linux
unit:clang:tsan

00:02:58

passed #1251103
amd64 linux
unit:gcc:alpine3.12:amd64

00:01:02

passed #1251113
amd64 linux
unit:gcc:asan

00:01:23

passed #1251107
amd64 linux
unit:gcc:buster:amd64

00:02:06

passed #1251104
amd64 linux
unit:gcc:centos7:amd64

00:01:03

passed #1251105
amd64 linux
unit:gcc:centos8:amd64

00:00:56

passed #1251112
amd64 linux
unit:gcc:focal:amd64

00:00:55

passed #1251117
amd64 linux
unit:gcc:mutexatomics

00:00:58

passed #1251108
amd64 linux
unit:gcc:sid:amd64

00:01:01

passed #1251109
i386 linux
unit:gcc:sid:i386

00:01:02

passed #1251119
amd64 linux
unit:gcc:softhsm2.4

00:00:58

passed #1251120
amd64 linux
unit:gcc:softhsm2.6

00:00:55

passed #1251106
amd64 linux
unit:gcc:stretch:amd64

00:00:55

passed #1251115
amd64 linux
unit:gcc:tsan

00:04:00

passed #1251110
amd64 linux
unit:gcc:tumbleweed:amd64

00:00:58

passed #1251111
amd64 linux
unit:gcc:xenial:amd64

00:01:01

 
  System
passed #1251135
amd64 linux
system:clang:asan

00:13:10

passed #1251139
amd64 linux
system:clang:buster:amd64

00:11:23

passed #1251142
amd64 libvirt
system:clang:freebsd11:amd64

00:10:43

passed #1251143
amd64 libvirt
system:clang:freebsd12:amd64

00:10:12

passed #1251137
amd64 linux
system:clang:tsan

00:14:11

passed #1251124
amd64 linux
system:gcc:alpine3.12:amd64

00:11:39

passed #1251134
amd64 linux
system:gcc:asan

00:13:04

passed #1251128
amd64 linux
system:gcc:buster:amd64

00:12:50

passed #1251125
amd64 linux
system:gcc:centos7:amd64

00:11:10

passed #1251126
amd64 linux
system:gcc:centos8:amd64

00:12:03

passed #1251133
amd64 linux
system:gcc:focal:amd64

00:11:20

passed #1251138
amd64 linux
system:gcc:mutexatomics

00:11:05

passed #1251129
amd64 linux
system:gcc:sid:amd64

00:10:05

passed #1251130
i386 linux
system:gcc:sid:i386

00:11:08

passed #1251140
amd64 linux
system:gcc:softhsm2.4

00:11:07

passed #1251141
amd64 linux
system:gcc:softhsm2.6

00:11:58

passed #1251127
amd64 linux
system:gcc:stretch:amd64

00:10:05

passed #1251136
amd64 linux
system:gcc:tsan

00:14:34

passed #1251131
amd64 linux
system:gcc:tumbleweed:amd64

00:10:46

passed #1251132
amd64 linux
system:gcc:xenial:amd64

00:10:03

 
  Docs
passed #1251144
amd64 linux
docs

00:00:34

 
  Postcheck
passed #1251148
amd64 linux
cppcheck

00:00:42

passed #1251145
amd64 linux
flake8

00:00:18

passed #1251149
amd64 linux
gcov

00:00:33

77.0%
passed #1251146
amd64 linux
pylint

00:00:21

passed #1251147
amd64 linux
scan-build

00:04:07

 
Name Stage Failure
failed
danger Precheck
 * branch            main       -> FETCH_HEAD



Failing the build, there are 4 fails.
Feedback: https://gitlab.isc.org/isc-projects/bind9/merge_requests/4299#note_172473

Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
misc Precheck
Executing "step_script" stage of the job script
$ sh util/checklibs.sh > checklibs.out
Uploading artifacts for failed job
Uploading artifacts...
WARNING: util/newcopyrights: no matching files
checklibs.out: found 1 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=1251075 responseStatus=201 Created token=-QW1f9Ne
Cleaning up file based variables
ERROR: Job failed: exit code 1