enable keepalive when the keepalive EDNS option is seen

previously, receiving a keepalive option had no effect on how
long named would keep the connection open; there was a place to
configure the keepalive timeout but it was never used. this commit
corrects that.
76 jobs for !4348 with 1927-fix-keepalive in 19 minutes and 25 seconds (queued for 7 seconds)
latest detached
Status Job ID Name Coverage
  Autoconf
passed #1270195
amd64 linux
autoreconf

00:00:17

 
  Precheck
passed #1270197
amd64 linux
clang-format

00:00:16

passed #1270198
amd64 linux
coccinelle

00:03:41

failed #1270199
amd64 linux
danger

00:00:13

passed #1270196
amd64 linux
misc

00:00:12

passed #1270200
amd64 linux
tarball-create

00:01:34

 
  Build
passed #1270213
amd64 linux
clang:asan

00:01:53

passed #1270217
amd64 linux
clang:buster:amd64

00:01:03

passed #1270220
amd64 libvirt
clang:freebsd11:amd64

00:01:17

passed #1270221
amd64 libvirt
clang:freebsd12:amd64

00:01:07

passed #1270222
amd64 libvirt
clang:openbsd:amd64

00:02:07

passed #1270215
amd64 linux
clang:tsan

00:01:15

passed #1270201
amd64 linux
gcc:alpine3.12:amd64

00:01:04

passed #1270212
amd64 linux
gcc:asan

00:01:51

passed #1270205
amd64 linux
gcc:buster:amd64

00:00:50

passed #1270202
amd64 linux
gcc:centos7:amd64

00:00:56

passed #1270203
amd64 linux
gcc:centos8:amd64

00:01:03

passed #1270211
amd64 linux
gcc:focal:amd64

00:00:56

passed #1270216
amd64 linux
gcc:mutexatomics

00:00:58

passed #1270207
amd64 linux
gcc:out-of-tree

00:00:54

passed #1270206
amd64 linux
gcc:sid:amd64

00:01:05

passed #1270208
i386 linux
gcc:sid:i386

00:01:05

passed #1270218
amd64 linux
gcc:softhsm2.4

00:00:59

passed #1270219
amd64 linux
gcc:softhsm2.6

00:00:55

passed #1270204
amd64 linux
gcc:stretch:amd64

00:01:01

passed #1270214
amd64 linux
gcc:tsan

00:01:05

passed #1270209
amd64 linux
gcc:tumbleweed:amd64

00:00:50

passed #1270210
amd64 linux
gcc:xenial:amd64

00:00:58

passed #1270223
amd64 windows
msvc:windows:amd64

00:02:06

 
  Unit
passed #1270235
amd64 linux
unit:clang:asan

00:01:16

passed #1270239
amd64 linux
unit:clang:buster:amd64

00:01:02

passed #1270242
amd64 libvirt
unit:clang:freebsd11:amd64

00:01:36

passed #1270243
amd64 libvirt
unit:clang:freebsd12:amd64

00:01:20

passed #1270244
amd64 libvirt
unit:clang:openbsd:amd64

00:03:03

passed #1270237
amd64 linux
unit:clang:tsan

00:03:02

passed #1270224
amd64 linux
unit:gcc:alpine3.12:amd64

00:01:08

passed #1270234
amd64 linux
unit:gcc:asan

00:01:19

passed #1270228
amd64 linux
unit:gcc:buster:amd64

00:02:04

passed #1270225
amd64 linux
unit:gcc:centos7:amd64

00:00:59

passed #1270226
amd64 linux
unit:gcc:centos8:amd64

00:01:01

passed #1270233
amd64 linux
unit:gcc:focal:amd64

00:00:58

passed #1270238
amd64 linux
unit:gcc:mutexatomics

00:00:57

passed #1270229
amd64 linux
unit:gcc:sid:amd64

00:01:05

passed #1270230
i386 linux
unit:gcc:sid:i386

00:01:00

passed #1270240
amd64 linux
unit:gcc:softhsm2.4

00:01:04

passed #1270241
amd64 linux
unit:gcc:softhsm2.6

00:01:00

passed #1270227
amd64 linux
unit:gcc:stretch:amd64

00:00:55

passed #1270236
amd64 linux
unit:gcc:tsan

00:04:04

passed #1270231
amd64 linux
unit:gcc:tumbleweed:amd64

00:01:00

passed #1270232
amd64 linux
unit:gcc:xenial:amd64

00:01:03

 
  System
passed #1270256
amd64 linux
system:clang:asan

00:13:37

passed #1270260
amd64 linux
system:clang:buster:amd64

00:12:32

failed #1270263
amd64 libvirt
system:clang:freebsd11:amd64

00:11:02

failed #1270264
amd64 libvirt
system:clang:freebsd12:amd64

00:11:22

passed #1270258
amd64 linux
system:clang:tsan

00:15:26

passed #1270245
amd64 linux
system:gcc:alpine3.12:amd64

00:12:50

passed #1270255
amd64 linux
system:gcc:asan

00:13:48

failed #1270249
amd64 linux
system:gcc:buster:amd64

00:13:06

passed #1270246
amd64 linux
system:gcc:centos7:amd64

00:12:09

passed #1270247
amd64 linux
system:gcc:centos8:amd64

00:12:50

passed #1270254
amd64 linux
system:gcc:focal:amd64

00:12:35

passed #1270259
amd64 linux
system:gcc:mutexatomics

00:11:49

passed #1270250
amd64 linux
system:gcc:sid:amd64

00:11:45

passed #1270251
i386 linux
system:gcc:sid:i386

00:12:32

passed #1270261
amd64 linux
system:gcc:softhsm2.4

00:12:24

passed #1270262
amd64 linux
system:gcc:softhsm2.6

00:12:22

passed #1270248
amd64 linux
system:gcc:stretch:amd64

00:11:55

passed #1270257
amd64 linux
system:gcc:tsan

00:15:47

passed #1270252
amd64 linux
system:gcc:tumbleweed:amd64

00:12:10

passed #1270253
amd64 linux
system:gcc:xenial:amd64

00:11:52

 
  Docs
passed #1270265
amd64 linux
docs

00:00:31

 
  Postcheck
passed #1270269
amd64 linux
cppcheck

00:00:49

passed #1270266
amd64 linux
flake8

00:00:19

skipped #1270270
amd64 linux
gcov
passed #1270267
amd64 linux
pylint

00:00:22

passed #1270268
amd64 linux
scan-build

00:04:11

 
Name Stage Failure
failed
system:gcc:buster:amd64 System
FAIL kasp (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 5597 files

Uploading artifacts as "archive" to coordinator... ok
id=1270249 responseStatus=201 Created token=tMze4UmR
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:clang:freebsd12:amd64 System
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
Runtime platform
arch=amd64 os=freebsd pid=60141 revision=ece86343 version=13.5.0
untracked: found 1444 files

Uploading artifacts as "archive" to coordinator... ok
id=1270264 responseStatus=201 Created token=87XA1aJa
Cleaning up file based variables
Unsupported run stage 'cleanup_file_variables'
ERROR: Job failed: exit status 1
failed
system:clang:freebsd11:amd64 System
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
Runtime platform
arch=amd64 os=freebsd pid=55329 revision=ece86343 version=13.5.0
untracked: found 2841 files

Uploading artifacts as "archive" to coordinator... ok
id=1270263 responseStatus=201 Created token=_xg6RWNA
Cleaning up file based variables
Unsupported run stage 'cleanup_file_variables'
ERROR: Job failed: exit status 1
failed
danger Precheck
 * [new branch]      main       -> origin/main



Failing the build, there is 1 fail.
Feedback: https://gitlab.isc.org/isc-projects/bind9/merge_requests/4348#note_174143

Cleaning up file based variables
ERROR: Job failed: exit code 1