handle TCP connect failure in TLS

wait for the TCP connect to complete before returning from
isc_nm_tlsconnect(), and pass back the error code to the caller
if there's a failure. this now matches the behavior of
isc_nm_tcpconnect(), and enables isc_nm_tcpdnsconnect() and
isc_nm_tlsdnsconnect() to behave consistently as well.
79 jobs for !4388 with each-tcp-connect-err in 28 minutes and 16 seconds (queued for 9 seconds)
latest detached
Status Job ID Name Coverage
  Autoconf
passed #1292485
amd64 linux
autoreconf

00:00:17

 
  Precheck
passed #1292487
amd64 linux
clang-format

00:00:16

passed #1292488
amd64 linux
coccinelle

00:03:24

passed #1292561
linux amd64
danger

00:00:14

passed #1292486
amd64 linux
misc

00:00:20

passed #1292490
amd64 linux
tarball-create

00:01:37

failed #1292489
amd64 linux
danger

00:00:14

 
  Build
passed #1292503
amd64 linux
clang:asan

00:02:09

passed #1292507
amd64 linux
clang:buster:amd64

00:01:00

passed #1292510
amd64 libvirt
clang:freebsd11:amd64

00:01:11

passed #1292511
amd64 libvirt
clang:freebsd12:amd64

00:01:02

passed #1292512
amd64 libvirt
clang:openbsd:amd64

00:02:16

passed #1292505
amd64 linux
clang:tsan

00:01:10

passed #1292491
amd64 linux
gcc:alpine3.12:amd64

00:01:01

passed #1292502
amd64 linux
gcc:asan

00:01:32

passed #1292495
amd64 linux
gcc:buster:amd64

00:00:54

passed #1292492
amd64 linux
gcc:centos7:amd64

00:00:50

passed #1292493
amd64 linux
gcc:centos8:amd64

00:00:58

passed #1292501
amd64 linux
gcc:focal:amd64

00:00:53

passed #1292506
amd64 linux
gcc:mutexatomics

00:00:56

passed #1292497
amd64 linux
gcc:out-of-tree

00:00:55

passed #1292496
amd64 linux
gcc:sid:amd64

00:01:07

passed #1292498
i386 linux
gcc:sid:i386

00:00:54

passed #1292508
amd64 linux
gcc:softhsm2.4

00:01:07

passed #1292509
amd64 linux
gcc:softhsm2.6

00:00:53

passed #1292494
amd64 linux
gcc:stretch:amd64

00:01:00

passed #1292504
amd64 linux
gcc:tsan

00:01:08

passed #1292499
amd64 linux
gcc:tumbleweed:amd64

00:00:47

passed #1292500
amd64 linux
gcc:xenial:amd64

00:01:09

passed #1292513
amd64 windows
msvc:windows:amd64

00:00:48

 
  Unit
passed #1292525
amd64 linux
unit:clang:asan

00:01:18

passed #1292529
amd64 linux
unit:clang:buster:amd64

00:00:59

passed #1292532
amd64 libvirt
unit:clang:freebsd11:amd64

00:01:25

passed #1292533
amd64 libvirt
unit:clang:freebsd12:amd64

00:01:15

passed #1292534
amd64 libvirt
unit:clang:openbsd:amd64

00:02:36

passed #1292527
amd64 linux
unit:clang:tsan

00:02:54

passed #1292514
amd64 linux
unit:gcc:alpine3.12:amd64

00:01:05

passed #1292524
amd64 linux
unit:gcc:asan

00:01:20

passed #1292518
amd64 linux
unit:gcc:buster:amd64

00:02:01

passed #1292515
amd64 linux
unit:gcc:centos7:amd64

00:01:01

passed #1292516
amd64 linux
unit:gcc:centos8:amd64

00:00:58

passed #1292523
amd64 linux
unit:gcc:focal:amd64

00:01:00

passed #1292528
amd64 linux
unit:gcc:mutexatomics

00:01:02

passed #1292519
amd64 linux
unit:gcc:sid:amd64

00:00:59

passed #1292562
linux i386
unit:gcc:sid:i386

00:00:53

passed #1292530
amd64 linux
unit:gcc:softhsm2.4

00:01:01

passed #1292531
amd64 linux
unit:gcc:softhsm2.6

00:01:02

passed #1292517
amd64 linux
unit:gcc:stretch:amd64

00:00:57

passed #1292526
amd64 linux
unit:gcc:tsan

00:03:49

passed #1292521
amd64 linux
unit:gcc:tumbleweed:amd64

00:00:59

passed #1292522
amd64 linux
unit:gcc:xenial:amd64

00:01:03

failed #1292520
i386 linux
unit:gcc:sid:i386

00:01:08

 
  System
passed #1292546
amd64 linux
system:clang:asan

00:13:34

passed #1292550
amd64 linux
system:clang:buster:amd64

00:11:58

passed #1292553
amd64 libvirt
system:clang:freebsd11:amd64

00:11:08

failed #1292563
libvirt amd64
system:clang:freebsd12:amd64

00:10:46

passed #1292548
amd64 linux
system:clang:tsan

00:15:04

passed #1292535
amd64 linux
system:gcc:alpine3.12:amd64

00:12:27

passed #1292545
amd64 linux
system:gcc:asan

00:13:59

passed #1292539
amd64 linux
system:gcc:buster:amd64

00:12:40

passed #1292536
amd64 linux
system:gcc:centos7:amd64

00:11:35

passed #1292537
amd64 linux
system:gcc:centos8:amd64

00:11:42

passed #1292544
amd64 linux
system:gcc:focal:amd64

00:11:53

passed #1292549
amd64 linux
system:gcc:mutexatomics

00:11:04

passed #1292540
amd64 linux
system:gcc:sid:amd64

00:11:48

passed #1292541
i386 linux
system:gcc:sid:i386

00:11:53

passed #1292551
amd64 linux
system:gcc:softhsm2.4

00:11:32

passed #1292552
amd64 linux
system:gcc:softhsm2.6

00:11:45

passed #1292538
amd64 linux
system:gcc:stretch:amd64

00:11:10

passed #1292547
amd64 linux
system:gcc:tsan

00:15:01

passed #1292542
amd64 linux
system:gcc:tumbleweed:amd64

00:11:26

passed #1292543
amd64 linux
system:gcc:xenial:amd64

00:11:12

failed #1292554
amd64 libvirt
system:clang:freebsd12:amd64

00:10:58

 
  Docs
passed #1292555
amd64 linux
docs

00:00:38

 
  Postcheck
passed #1292559
amd64 linux
cppcheck

00:00:49

passed #1292556
amd64 linux
flake8

00:00:21

passed #1292560
amd64 linux
gcov

00:00:32

77.0%
passed #1292557
amd64 linux
pylint

00:00:25

passed #1292558
amd64 linux
scan-build

00:04:26

 
Name Stage Failure
failed
system:clang:freebsd12:amd64 System
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
Runtime platform
arch=amd64 os=freebsd pid=62179 revision=ece86343 version=13.5.0
untracked: found 1448 files

Uploading artifacts as "archive" to coordinator... ok
id=1292563 responseStatus=201 Created token=i4ckVNuL
Cleaning up file based variables
Unsupported run stage 'cleanup_file_variables'
ERROR: Job failed: exit status 1