Use sock->nchildren instead of mgr->nworkers when initializing NM

On Windows, we were limiting the number of listening children to just 1,
but we were then iterating on mgr->nworkers.  That lead to scheduling
more async_*listen() than actually allocated and out-of-bound read-write
operation on the heap.
76 jobs for !4469 with ondrej/fix-the-windows-nchildren-problem in 18 minutes and 5 seconds (queued for 7 seconds)
detached
Status Job ID Name Coverage
  Autoconf
passed #1344579
amd64 linux
autoreconf

00:00:17

 
  Precheck
passed #1344581
amd64 linux
clang-format

00:00:16

passed #1344582
amd64 linux
coccinelle

00:03:36

passed #1344583
amd64 linux
danger

00:00:13

passed #1344580
amd64 linux
misc

00:00:20

passed #1344584
amd64 linux
tarball-create

00:01:33

 
  Build
passed #1344597
amd64 linux
clang:asan

00:02:01

passed #1344601
amd64 linux
clang:buster:amd64

00:01:02

passed #1344604
amd64 libvirt
clang:freebsd11:amd64

00:01:14

passed #1344605
amd64 libvirt
clang:freebsd12:amd64

00:01:14

passed #1344606
amd64 libvirt
clang:openbsd:amd64

00:02:23

passed #1344599
amd64 linux
clang:tsan

00:01:20

passed #1344585
amd64 linux
gcc:alpine3.12:amd64

00:01:01

passed #1344596
amd64 linux
gcc:asan

00:01:43

passed #1344589
amd64 linux
gcc:buster:amd64

00:00:57

passed #1344586
amd64 linux
gcc:centos7:amd64

00:00:56

passed #1344587
amd64 linux
gcc:centos8:amd64

00:01:01

passed #1344595
amd64 linux
gcc:focal:amd64

00:01:02

passed #1344600
amd64 linux
gcc:mutexatomics

00:00:48

passed #1344591
amd64 linux
gcc:out-of-tree

00:01:03

passed #1344590
amd64 linux
gcc:sid:amd64

00:01:40

passed #1344592
i386 linux
gcc:sid:i386

00:00:59

passed #1344602
amd64 linux
gcc:softhsm2.4

00:00:59

passed #1344603
amd64 linux
gcc:softhsm2.6

00:00:56

passed #1344588
amd64 linux
gcc:stretch:amd64

00:01:05

passed #1344598
amd64 linux
gcc:tsan

00:01:13

passed #1344593
amd64 linux
gcc:tumbleweed:amd64

00:01:00

passed #1344594
amd64 linux
gcc:xenial:amd64

00:00:50

passed #1344607
amd64 windows
msvc:windows:amd64

00:00:57

 
  Unit
passed #1344619
amd64 linux
unit:clang:asan

00:01:18

passed #1344623
amd64 linux
unit:clang:buster:amd64

00:01:13

passed #1344626
amd64 libvirt
unit:clang:freebsd11:amd64

00:01:33

passed #1344627
amd64 libvirt
unit:clang:freebsd12:amd64

00:01:28

passed #1344628
amd64 libvirt
unit:clang:openbsd:amd64

00:02:58

passed #1344621
amd64 linux
unit:clang:tsan

00:03:22

passed #1344608
amd64 linux
unit:gcc:alpine3.12:amd64

00:01:14

passed #1344618
amd64 linux
unit:gcc:asan

00:01:17

passed #1344612
amd64 linux
unit:gcc:buster:amd64

00:02:09

passed #1344609
amd64 linux
unit:gcc:centos7:amd64

00:01:09

passed #1344610
amd64 linux
unit:gcc:centos8:amd64

00:01:11

passed #1344617
amd64 linux
unit:gcc:focal:amd64

00:01:09

passed #1344622
amd64 linux
unit:gcc:mutexatomics

00:01:05

passed #1344613
amd64 linux
unit:gcc:sid:amd64

00:01:05

passed #1344614
i386 linux
unit:gcc:sid:i386

00:01:12

passed #1344624
amd64 linux
unit:gcc:softhsm2.4

00:01:10

passed #1344625
amd64 linux
unit:gcc:softhsm2.6

00:01:08

passed #1344611
amd64 linux
unit:gcc:stretch:amd64

00:01:05

passed #1344620
amd64 linux
unit:gcc:tsan

00:03:51

passed #1344615
amd64 linux
unit:gcc:tumbleweed:amd64

00:01:08

passed #1344616
amd64 linux
unit:gcc:xenial:amd64

00:01:13

 
  System
passed #1344640
amd64 linux
system:clang:asan

00:13:31

passed #1344644
amd64 linux
system:clang:buster:amd64

00:11:54

passed #1344647
amd64 libvirt
system:clang:freebsd11:amd64

00:11:41

failed #1344648
amd64 libvirt
system:clang:freebsd12:amd64

00:11:51

passed #1344642
amd64 linux
system:clang:tsan

00:15:28

passed #1344629
amd64 linux
system:gcc:alpine3.12:amd64

00:12:56

passed #1344639
amd64 linux
system:gcc:asan

00:13:51

passed #1344633
amd64 linux
system:gcc:buster:amd64

00:13:12

passed #1344630
amd64 linux
system:gcc:centos7:amd64

00:12:24

passed #1344631
amd64 linux
system:gcc:centos8:amd64

00:12:50

passed #1344638
amd64 linux
system:gcc:focal:amd64

00:12:14

passed #1344643
amd64 linux
system:gcc:mutexatomics

00:12:01

passed #1344634
amd64 linux
system:gcc:sid:amd64

00:12:17

passed #1344635
i386 linux
system:gcc:sid:i386

00:12:24

passed #1344645
amd64 linux
system:gcc:softhsm2.4

00:12:04

passed #1344646
amd64 linux
system:gcc:softhsm2.6

00:12:43

failed #1344632
amd64 linux
system:gcc:stretch:amd64

00:12:01

passed #1344641
amd64 linux
system:gcc:tsan

00:16:05

passed #1344636
amd64 linux
system:gcc:tumbleweed:amd64

00:12:15

passed #1344637
amd64 linux
system:gcc:xenial:amd64

00:12:07

 
  Docs
passed #1344649
amd64 linux
docs

00:00:42

 
  Postcheck
passed #1344653
amd64 linux
cppcheck

00:00:58

passed #1344650
amd64 linux
flake8

00:00:22

passed #1344654
amd64 linux
gcov

00:00:38

77.0%
passed #1344651
amd64 linux
pylint

00:00:28

passed #1344652
amd64 linux
scan-build

00:04:06

 
Name Stage Failure
failed
system:clang:freebsd12:amd64 System
No job log
failed
system:gcc:stretch:amd64 System
No job log