fixup! TLS: cancleread support and numerous stability fixes

73 jobs for !4566 with artem/dns-over-https in 61 minutes and 28 seconds (queued for 7 seconds)
detached
Status Job ID Name Coverage
  Autoconf
passed #1423861
amd64 linux
autoreconf

00:00:17

 
  Precheck
failed #1423863
amd64 linux
clang-format

00:00:18

failed #1423864
amd64 linux
coccinelle

00:03:03

failed #1423865
amd64 linux
danger

00:00:18

failed #1423862
amd64 linux
misc

00:00:15

failed #1423866
amd64 linux
tarball-create

00:00:17

 
  Build
failed #1423878
amd64 linux
clang:asan

00:00:22

failed #1423882
amd64 linux
clang:buster:amd64

00:00:21

failed #1423885
amd64 libvirt
clang:freebsd11:amd64

00:00:43

failed #1423886
amd64 libvirt
clang:freebsd12:amd64

00:00:41

passed #1423887
amd64 libvirt
clang:openbsd:amd64

00:02:10

failed #1423880
amd64 linux
clang:tsan

00:00:20

failed #1423867
amd64 linux
gcc:alpine3.12:amd64

00:00:17

failed #1423877
amd64 linux
gcc:asan

00:00:18

failed #1423871
amd64 linux
gcc:buster:amd64

00:00:16

failed #1423868
amd64 linux
gcc:centos7:amd64

00:00:16

failed #1423869
amd64 linux
gcc:centos8:amd64

00:00:16

failed #1423876
amd64 linux
gcc:focal:amd64

00:00:18

failed #1423881
amd64 linux
gcc:mutexatomics

00:00:16

failed #1423873
amd64 linux
gcc:out-of-tree

00:00:17

failed #1423872
amd64 linux
gcc:sid:amd64

00:00:18

failed #1423883
amd64 linux
gcc:softhsm2.4

00:00:17

passed #1423884
amd64 linux
gcc:softhsm2.6

00:00:52

failed #1423870
amd64 linux
gcc:stretch:amd64

00:00:19

failed #1423879
amd64 linux
gcc:tsan

00:00:18

passed #1423874
amd64 linux
gcc:tumbleweed:amd64

00:00:45

failed #1423875
amd64 linux
gcc:xenial:amd64

00:00:16

failed #1423888
amd64 windows
msvc:windows:amd64

00:00:32

 
  Unit
skipped #1423899
amd64 linux
unit:clang:asan
skipped #1423903
amd64 linux
unit:clang:buster:amd64
skipped #1423906
amd64 libvirt
unit:clang:freebsd11:amd64
skipped #1423907
amd64 libvirt
unit:clang:freebsd12:amd64
failed #1423908
amd64 libvirt
unit:clang:openbsd:amd64

00:01:35

skipped #1423901
amd64 linux
unit:clang:tsan
skipped #1423889
amd64 linux
unit:gcc:alpine3.12:amd64
skipped #1423898
amd64 linux
unit:gcc:asan
skipped #1423893
amd64 linux
unit:gcc:buster:amd64
skipped #1423890
amd64 linux
unit:gcc:centos7:amd64
skipped #1423891
amd64 linux
unit:gcc:centos8:amd64
skipped #1423897
amd64 linux
unit:gcc:focal:amd64
skipped #1423902
amd64 linux
unit:gcc:mutexatomics
skipped #1423894
amd64 linux
unit:gcc:sid:amd64
skipped #1423904
amd64 linux
unit:gcc:softhsm2.4
failed #1423905
amd64 linux
unit:gcc:softhsm2.6

00:00:37

skipped #1423892
amd64 linux
unit:gcc:stretch:amd64
skipped #1423900
amd64 linux
unit:gcc:tsan
failed #1423895
amd64 linux
unit:gcc:tumbleweed:amd64

00:00:35

skipped #1423896
amd64 linux
unit:gcc:xenial:amd64
 
  System
skipped #1423919
amd64 linux
system:clang:asan
skipped #1423923
amd64 linux
system:clang:buster:amd64
skipped #1423926
amd64 libvirt
system:clang:freebsd11:amd64
skipped #1423927
amd64 libvirt
system:clang:freebsd12:amd64
skipped #1423921
amd64 linux allowed to fail
system:clang:tsan
skipped #1423909
amd64 linux
system:gcc:alpine3.12:amd64
skipped #1423918
amd64 linux
system:gcc:asan
skipped #1423913
amd64 linux
system:gcc:buster:amd64
skipped #1423910
amd64 linux
system:gcc:centos7:amd64
skipped #1423911
amd64 linux
system:gcc:centos8:amd64
skipped #1423917
amd64 linux
system:gcc:focal:amd64
skipped #1423922
amd64 linux
system:gcc:mutexatomics
skipped #1423914
amd64 linux
system:gcc:sid:amd64
skipped #1423924
amd64 linux
system:gcc:softhsm2.4
failed #1423925
amd64 linux
system:gcc:softhsm2.6

01:00:01

skipped #1423912
amd64 linux
system:gcc:stretch:amd64
skipped #1423920
amd64 linux allowed to fail
system:gcc:tsan
failed #1423915
amd64 linux
system:gcc:tumbleweed:amd64

01:00:01

skipped #1423916
amd64 linux
system:gcc:xenial:amd64
 
  Docs
passed #1423928
amd64 linux
docs

00:00:17

 
  Postcheck
failed #1423932
amd64 linux
cppcheck

00:00:17

passed #1423929
amd64 linux
flake8

00:00:15

skipped #1423933
amd64 linux
gcov
passed #1423930
amd64 linux
pylint

00:00:18

failed #1423931
amd64 linux
scan-build

00:00:24

 
Name Stage Failure
failed
system:gcc:softhsm2.6 System The script exceeded the maximum execution time set for the job
I:dnssec:checking sig-validity-interval second field hours vs days (288)
I:dnssec:checking validation succeeds during transition to signed (289)
I:dnssec:exit status: 0
I:dnssec:stopping servers
R:dnssec:PASS
I:file dnssec/ns1/trusted.keys not removed
E:dnssec:2021-01-22T10:15:11+0000
PASS: dnssec
ERROR: Job failed: execution took longer than 1h0m0s seconds
failed
system:gcc:tumbleweed:amd64 System The script exceeded the maximum execution time set for the job
I:dnssec:checking sig-validity-interval second field hours vs days (288)
I:dnssec:checking validation succeeds during transition to signed (289)
I:dnssec:exit status: 0
I:dnssec:stopping servers
R:dnssec:PASS
I:file dnssec/ns1/trusted.keys not removed
E:dnssec:2021-01-22T10:15:08+0000
PASS: dnssec
ERROR: Job failed: execution took longer than 1h0m0s seconds
failed
unit:clang:openbsd:amd64 Unit
Error target(s) unaccounted for: unit-recursive unit 
`unit' not remade because of errors.
Uploading artifacts for failed job
Uploading artifacts...
Runtime platform
arch=amd64 os=openbsd pid=13078 revision=9ad2ddee version=12.4.0~beta.1928.g9ad2ddee
untracked: found 1489 files

Uploading artifacts to coordinator... ok
id=1423908 responseStatus=201 Created token=exYrK-gJ
Cleaning up file based variables
ERROR: Job failed: exit status 1
failed
coccinelle Precheck
 		data = (isc_region_t){ socket->h2.buf, socket->h2.bufsize };
} else {
INSIST(0);
+ ISC_UNREACHABLE();
}

addr = isc_nmhandle_peeraddr(session->handle);
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
unit:gcc:softhsm2.6 Unit
make[1]: Leaving directory '/builds/isc-projects/bind9/fuzz'
make: *** [Makefile:629: unit-recursive] Error 1
make: Target 'unit' not remade because of errors.
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 1563 files

Uploading artifacts as "archive" to coordinator... ok
id=1423905 responseStatus=201 Created token=jysJ9ABK
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
unit:gcc:tumbleweed:amd64 Unit
make[1]: Leaving directory '/builds/isc-projects/bind9/fuzz'
make: *** [Makefile:629: unit-recursive] Error 1
make: Target 'unit' not remade because of errors.
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 1505 files

Uploading artifacts as "archive" to coordinator... ok
id=1423895 responseStatus=201 Created token=4odKtxf_
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
clang:freebsd11:amd64 Build
make[1]: stopped in /builds/isc-projects/bind9
*** [all] Error code 1

make: stopped in /builds/isc-projects/bind9
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit status 1
failed
clang:freebsd12:amd64 Build
/bin/sh ../../libtool  --tag=CC    --mode=link cc  -Wall -Wextra -Wwrite-strings -Wpointer-arith -Wno-missing-field-initializers -Wformat -Wshadow -Werror=implicit-function-declaration -Werror=missing-prototypes -Werror=format-security -Werror=parentheses -Werror=implicit -Werror=strict-prototypes -fno-strict-aliasing -fno-delete-null-pointer-checks -fdiagnostics-show-option -Werror -fno-omit-frame-pointer -fno-optimize-sibling-calls -O1 -g -Wall -Wextra -pthread -I/usr/local/include -avoid-version -module -shared -export-dynamic  -o  filter-aaaa.la -rpath /builds/isc-projects/bind9/.local/lib/bind filter-aaaa.lo  -lexecinfo   -L/usr/local/lib -lnghttp2
libtool: link: cc -shared -fPIC -DPIC .libs/filter-aaaa.o -lexecinfo -L/usr/local/lib -lnghttp2 -O1 -g -pthread -pthread -Wl,-soname -Wl,filter-aaaa.so -o .libs/filter-aaaa.so
libtool: link: ( cd ".libs" && rm -f "filter-aaaa.la" && ln -s "../filter-aaaa.la" "filter-aaaa.la" )
Making all in fuzz
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit status 1
failed
scan-build Postcheck
scan-build: Analysis run complete.
scan-build: Removing directory '/builds/isc-projects/bind9/scan-build.reports/2021-01-22-100246-2638-1' because it contains no reports.
scan-build: No bugs found.
Uploading artifacts for failed job
Uploading artifacts...
scan-build.reports/: found 1 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=1423931 responseStatus=201 Created token=2fpiX57H
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
clang:asan Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
cppcheck Postcheck
Failed to parse cppcheck xml file: unknown url type: 'cppcheck.results'
Uploading artifacts for failed job
Uploading artifacts...
compile_commands.json: found 1 matching files and directories

WARNING: cppcheck.results: no matching files
WARNING: cppcheck_html/: no matching files
Uploading artifacts as "archive" to coordinator... ok
id=1423932 responseStatus=201 Created token=-K_hi3TP
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
clang:tsan Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:tsan Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:asan Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:focal:amd64 Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
clang:buster:amd64 Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:stretch:amd64 Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:sid:amd64 Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:softhsm2.4 Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:xenial:amd64 Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:out-of-tree Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:mutexatomics Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:alpine3.12:amd64 Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:centos7:amd64 Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target `all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:buster:amd64 Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
gcc:centos8:amd64 Build
$ if [[ -n "${WITHOUT_READLINE}" ]]; then \ # collapsed multi-line command
grep: config.h: No such file or directory
$ make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
make: *** No rule to make target 'all'.
Running after_script
Running after script...
$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
tarball-create Precheck
checking for uv_handle_get_data... yes
checking for uv_handle_set_data... yes
checking for uv_import... no
checking for uv_udp_connect... no
checking for uv_translate_sys_error... yes
checking for libnghttp2... checking for LIBNGHTTP2... no
configure: error: libnghttp2 not found
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
msvc:windows:amd64 Build
OS/Arch:      windows/amd64
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=24060 revision=8fa89735 version=13.6.0
untracked: found 271 files

WARNING: Failed to load system CertPool: crypto/x509: system root pool is not available on Windows
Uploading artifacts as "archive" to coordinator... ok
id=1423888 responseStatus=201 Created token=ihgziXkf
Cleaning up file based variables
Unsupported run stage "cleanup_file_variables"
ERROR: Job failed: exit status 1
failed
danger Precheck
 * [new branch]      main       -> origin/main



Failing the build, there are 19 fails.
Feedback: https://gitlab.isc.org/isc-projects/bind9/merge_requests/4566#note_186759

Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
clang-format Precheck
$ if test "$(git status --porcelain | grep -Ev '\?\?' | wc -l)" -gt "0"; then git status --short; exit 1; fi
M lib/isc/netmgr/http.c
M lib/isc/netmgr/netmgr-int.h
M lib/isc/netmgr/netmgr.c
M lib/isc/netmgr/tls.c
M lib/isc/tests/doh_test.c
M lib/isc/tests/tls_test_cert_key.h
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
misc Precheck
Executing "step_script" stage of the job script
$ sh util/checklibs.sh > checklibs.out
Uploading artifacts for failed job
Uploading artifacts...
WARNING: util/newcopyrights: no matching files
checklibs.out: found 1 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=1423862 responseStatus=201 Created token=uznWs4qy
Cleaning up file based variables
ERROR: Job failed: exit code 1