Remove redundant 'version == NULL' check

    *** CID 318094:  Null pointer dereferences  (REVERSE_INULL)
    /lib/dns/rbtdb.c: 1389 in newversion()
    1383     	version->xfrsize = rbtdb->current_version->xfrsize;
    1384     	RWUNLOCK(&rbtdb->current_version->rwlock, isc_rwlocktype_read);
    1385     	rbtdb->next_serial++;
    1386     	rbtdb->future_version = version;
    1387     	RBTDB_UNLOCK(&rbtdb->lock, isc_rwlocktype_write);
    1388
       CID 318094:  Null pointer dereferences  (REVERSE_INULL)
       Null-checking "version" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
    1389     	if (version == NULL) {
    1390     		return (result);
    1391     	}
    1392
    1393     	*versionp = version;
    1394
73 jobs for !4641 with 2468-cid-318094-null-pointer-dereferences-reverse_inull in 1 minute and 51 seconds (queued for 6 seconds)
detached
Status Job ID Name Coverage
  Autoconf
passed #1460103
amd64 linux
autoreconf

00:00:17

 
  Precheck
passed #1460105
amd64 linux
clang-format

00:00:18

canceled #1460106
amd64 linux
coccinelle

00:01:48

passed #1460107
amd64 linux
danger

00:00:15

passed #1460104
amd64 linux
misc

00:00:19

canceled #1460108
amd64 linux
tarball-create

00:01:31

 
  Build
canceled #1460120
amd64 linux
clang:asan

00:01:24

passed #1460124
amd64 linux
clang:buster:amd64

00:01:07

passed #1460127
amd64 libvirt
clang:freebsd11:amd64

00:01:25

passed #1460128
amd64 libvirt
clang:freebsd12:amd64

00:01:15

canceled #1460129
amd64 libvirt
clang:openbsd:amd64

00:01:23

passed #1460122
amd64 linux
clang:tsan

00:01:13

passed #1460109
amd64 linux
gcc:alpine3.12:amd64

00:01:01

canceled #1460119
amd64 linux
gcc:asan

00:01:25

passed #1460113
amd64 linux
gcc:buster:amd64

00:00:57

passed #1460110
amd64 linux
gcc:centos7:amd64

00:00:59

passed #1460111
amd64 linux
gcc:centos8:amd64

00:00:51

passed #1460118
amd64 linux
gcc:focal:amd64

00:00:53

passed #1460123
amd64 linux
gcc:mutexatomics

00:01:01

passed #1460115
amd64 linux
gcc:out-of-tree

00:01:11

passed #1460114
amd64 linux
gcc:sid:amd64

00:01:14

passed #1460125
amd64 linux
gcc:softhsm2.4

00:00:51

passed #1460126
amd64 linux
gcc:softhsm2.6

00:00:52

passed #1460112
amd64 linux
gcc:stretch:amd64

00:01:13

passed #1460121
amd64 linux
gcc:tsan

00:00:59

passed #1460116
amd64 linux
gcc:tumbleweed:amd64

00:01:01

passed #1460117
amd64 linux
gcc:xenial:amd64

00:00:56

passed #1460130
amd64 windows
msvc:windows:amd64

00:00:53

 
  Unit
canceled #1460141
amd64 linux
unit:clang:asan

canceled #1460145
amd64 linux
unit:clang:buster:amd64

00:00:20

canceled #1460148
amd64 libvirt
unit:clang:freebsd11:amd64

canceled #1460149
amd64 libvirt
unit:clang:freebsd12:amd64

00:00:09

canceled #1460150
amd64 libvirt
unit:clang:openbsd:amd64

canceled #1460143
amd64 linux
unit:clang:tsan

canceled #1460131
amd64 linux
unit:gcc:alpine3.12:amd64

00:00:25

canceled #1460140
amd64 linux
unit:gcc:asan

canceled #1460135
amd64 linux
unit:gcc:buster:amd64

00:00:30

canceled #1460132
amd64 linux
unit:gcc:centos7:amd64

00:00:28

canceled #1460133
amd64 linux
unit:gcc:centos8:amd64

00:00:35

canceled #1460139
amd64 linux
unit:gcc:focal:amd64

00:00:31

canceled #1460144
amd64 linux
unit:gcc:mutexatomics

00:00:27

canceled #1460136
amd64 linux
unit:gcc:sid:amd64

00:00:12

canceled #1460146
amd64 linux
unit:gcc:softhsm2.4

00:00:35

canceled #1460147
amd64 linux
unit:gcc:softhsm2.6

00:00:34

canceled #1460134
amd64 linux
unit:gcc:stretch:amd64

00:00:14

canceled #1460142
amd64 linux
unit:gcc:tsan

00:00:23

canceled #1460137
amd64 linux
unit:gcc:tumbleweed:amd64

00:00:23

canceled #1460138
amd64 linux
unit:gcc:xenial:amd64

00:00:27

 
  System
canceled #1460161
amd64 linux
system:clang:asan

canceled #1460165
amd64 linux
system:clang:buster:amd64

00:00:17

canceled #1460168
amd64 libvirt
system:clang:freebsd11:amd64

canceled #1460169
amd64 libvirt
system:clang:freebsd12:amd64

00:00:03

canceled #1460163
amd64 linux allowed to fail
system:clang:tsan

canceled #1460151
amd64 linux
system:gcc:alpine3.12:amd64

00:00:25

canceled #1460160
amd64 linux
system:gcc:asan

canceled #1460155
amd64 linux
system:gcc:buster:amd64

canceled #1460152
amd64 linux
system:gcc:centos7:amd64

00:00:29

canceled #1460153
amd64 linux
system:gcc:centos8:amd64

00:00:34

canceled #1460159
amd64 linux
system:gcc:focal:amd64

00:00:30

canceled #1460164
amd64 linux
system:gcc:mutexatomics

00:00:26

canceled #1460156
amd64 linux
system:gcc:sid:amd64

00:00:11

canceled #1460166
amd64 linux
system:gcc:softhsm2.4

00:00:34

canceled #1460167
amd64 linux
system:gcc:softhsm2.6

00:00:34

canceled #1460154
amd64 linux
system:gcc:stretch:amd64

00:00:13

canceled #1460162
amd64 linux allowed to fail
system:gcc:tsan

00:00:22

canceled #1460157
amd64 linux
system:gcc:tumbleweed:amd64

00:00:23

canceled #1460158
amd64 linux
system:gcc:xenial:amd64

00:00:27

 
  Docs
passed #1460170
amd64 linux
docs

00:00:49

 
  Postcheck
passed #1460174
amd64 linux
cppcheck

00:00:50

passed #1460171
amd64 linux
flake8

00:00:21

canceled #1460175
amd64 linux
gcov

passed #1460172
amd64 linux
pylint

00:00:27

canceled #1460173
amd64 linux
scan-build

00:01:22