Fix typo in macro definition

The macro atomic_exchange_explicit had a formal parameter declared as
"desired", but the definition  __c11_atomic_exchange_explicit(obj,
expected, order) ended up using a non declared parameter, "expected".

This would happen if the target system defines  __CLANG_ATOMICS during
processing of the header file.

Fixed the macro definition by substituting "expected" for "desired" to
match the name declared in the macro's parameters list.
70 jobs for !4846 with 2601-typo-in-definition-of-atomic_exchange_explicit-for-clang-on-unix in 18 minutes and 27 seconds (queued for 7 seconds)
latest detached
Status Job ID Name Coverage
  Autoconf
passed #1602883
amd64 linux
autoreconf

00:00:17

 
  Precheck
passed #1602885
amd64 linux
clang-format

00:00:18

passed #1602886
amd64 linux
coccinelle

00:04:27

failed #1602887
amd64 linux
danger

00:00:15

passed #1602884
amd64 linux
misc

00:00:18

passed #1602888
amd64 linux
tarball-create

00:01:40

 
  Build
passed #1602899
amd64 linux
clang:asan

00:02:03

passed #1602903
amd64 linux
clang:buster:amd64

00:01:05

passed #1602906
amd64 libvirt
clang:freebsd11:amd64

00:01:17

passed #1602907
amd64 libvirt
clang:freebsd12:amd64

00:01:18

passed #1602908
amd64 libvirt
clang:openbsd:amd64

00:02:41

passed #1602901
amd64 linux
clang:tsan

00:01:21

passed #1602889
amd64 linux
gcc:alpine3.13:amd64

00:01:03

passed #1602898
amd64 linux
gcc:asan

00:01:40

passed #1602893
amd64 linux
gcc:buster:amd64

00:00:57

passed #1602890
amd64 linux
gcc:centos7:amd64

00:00:54

passed #1602891
amd64 linux
gcc:centos8:amd64

00:00:57

passed #1602897
amd64 linux
gcc:focal:amd64

00:00:50

passed #1602902
amd64 linux
gcc:mutexatomics

00:00:52

passed #1602895
amd64 linux
gcc:out-of-tree

00:01:08

passed #1602894
amd64 linux
gcc:sid:amd64

00:01:13

passed #1602904
amd64 linux
gcc:softhsm2.4

00:00:48

passed #1602905
amd64 linux
gcc:softhsm2.6

00:00:59

passed #1602892
amd64 linux
gcc:stretch:amd64

00:01:10

passed #1602900
amd64 linux
gcc:tsan

00:01:13

passed #1602896
amd64 linux
gcc:tumbleweed:amd64

00:00:58

passed #1602909
amd64 windows
msvc:windows:amd64

00:00:48

 
  Unit
passed #1602919
amd64 linux
unit:clang:asan

00:02:00

passed #1602923
amd64 linux
unit:clang:buster:amd64

00:01:31

passed #1602926
amd64 libvirt
unit:clang:freebsd11:amd64

00:01:48

passed #1602927
amd64 libvirt
unit:clang:freebsd12:amd64

00:01:51

passed #1602928
amd64 libvirt
unit:clang:openbsd:amd64

00:03:26

passed #1602921
amd64 linux
unit:clang:tsan

00:03:06

passed #1602910
amd64 linux
unit:gcc:alpine3.13:amd64

00:01:36

passed #1602918
amd64 linux
unit:gcc:asan

00:01:49

passed #1602914
amd64 linux
unit:gcc:buster:amd64

00:02:10

passed #1602911
amd64 linux
unit:gcc:centos7:amd64

00:01:25

passed #1602912
amd64 linux
unit:gcc:centos8:amd64

00:01:13

passed #1602917
amd64 linux
unit:gcc:focal:amd64

00:01:14

passed #1602922
amd64 linux
unit:gcc:mutexatomics

00:01:14

passed #1602915
amd64 linux
unit:gcc:sid:amd64

00:01:34

passed #1602924
amd64 linux
unit:gcc:softhsm2.4

00:01:19

failed #1602925
amd64 linux
unit:gcc:softhsm2.6

00:01:17

passed #1602913
amd64 linux
unit:gcc:stretch:amd64

00:00:16

passed #1602920
amd64 linux
unit:gcc:tsan

00:04:26

passed #1602916
amd64 linux
unit:gcc:tumbleweed:amd64

00:01:14

 
  System
passed #1602938
amd64 linux
system:clang:asan

00:13:46

passed #1602942
amd64 linux
system:clang:buster:amd64

00:11:32

passed #1602945
amd64 libvirt
system:clang:freebsd11:amd64

00:12:27

passed #1602946
amd64 libvirt
system:clang:freebsd12:amd64

00:12:12

passed #1602940
amd64 linux
system:clang:tsan

00:16:27

passed #1602929
amd64 linux
system:gcc:alpine3.13:amd64

00:13:22

passed #1602937
amd64 linux
system:gcc:asan

00:14:34

passed #1602933
amd64 linux
system:gcc:buster:amd64

00:13:51

passed #1602930
amd64 linux
system:gcc:centos7:amd64

00:12:07

passed #1602931
amd64 linux
system:gcc:centos8:amd64

00:12:33

passed #1602936
amd64 linux
system:gcc:focal:amd64

00:12:37

passed #1602941
amd64 linux
system:gcc:mutexatomics

00:12:43

passed #1602934
amd64 linux
system:gcc:sid:amd64

00:12:31

passed #1602943
amd64 linux
system:gcc:softhsm2.4

00:11:28

failed #1602944
amd64 linux
system:gcc:softhsm2.6

00:12:50

passed #1602932
amd64 linux
system:gcc:stretch:amd64

00:11:52

failed #1602939
amd64 linux
system:gcc:tsan

00:16:44

passed #1602935
amd64 linux
system:gcc:tumbleweed:amd64

00:12:31

 
  Docs
passed #1602947
amd64 linux
docs

00:00:59

 
  Postcheck
passed #1602951
amd64 linux
cppcheck

00:00:48

passed #1602948
amd64 linux
flake8

00:00:22

passed #1602952
amd64 linux
gcov

00:00:32

77.0%
passed #1602949
amd64 linux
pylint

00:00:27

passed #1602950
amd64 linux
scan-build

00:04:38

 
Name Stage Failure
failed
system:gcc:tsan System
FAIL shutdown (exit status: 1)

$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 1491 files

Uploading artifacts as "archive" to coordinator... ok
id=1602939 responseStatus=201 Created token=s9oGvsco
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:softhsm2.6 System
FAIL pkcs11 (exit status: 1)

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 1653 files

Uploading artifacts as "archive" to coordinator... ok
id=1602944 responseStatus=201 Created token=T27wdGax
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
unit:gcc:softhsm2.6 Unit
make[1]: Leaving directory '/builds/isc-projects/bind9/fuzz'
make: *** [Makefile:608: unit-recursive] Error 1
make: Target 'unit' not remade because of errors.
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 1670 files

Uploading artifacts as "archive" to coordinator... ok
id=1602925 responseStatus=201 Created token=8Z8GDyyH
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
danger Precheck
 * branch            main       -> FETCH_HEAD



Failing the build, there are 2 fails.
Feedback: https://gitlab.isc.org/isc-projects/bind9/merge_requests/4846#note_203782

Cleaning up file based variables
ERROR: Job failed: exit code 1