Cleanup the isc_<*>mgr_createinc() constructors

Previously, the taskmgr, timermgr and socketmgr had a constructor
variant, that would create the mgr on top of existing appctx.  This was
no longer true and isc_<*>mgr was just calling isc_<*>mgr_create()
directly without any extra code.

This commit just cleans up the extra function.
72 jobs for !4910 with ondrej/cleanup-double-createinctx-constructors in 18 minutes and 51 seconds (queued for 11 seconds)
latest detached
Status Job ID Name Coverage
  Autoconf
passed #1647166
amd64 linux
autoreconf

00:00:18

 
  Precheck
passed #1647168
amd64 linux
clang-format

00:00:18

passed #1647169
amd64 linux
coccinelle

00:03:51

passed #1648136
amd64 linux
danger

00:00:14

passed #1647167
amd64 linux
misc

00:00:19

passed #1647171
amd64 linux
tarball-create

00:01:30

failed #1647236
amd64 linux
danger

00:00:18

failed #1647170
amd64 linux
danger

00:00:17

 
  Build
passed #1647182
amd64 linux
clang:asan

00:01:51

passed #1647186
amd64 linux
clang:buster:amd64

00:01:04

passed #1647189
amd64 libvirt
clang:freebsd11:amd64

00:01:12

passed #1647190
amd64 libvirt
clang:freebsd12:amd64

00:01:12

passed #1647191
amd64 libvirt
clang:openbsd:amd64

00:02:27

passed #1647184
amd64 linux
clang:tsan

00:01:14

passed #1647172
amd64 linux
gcc:alpine3.13:amd64

00:00:57

passed #1647181
amd64 linux
gcc:asan

00:01:38

passed #1647176
amd64 linux
gcc:buster:amd64

00:00:46

passed #1647173
amd64 linux
gcc:centos7:amd64

00:00:52

passed #1647174
amd64 linux
gcc:centos8:amd64

00:00:51

passed #1647180
amd64 linux
gcc:focal:amd64

00:00:47

passed #1647185
amd64 linux
gcc:mutexatomics

00:01:01

passed #1647178
amd64 linux
gcc:out-of-tree

00:00:57

passed #1647177
amd64 linux
gcc:sid:amd64

00:01:10

passed #1647187
amd64 linux
gcc:softhsm2.4

00:00:58

passed #1647188
amd64 linux
gcc:softhsm2.6

00:00:52

passed #1647175
amd64 linux
gcc:stretch:amd64

00:00:59

passed #1647183
amd64 linux
gcc:tsan

00:01:02

passed #1647179
amd64 linux
gcc:tumbleweed:amd64

00:01:00

passed #1647192
amd64 windows
msvc:windows:amd64

00:00:45

 
  Unit
passed #1647202
amd64 linux
unit:clang:asan

00:02:41

passed #1647206
amd64 linux
unit:clang:buster:amd64

00:01:38

passed #1647209
amd64 libvirt
unit:clang:freebsd11:amd64

00:02:25

passed #1647210
amd64 libvirt
unit:clang:freebsd12:amd64

00:01:43

passed #1647211
amd64 libvirt
unit:clang:openbsd:amd64

00:03:33

passed #1647204
amd64 linux
unit:clang:tsan

00:04:08

passed #1647193
amd64 linux
unit:gcc:alpine3.13:amd64

00:01:29

passed #1647201
amd64 linux
unit:gcc:asan

00:02:37

passed #1647197
amd64 linux
unit:gcc:buster:amd64

00:02:30

passed #1647194
amd64 linux
unit:gcc:centos7:amd64

00:01:30

passed #1647195
amd64 linux
unit:gcc:centos8:amd64

00:01:31

passed #1647200
amd64 linux
unit:gcc:focal:amd64

00:01:30

passed #1647205
amd64 linux
unit:gcc:mutexatomics

00:01:26

passed #1647198
amd64 linux
unit:gcc:sid:amd64

00:01:43

passed #1647207
amd64 linux
unit:gcc:softhsm2.4

00:01:25

passed #1647208
amd64 linux
unit:gcc:softhsm2.6

00:01:31

passed #1647196
amd64 linux
unit:gcc:stretch:amd64

00:00:16

passed #1647203
amd64 linux
unit:gcc:tsan

00:04:36

passed #1647199
amd64 linux
unit:gcc:tumbleweed:amd64

00:01:27

 
  System
passed #1647221
amd64 linux
system:clang:asan

00:13:51

passed #1647225
amd64 linux
system:clang:buster:amd64

00:12:25

failed #1647228
amd64 libvirt
system:clang:freebsd11:amd64

00:12:30

failed #1647229
amd64 libvirt
system:clang:freebsd12:amd64

00:12:04

failed #1647223
amd64 linux
system:clang:tsan

00:16:44

passed #1647212
amd64 linux
system:gcc:alpine3.13:amd64

00:12:53

passed #1647220
amd64 linux
system:gcc:asan

00:14:13

passed #1647216
amd64 linux
system:gcc:buster:amd64

00:13:09

passed #1647213
amd64 linux
system:gcc:centos7:amd64

00:11:59

passed #1647214
amd64 linux
system:gcc:centos8:amd64

00:12:27

passed #1647219
amd64 linux
system:gcc:focal:amd64

00:12:55

passed #1647224
amd64 linux
system:gcc:mutexatomics

00:13:08

passed #1647217
amd64 linux
system:gcc:sid:amd64

00:11:57

passed #1647226
amd64 linux
system:gcc:softhsm2.4

00:12:45

passed #1647227
amd64 linux
system:gcc:softhsm2.6

00:12:39

passed #1647215
amd64 linux
system:gcc:stretch:amd64

00:11:07

failed #1647222
amd64 linux
system:gcc:tsan

00:16:32

passed #1647218
amd64 linux
system:gcc:tumbleweed:amd64

00:12:21

 
  Docs
passed #1647230
amd64 linux
docs

00:01:00

 
  Postcheck
passed #1647234
amd64 linux
cppcheck

00:00:44

passed #1647231
amd64 linux
flake8

00:00:20

passed #1647235
amd64 linux
gcov

00:00:36

77.0%
passed #1647232
amd64 linux
pylint

00:00:25

passed #1647233
amd64 linux
scan-build

00:04:31

 
Name Stage Failure
failed
system:clang:tsan System
FAIL inline (exit status: 1)

$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 2019 files

Uploading artifacts as "archive" to coordinator... ok
id=1647223 responseStatus=201 Created token=ZfLw7Y2S
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:gcc:tsan System
FAIL shutdown (exit status: 1)

$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 1472 files

Uploading artifacts as "archive" to coordinator... ok
id=1647222 responseStatus=201 Created token=qC4s7zNM
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
system:clang:freebsd11:amd64 System

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
Runtime platform
arch=amd64 os=freebsd pid=72457 revision=2ebc4dc4 version=13.9.0
untracked: found 1522 files

Uploading artifacts as "archive" to coordinator... ok
id=1647228 responseStatus=201 Created token=nBBwoESv
Cleaning up file based variables
ERROR: Job failed: exit status 1
failed
system:clang:freebsd12:amd64 System

$ test -n "${OUT_OF_TREE_WORKSPACE}" && mv "${OUT_OF_TREE_WORKSPACE}" "${CI_PROJECT_DIR}"
Uploading artifacts for failed job
Uploading artifacts...
Runtime platform
arch=amd64 os=freebsd pid=77231 revision=2ebc4dc4 version=13.9.0
untracked: found 1486 files

Uploading artifacts as "archive" to coordinator... ok
id=1647229 responseStatus=201 Created token=dBQr1sbV
Cleaning up file based variables
ERROR: Job failed: exit status 1