Cleanup the isc_<*>mgr_createinc() constructors

Previously, the taskmgr, timermgr and socketmgr had a constructor
variant, that would create the mgr on top of existing appctx.  This was
no longer true and isc_<*>mgr was just calling isc_<*>mgr_create()
directly without any extra code.

This commit just cleans up the extra function.

(cherry picked from commit 3388ef36)
77 jobs for !4912 with ondrej/cleanup-double-createinctx-constructors-v9_16 in 18 minutes and 45 seconds (queued for 18 seconds)
latest detached
Status Job ID Name Coverage
  Precheck
passed #1650281
amd64 linux
autoreconf

00:00:15

passed #1650283
amd64 linux
clang-format

00:00:18

passed #1650284
amd64 linux
coccinelle

00:03:33

passed #1650285
amd64 linux
danger

00:00:16

passed #1650282
amd64 linux
misc

00:00:17

 
  Build
passed #1650298
amd64 linux
clang:asan

00:03:59

passed #1650302
amd64 linux
clang:buster:amd64

00:01:56

passed #1650305
amd64 libvirt
clang:freebsd11:amd64

00:01:55

passed #1650306
amd64 libvirt
clang:freebsd12:amd64

00:01:48

passed #1650307
amd64 libvirt
clang:openbsd:amd64

00:04:10

passed #1650300
amd64 linux
clang:tsan

00:02:28

passed #1650286
amd64 linux
gcc:alpine3.13:amd64

00:01:55

passed #1650297
amd64 linux
gcc:asan

00:03:21

passed #1650290
amd64 linux
gcc:buster:amd64

00:01:31

passed #1650287
amd64 linux
gcc:centos7:amd64

00:01:43

passed #1650288
amd64 linux
gcc:centos8:amd64

00:01:42

passed #1650296
amd64 linux
gcc:focal:amd64

00:01:39

passed #1650301
amd64 linux
gcc:mutexatomics

00:01:42

passed #1650292
amd64 linux
gcc:out-of-tree

00:01:32

passed #1650291
amd64 linux
gcc:sid:amd64

00:02:06

passed #1650293
i386 linux
gcc:sid:i386

00:01:48

passed #1650303
amd64 linux
gcc:softhsm2.4

00:01:37

passed #1650304
amd64 linux
gcc:softhsm2.6

00:01:41

passed #1650289
amd64 linux
gcc:stretch:amd64

00:01:58

passed #1650299
amd64 linux
gcc:tsan

00:02:05

passed #1650294
amd64 linux
gcc:tumbleweed:amd64

00:01:38

passed #1650295
amd64 linux
gcc:xenial:amd64

00:01:58

passed #1650309
amd64 windows
msvc:windows:amd64

00:00:55

passed #1650308
amd64 linux
nolibtool:sid:amd64

00:02:10

 
  Unit
passed #1650321
amd64 linux
unit:clang:asan

00:01:13

passed #1650325
amd64 linux
unit:clang:buster:amd64

00:00:38

passed #1650328
amd64 libvirt
unit:clang:freebsd11:amd64

00:01:07

passed #1650329
amd64 libvirt
unit:clang:freebsd12:amd64

00:01:08

passed #1650323
amd64 linux
unit:clang:tsan

00:01:28

passed #1650310
amd64 linux
unit:gcc:alpine3.13:amd64

00:00:47

passed #1650320
amd64 linux
unit:gcc:asan

00:01:13

passed #1650314
amd64 linux
unit:gcc:buster:amd64

00:00:54

passed #1650311
amd64 linux
unit:gcc:centos7:amd64

00:00:38

passed #1650312
amd64 linux
unit:gcc:centos8:amd64

00:00:41

passed #1650319
amd64 linux
unit:gcc:focal:amd64

00:00:37

passed #1650324
amd64 linux
unit:gcc:mutexatomics

00:00:41

passed #1650315
amd64 linux
unit:gcc:sid:amd64

00:00:38

passed #1650316
i386 linux
unit:gcc:sid:i386

00:00:49

passed #1650326
amd64 linux
unit:gcc:softhsm2.4

00:00:40

passed #1650327
amd64 linux
unit:gcc:softhsm2.6

00:00:41

passed #1650313
amd64 linux
unit:gcc:stretch:amd64

00:00:35

passed #1650322
amd64 linux
unit:gcc:tsan

00:01:46

passed #1650317
amd64 linux
unit:gcc:tumbleweed:amd64

00:00:35

passed #1650318
amd64 linux
unit:gcc:xenial:amd64

00:00:38

passed #1650330
amd64 linux
unit:nolibtool:sid:amd64

00:00:55

 
  System
passed #1650342
amd64 linux
system:clang:asan

00:13:38

passed #1650346
amd64 linux
system:clang:buster:amd64

00:10:53

passed #1650349
amd64 libvirt
system:clang:freebsd11:amd64

00:10:41

passed #1650350
amd64 libvirt
system:clang:freebsd12:amd64

00:10:56

passed #1650344
amd64 linux
system:clang:tsan

00:15:10

passed #1650331
amd64 linux
system:gcc:alpine3.13:amd64

00:11:58

passed #1650341
amd64 linux
system:gcc:asan

00:13:24

passed #1650335
amd64 linux
system:gcc:buster:amd64

00:12:53

passed #1650332
amd64 linux
system:gcc:centos7:amd64

00:11:09

passed #1650333
amd64 linux
system:gcc:centos8:amd64

00:12:11

passed #1650340
amd64 linux
system:gcc:focal:amd64

00:11:56

passed #1650345
amd64 linux
system:gcc:mutexatomics

00:10:47

passed #1650336
amd64 linux
system:gcc:sid:amd64

00:10:36

passed #1650337
i386 linux
system:gcc:sid:i386

00:09:57

passed #1650347
amd64 linux
system:gcc:softhsm2.4

00:11:46

passed #1650348
amd64 linux
system:gcc:softhsm2.6

00:11:30

passed #1650334
amd64 linux
system:gcc:stretch:amd64

00:11:18

passed #1650343
amd64 linux
system:gcc:tsan

00:15:47

passed #1650338
amd64 linux
system:gcc:tumbleweed:amd64

00:11:38

passed #1650339
amd64 linux
system:gcc:xenial:amd64

00:11:00

passed #1650351
amd64 linux
system:nolibtool:sid:amd64

00:11:35

 
  Docs
passed #1650352
amd64 linux
docs

00:02:15

 
  Postcheck
passed #1650356
amd64 linux
cppcheck

00:00:22

passed #1650353
amd64 linux
flake8

00:00:20

passed #1650357
amd64 linux
gcov

00:00:37

75.0%
passed #1650354
amd64 linux
pylint

00:00:23

passed #1650355
amd64 linux
scan-build

00:08:42