Fix the variable checked by a post-load assertion

Instead of checking the value of the variable modified two lines earlier
(the number of SOA records present at the apex of the old version of the
zone), one of the RUNTIME_CHECK() assertions in zone_postload() checks
the number of SOA records present at the apex of the new version of the
zone, which is already checked before.  Fix the assertion by making it
check the correct variable.

(cherry picked from commit 098639dc)
79 jobs for !5168 with michal/fix-the-variable-checked-by-a-post-load-assertion-v9_16 in 20 seconds (queued for 16 seconds)
latest detached
Status Job ID Name Coverage
  Precheck
canceled #1786761
amd64 linux
autoreconf

canceled #1786763
amd64 linux
clang-format

canceled #1786764
amd64 linux
coccinelle

canceled #1786765
amd64 linux
danger

canceled #1786762
amd64 linux
misc

canceled #1786766
amd64 linux
tarball-create

 
  Build
canceled #1786780
amd64 linux
clang:asan

canceled #1786784
amd64 linux
clang:buster:amd64

canceled #1786787
amd64 libvirt
clang:freebsd12:amd64

canceled #1786788
amd64 libvirt
clang:freebsd13:amd64

canceled #1786789
amd64 libvirt
clang:openbsd:amd64

canceled #1786782
amd64 linux
clang:tsan

canceled #1786767
amd64 linux
gcc:alpine3.13:amd64

canceled #1786779
amd64 linux
gcc:asan

canceled #1786777
amd64 linux
gcc:bionic:amd64

canceled #1786771
amd64 linux
gcc:buster:amd64

canceled #1786768
amd64 linux
gcc:centos7:amd64

canceled #1786769
amd64 linux
gcc:centos8:amd64

canceled #1786778
amd64 linux
gcc:focal:amd64

canceled #1786783
amd64 linux
gcc:mutexatomics

canceled #1786773
amd64 linux
gcc:out-of-tree

canceled #1786772
amd64 linux
gcc:sid:amd64

canceled #1786775
i386 linux
gcc:sid:i386

canceled #1786785
amd64 linux
gcc:softhsm2.4

canceled #1786786
amd64 linux
gcc:softhsm2.6

canceled #1786770
amd64 linux
gcc:stretch:amd64

canceled #1786774
amd64 linux
gcc:tarball

canceled #1786781
amd64 linux
gcc:tsan

canceled #1786776
amd64 linux
gcc:tumbleweed:amd64

canceled #1786791
amd64 windows
msvc:windows:amd64

00:00:20

canceled #1786790
amd64 linux
nolibtool:sid:amd64

 
  Unit
canceled #1786803
amd64 linux
unit:clang:asan

canceled #1786807
amd64 linux
unit:clang:buster:amd64

canceled #1786810
amd64 libvirt
unit:clang:freebsd12:amd64

canceled #1786811
amd64 libvirt
unit:clang:freebsd13:amd64

canceled #1786805
amd64 linux
unit:clang:tsan

canceled #1786792
amd64 linux
unit:gcc:alpine3.13:amd64

canceled #1786802
amd64 linux
unit:gcc:asan

canceled #1786800
amd64 linux
unit:gcc:bionic:amd64

canceled #1786796
amd64 linux
unit:gcc:buster:amd64

canceled #1786793
amd64 linux
unit:gcc:centos7:amd64

canceled #1786794
amd64 linux
unit:gcc:centos8:amd64

canceled #1786801
amd64 linux
unit:gcc:focal:amd64

canceled #1786806
amd64 linux
unit:gcc:mutexatomics

canceled #1786797
amd64 linux
unit:gcc:sid:amd64

canceled #1786798
i386 linux
unit:gcc:sid:i386

canceled #1786808
amd64 linux
unit:gcc:softhsm2.4

canceled #1786809
amd64 linux
unit:gcc:softhsm2.6

canceled #1786795
amd64 linux
unit:gcc:stretch:amd64

canceled #1786804
amd64 linux
unit:gcc:tsan

canceled #1786799
amd64 linux
unit:gcc:tumbleweed:amd64

canceled #1786812
amd64 linux
unit:nolibtool:sid:amd64

 
  System
canceled #1786824
amd64 linux
system:clang:asan

canceled #1786828
amd64 linux
system:clang:buster:amd64

canceled #1786831
amd64 libvirt
system:clang:freebsd12:amd64

canceled #1786832
amd64 libvirt
system:clang:freebsd13:amd64

canceled #1786826
amd64 linux
system:clang:tsan

canceled #1786813
amd64 linux
system:gcc:alpine3.13:amd64

canceled #1786823
amd64 linux
system:gcc:asan

canceled #1786821
amd64 linux
system:gcc:bionic:amd64

canceled #1786817
amd64 linux
system:gcc:buster:amd64

canceled #1786814
amd64 linux
system:gcc:centos7:amd64

canceled #1786815
amd64 linux
system:gcc:centos8:amd64

canceled #1786822
amd64 linux
system:gcc:focal:amd64

canceled #1786827
amd64 linux
system:gcc:mutexatomics

canceled #1786818
amd64 linux
system:gcc:sid:amd64

canceled #1786819
i386 linux
system:gcc:sid:i386

canceled #1786829
amd64 linux
system:gcc:softhsm2.4

canceled #1786830
amd64 linux
system:gcc:softhsm2.6

canceled #1786816
amd64 linux
system:gcc:stretch:amd64

canceled #1786825
amd64 linux
system:gcc:tsan

canceled #1786820
amd64 linux
system:gcc:tumbleweed:amd64

canceled #1786833
amd64 linux
system:nolibtool:sid:amd64

 
  Docs
canceled #1786834
amd64 linux
docs

 
  Postcheck
canceled #1786838
amd64 linux
cppcheck

canceled #1786835
amd64 linux
flake8

canceled #1786839
amd64 linux
gcov

canceled #1786836
amd64 linux
pylint

canceled #1786837
amd64 linux
scan-build