Commit 4e739538 authored by Mark Andrews's avatar Mark Andrews

Merge branch 'marka-coverity-v9_11' into 'v9_11'

Address Coverity warnings in v9 11

See merge request !3032
parents 5f90f2ac 8d0b59a5
Pipeline #33638 passed with stages
in 1 minute and 39 seconds
......@@ -118,7 +118,9 @@ my_recv(isc_task_t *task, isc_event_t *event) {
(int)dev->n, (char *)region.base);
}
isc_socket_recv(sock, &dev->region, 1, task, my_recv, event->ev_arg);
RUNTIME_CHECK(isc_socket_recv(sock, &dev->region, 1, task,
my_recv, event->ev_arg)
== ISC_R_SUCCESS);
isc_event_free(&event);
}
......@@ -146,7 +148,9 @@ my_http_get(isc_task_t *task, isc_event_t *event) {
return;
}
isc_socket_recv(sock, &dev->region, 1, task, my_recv, event->ev_arg);
RUNTIME_CHECK(isc_socket_recv(sock, &dev->region, 1, task,
my_recv, event->ev_arg)
== ISC_R_SUCCESS);
isc_event_free(&event);
}
......@@ -223,8 +227,9 @@ my_listen(isc_task_t *task, isc_event_t *event) {
newtask = NULL;
RUNTIME_CHECK(isc_task_create(manager, 0, &newtask)
== ISC_R_SUCCESS);
isc_socket_recv(dev->newsocket, &region, 1,
newtask, my_recv, event->ev_arg);
RUNTIME_CHECK(isc_socket_recv(dev->newsocket, &region, 1,
newtask, my_recv, event->ev_arg)
== ISC_R_SUCCESS);
isc_task_detach(&newtask);
} else {
printf("detaching from socket %p\n", event->ev_sender);
......
......@@ -198,12 +198,10 @@ fromstruct_nxt(ARGS_FROMSTRUCT) {
REQUIRE(type == dns_rdatatype_nxt);
REQUIRE(((dns_rdata_nxt_t *)source) != NULL);
REQUIRE(((dns_rdata_nxt_t *)source)->common.rdtype == type);
REQUIRE(((dns_rdata_nxt_t *)source)->common.rdclass == rdclass);
REQUIRE(((dns_rdata_nxt_t *)source)->typebits != NULL ||
((dns_rdata_nxt_t *)source)->len == 0);
nxt = source;
REQUIRE(nxt->common.rdtype == type);
REQUIRE(nxt->common.rdclass == rdclass);
REQUIRE(nxt->typebits != NULL || nxt->len == 0);
if (nxt->typebits != NULL && (nxt->typebits[0] & 0x80) == 0) {
REQUIRE(nxt->len <= 16);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment