1. 26 Mar, 2020 3 commits
  2. 25 Mar, 2020 11 commits
    • Ondřej Surý's avatar
      Merge branch '1679-fix-the-typecase-to-isc_stdtime_get' into 'master' · 4167eba3
      Ondřej Surý authored
      Correct the typecast of .tv_sec in isc_stdtime_get()
      
      Closes #1679
      
      See merge request !3294
      4167eba3
    • Ondřej Surý's avatar
      7c8179c5
    • Ondřej Surý's avatar
      Merge branch '1679-fix-the-tv_nsec_check' into 'master' · 03727c14
      Ondřej Surý authored
      Fix the tv_nsec check in isc_stdtime_get()
      
      Closes #1679
      
      See merge request !3292
      03727c14
    • Ondřej Surý's avatar
      Fix the tv_nsec check in isc_stdtime_get() · 0d06a62d
      Ondřej Surý authored
      0d06a62d
    • Ondřej Surý's avatar
      Merge branch 'ondrej/no-clang-on-debian-sid' into 'master' · 4154677f
      Ondřej Surý authored
      Rewrite .gitlab-ci.yml to have 'base_image' and other GitLab CI improvements
      
      See merge request !3279
      4154677f
    • Ondřej Surý's avatar
    • Ondřej Surý's avatar
    • Ondřej Surý's avatar
      Adjust the GitLab CI jobs to match the new images · 5f5721aa
      Ondřej Surý authored
      The custom builds (oot, asan, tsan) were mostly built using Debian sid
      amd64 image.  The problem was that this image broke too easily, because
      it's Debian "unstable" after all.
      
      This commit introduces "base_image" that should be most stable with
      extra bits on top (clang, coccinelle, cppcheck, ...).  Currently, that
      would be Debian buster amd64.
      
      Other changes introduced by this commit:
      
      * Change the default clang version to 10
      * Run both ASAN and TSAN with both gcc and clang compilers
      * Remove Clang Debian stretch i386 job
      5f5721aa
    • Ondřej Surý's avatar
      Merge branch 'ondrej/scan-build-10-fixes' into 'master' · d07c3d6c
      Ondřej Surý authored
      Fix new warnings reported by scan-build from LLVM/Clang 10
      
      See merge request !3285
      d07c3d6c
    • Ondřej Surý's avatar
      Fix 'Dereference of null pointer' from scan-build-10 · ddd0d356
      Ondřej Surý authored
      These are mostly false positives, the clang-analyzer FAQ[1] specifies
      why and how to fix it:
      
      > The reason the analyzer often thinks that a pointer can be null is
      > because the preceding code checked compared it against null. So if you
      > are absolutely sure that it cannot be null, remove the preceding check
      > and, preferably, add an assertion as well.
      
      The 4 warnings reported are:
      
      dnssec-cds.c:781:4: warning: Access to field 'base' results in a dereference of a null pointer (loaded from variable 'buf')
                              isc_buffer_availableregion(buf, &r);
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/buffer.h:996:36: note: expanded from macro 'isc_buffer_availableregion'
                                         ^
      /builds/isc-projects/bind9/lib/isc/include/isc/buffer.h:821:16: note: expanded from macro 'ISC__BUFFER_AVAILABLEREGION'
                      (_r)->base = isc_buffer_used(_b);              \
                                   ^~~~~~~~~~~~~~~~~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/buffer.h:152:29: note: expanded from macro 'isc_buffer_used'
              ((void *)((unsigned char *)(b)->base + (b)->used)) /*d*/
                                         ^~~~~~~~~
      1 warning generated.
      
      --
      
      byname_test.c:308:34: warning: Access to field 'fwdtable' results in a dereference of a null pointer (loaded from variable 'view')
                      RUNTIME_CHECK(dns_fwdtable_add(view->fwdtable, dns_rootname,
                                                     ^~~~~~~~~~~~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/util.h:318:52: note: expanded from macro 'RUNTIME_CHECK'
                                                         ^~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/error.h:50:21: note: expanded from macro 'ISC_ERROR_RUNTIMECHECK'
              ((void)(ISC_LIKELY(cond) ||  \
                                 ^~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/likely.h:23:43: note: expanded from macro 'ISC_LIKELY'
                                                  ^
      1 warning generated.
      
      --
      
      ./rndc.c:255:6: warning: Dereference of null pointer (loaded from variable 'host')
              if (*host == '/') {
                  ^~~~~
      1 warning generated.
      
      --
      
      ./main.c:1254:9: warning: Access to field 'sctx' results in a dereference of a null pointer (loaded from variable 'named_g_server')
              sctx = named_g_server->sctx;
                     ^~~~~~~~~~~~~~~~~~~~
      1 warning generated.
      
      References:
      1. https://clang-analyzer.llvm.org/faq.html#null_pointer
      ddd0d356
    • Ondřej Surý's avatar
      Fix 'Dead nested assignment's from scan-build-10 · 262f087b
      Ondřej Surý authored
      The 3 warnings reported are:
      
      os.c:872:7: warning: Although the value stored to 'ptr' is used in the enclosing expression, the value is never actually read from 'ptr'
              if ((ptr = strtok_r(command, " \t", &last)) == NULL) {
                   ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      1 warning generated.
      
      --
      
      rpz.c:1117:10: warning: Although the value stored to 'zbits' is used in the enclosing expression, the value is never actually read from 'zbits'
              return (zbits &= x);
                      ^        ~
      1 warning generated.
      
      --
      
      openssleddsa_link.c:532:10: warning: Although the value stored to 'err' is used in the enclosing expression, the value is never actually read from 'err'
              while ((err = ERR_get_error()) != 0) {
                      ^     ~~~~~~~~~~~~~~~
      1 warning generated.
      262f087b
  3. 24 Mar, 2020 8 commits
  4. 20 Mar, 2020 10 commits
  5. 19 Mar, 2020 5 commits
  6. 18 Mar, 2020 3 commits