1. 20 Jun, 2019 3 commits
  2. 19 Jun, 2019 12 commits
  3. 18 Jun, 2019 4 commits
    • Michał Kępień's avatar
      Merge branch '1088-always-fail-a-system-test-if-crashes-are-detected' into 'master' · 5a941fbd
      Michał Kępień authored
      Always fail a system test if crashes are detected
      
      Closes #1088
      
      See merge request !2041
      5a941fbd
    • Michał Kępień's avatar
      Always fail a system test if crashes are detected · 7706f229
      Michał Kępień authored
      In certain situations (e.g. a named instance crashing upon shutdown in a
      system test which involves shutting down a server and restarting it
      afterwards), a system test may succeed despite a named crash being
      triggered.  This must never be the case.  Extend run.sh to mark a test
      as failed if core dumps or log lines indicating assertion failures are
      detected (the latter is only an extra measure aimed at test environments
      in which core dumps are not generated; note that some types of crashes,
      e.g. segmentation faults, will not be detected using this method alone).
      7706f229
    • Michał Kępień's avatar
      Merge branch 'michal/fix-transfer-statistics-extraction' into 'master' · 42cc7f54
      Michał Kępień authored
      Fix transfer statistics extraction
      
      See merge request !2038
      42cc7f54
    • Michał Kępień's avatar
      Fix transfer statistics extraction · fab67c07
      Michał Kępień authored
      Make the get_named_xfer_stats() helper shell function more precise in
      order to prevent it from matching the wrong lines as that may trigger
      false positives for the "ixfr" and "xfer" system tests.  As an example,
      the regular expression responsible for extracting the number of bytes
      transmitted throughout an entire zone transfer could also match a line
      containing the following string:
      
          transfer of '<zone-name>/IN': sending TCP message of <integer> bytes
      
      However, such a line is not one summarizing a zone transfer.
      
      Also simplify both get_dig_xfer_stats() and get_named_xfer_stats() by
      eliminating the need for "echo" statements in them.
      fab67c07
  4. 17 Jun, 2019 4 commits
  5. 13 Jun, 2019 3 commits
  6. 11 Jun, 2019 10 commits
    • Michał Kępień's avatar
      Merge branch 'michal/address-compilation-warnings-for-O3-builds' into 'master' · cd3b6560
      Michał Kępień authored
      Address compilation warnings for -O3 builds
      
      See merge request !1994
      cd3b6560
    • Michał Kępień's avatar
      Address GCC 9.1 -O3 compilation warnings · ce796ac1
      Michał Kępień authored
      Compiling with -O3 triggers the following warnings with GCC 9.1:
      
          task.c: In function ‘isc_taskmgr_create’:
          task.c:1384:43: warning: ‘%04u’ directive output may be truncated writing between 4 and 10 bytes into a region of size 6 [-Wformat-truncation=]
           1384 |   snprintf(name, sizeof(name), "isc-worker%04u", i);
                |                                           ^~~~
          task.c:1384:32: note: directive argument in the range [0, 4294967294]
           1384 |   snprintf(name, sizeof(name), "isc-worker%04u", i);
                |                                ^~~~~~~~~~~~~~~~
          task.c:1384:3: note: ‘snprintf’ output between 15 and 21 bytes into a destination of size 16
           1384 |   snprintf(name, sizeof(name), "isc-worker%04u", i);
                |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      
          private_test.c: In function ‘private_nsec3_totext_test’:
          private_test.c:110:9: warning: array subscript 4 is outside array bounds of ‘uint32_t[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds]
            110 |  while (*sp == '\0' && slen > 0) {
                |         ^~~
          private_test.c:103:11: note: while referencing ‘salt’
            103 |  uint32_t salt;
                |           ^~~~
      
      Prevent these warnings from being triggered by increasing the size of
      the relevant array (task.c) and reordering conditions (private_test.c).
      ce796ac1
    • Witold Krecicki's avatar
      Address GCC 8.3 -O3 compilation warning · 44e6bb8b
      Witold Krecicki authored
      Compiling with -O3 triggers the following warning with GCC 8.3:
      
          driver.c: In function ‘dlz_findzonedb’:
          driver.c:191:29: warning: ‘%u’ directive output may be truncated writing between 1 and 5 bytes into a region of size between 0 and 99 [-Wformat-truncation=]
            snprintf(buffer, size, "%s#%u", addr_buf, port);
                                       ^~
          driver.c:191:25: note: directive argument in the range [0, 65535]
            snprintf(buffer, size, "%s#%u", addr_buf, port);
                                   ^~~~~~~
          driver.c:191:2: note: ‘snprintf’ output between 3 and 106 bytes into a destination of size 100
            snprintf(buffer, size, "%s#%u", addr_buf, port);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      
      Increase the size of the relevant array to prevent this warning from
      being triggered.
      44e6bb8b
    • Michał Kępień's avatar
      Make some build jobs use -O3 optimizations · 35694878
      Michał Kępień authored
      Change the compiler optimization level for Debian sid build jobs from
      -O2 to -O3 in order to enable triggering compilation warnings which are
      not raised when -O2 is used.
      35694878
    • Witold Krecicki's avatar
      Merge branch '1070-fix-zonemgr-unreachablecache' into 'master' · 1eb7a9e1
      Witold Krecicki authored
      Resolve "Use zonemgr unreachable cache more effectively"
      
      Closes #1070
      
      See merge request !2017
      1eb7a9e1
    • Ondřej Surý's avatar
    • Witold Krecicki's avatar
      Add Gitlab CI job with pthread_rwlock · 5adc0baa
      Witold Krecicki authored
      5adc0baa
    • Witold Krecicki's avatar
      In dns_zonemgr_unreachable use atomics to avoid unnecessary · 68eb9a7c
      Witold Krecicki authored
      write locking.
      
      Unreachable cache in zonemgr is realized as an static LRU list.
      When we 'use' an entry we need to update the last-used time, we
      can use atomics to do so without the necessity to upgrading
      read-lock to write-lock.
      68eb9a7c
    • Evan Hunt's avatar
      Merge branch '1082-fix-symtab-error' into 'master' · 34db730e
      Evan Hunt authored
      allocate memory for symtab keys
      
      Closes #1082
      
      See merge request !2026
      34db730e
    • Evan Hunt's avatar
      allocate memory for symtab keys · 8136b09f
      Evan Hunt authored
      this prevents an intermittent failure when conflicts between
      static and initializing keys are not detected by named-checkconf.
      8136b09f
  7. 10 Jun, 2019 4 commits