win32utils/Configure needs improvement
Description
win32utils/Configure isn't written in "good" Perl
Request
-
General rewritting for clarity -
Refactoring for maintainability -
add use warnings
(and fix all of the spewage that's sure to create) -
other errors, as discovered -
only explicitly requires Perl 5.0.0 but uses the smartmatch operator ( ~~
) which wasn't introduced until 5.10.0. Note that this is effectively inconsequential because Perl 5.10.0 was released almost nine years ago. -
when attempting to infer the VCRedist path, @vcpaths
is initialized as a list containing a hashref, which is then later treated as a string. This is almost certainly just an initialization error rather than an indirect way of getting a 'HASH(0x.........)' string onto the list.
-