Always check the return from isc_refcount_decrement.

Created isc_refcount_decrement_expect macro to test conditionally
the return value to ensure it is in expected range.  Converted
unchecked isc_refcount_decrement to use isc_refcount_decrement_expect.
Converted INSIST(isc_refcount_decrement()...) to isc_refcount_decrement_expect.
Status Job ID Name Coverage
  Precheck
passed #453541
amd64 linux
🐞:sid:amd64

00:03:01

passed #453539
amd64 linux
autoreconf:sid:amd64

00:00:20

passed #453540
amd64 linux
misc:sid:amd64

00:00:17

 
  Build
passed #453554
amd64 linux
asan:sid:amd64

00:03:51

passed #453560
amd64 freebsd
clang:freebsd11.3:amd64

00:01:06

passed #453561
amd64 freebsd
clang:freebsd12.0:amd64

00:00:57

passed #453562
amd64 openbsd
clang:openbsd6.5:amd64

00:06:26

passed #453557
amd64 linux
clang:stretch:amd64

00:01:53

passed #453558
i386 linux
clang:stretch:i386

00:01:48

passed #453542
amd64 linux
gcc:alpine3.10:amd64

00:01:58

passed #453553
amd64 linux
gcc:bionic:amd64

00:02:05

passed #453548
amd64 linux
gcc:buster:amd64

00:02:11

passed #453543
amd64 linux
gcc:centos6:amd64

00:01:58

passed #453544
amd64 linux
gcc:centos7:amd64

00:01:42

passed #453545
amd64 linux
gcc:centos8:amd64

00:02:14

passed #453551
amd64 linux
gcc:fedora30:amd64

00:02:01

passed #453546
amd64 linux
gcc:jessie:amd64

00:01:41

passed #453549
amd64 linux
gcc:sid:amd64

00:03:17

passed #453550
i386 linux
gcc:sid:i386

00:02:05

passed #453547
amd64 linux
gcc:stretch:amd64

00:02:10

passed #453552
amd64 linux
gcc:xenial:amd64

00:01:44

passed #453564
amd64 windows
msvc:windows:amd64

00:02:24

passed #453556
amd64 linux
mutexatomics:sid:amd64

00:02:07

passed #453563
amd64 linux
nolibtool:sid:amd64

00:02:37

passed #453559
amd64 linux
pkcs11:sid:amd64

00:02:11

passed #453555
amd64 linux
rwlock:sid:amd64

00:02:17

 
  Unit
passed #453577
amd64 linux
unit:asan:sid:amd64

00:03:58

passed #453581
amd64 freebsd
unit:clang:freebsd11.3:amd64

00:00:29

passed #453582
amd64 freebsd
unit:clang:freebsd12.0:amd64

00:01:08

passed #453579
amd64 linux
unit:clang:stretch:amd64

00:00:50

passed #453606
linux amd64
unit:gcc:alpine3.10:amd64

00:02:14

passed #453576
amd64 linux
unit:gcc:bionic:amd64

00:00:50

passed #453571
amd64 linux
unit:gcc:buster:amd64

00:01:24

passed #453566
amd64 linux
unit:gcc:centos6:amd64

00:00:41

passed #453567
amd64 linux
unit:gcc:centos7:amd64

00:00:51

passed #453568
amd64 linux
unit:gcc:centos8:amd64

00:00:55

passed #453574
amd64 linux
unit:gcc:fedora30:amd64

00:01:23

passed #453569
amd64 linux
unit:gcc:jessie:amd64

00:00:30

passed #453572
amd64 linux
unit:gcc:sid:amd64

00:01:20

passed #453573
i386 linux
unit:gcc:sid:i386

00:01:54

passed #453570
amd64 linux
unit:gcc:stretch:amd64

00:00:51

passed #453575
amd64 linux
unit:gcc:xenial:amd64

00:00:44

passed #453583
amd64 linux
unit:nolibtool:sid:amd64

00:01:39

passed #453580
amd64 linux
unit:pkcs11:sid:amd64

00:01:29

passed #453578
amd64 linux
unit:rwlock:sid:amd64

00:01:00

failed #453565
amd64 linux
unit:gcc:alpine3.10:amd64

00:02:51

 
  System
passed #453596
amd64 linux
system:asan:sid:amd64

00:09:17

passed #453610
freebsd amd64
system:clang:freebsd11.3:amd64

00:09:33

passed #453609
freebsd amd64
system:clang:freebsd12.0:amd64

00:09:38

passed #453884
amd64 linux
system:gcc:alpine3.10:amd64

00:08:12

passed #453595
amd64 linux
system:gcc:bionic:amd64

00:06:55

passed #453590
amd64 linux
system:gcc:buster:amd64

00:07:25

passed #453585
amd64 linux
system:gcc:centos6:amd64

00:07:14

passed #453586
amd64 linux
system:gcc:centos7:amd64

00:07:31

passed #453587
amd64 linux
system:gcc:centos8:amd64

00:07:21

passed #453593
amd64 linux
system:gcc:fedora30:amd64

00:07:39

passed #453588
amd64 linux
system:gcc:jessie:amd64

00:07:12

passed #453591
amd64 linux
system:gcc:sid:amd64

00:07:48

passed #453592
i386 linux
system:gcc:sid:i386

00:07:55

passed #453607
linux amd64
system:gcc:stretch:amd64

00:06:28

passed #453594
amd64 linux
system:gcc:xenial:amd64

00:06:43

passed #453601
amd64 linux
system:nolibtool:sid:amd64

00:08:23

passed #453598
amd64 linux
system:pkcs11:sid:amd64

00:08:41

passed #453597
amd64 linux
system:rwlock:sid:amd64

00:08:15

failed #453599
amd64 freebsd
system:clang:freebsd11.3:amd64

00:08:26

failed #453600
amd64 freebsd
system:clang:freebsd12.0:amd64

01:10:10

failed #453810
amd64 linux
system:gcc:alpine3.10:amd64

00:08:41

failed #453608
linux amd64
system:gcc:alpine3.10:amd64

00:13:35

failed #453878
linux amd64
system:gcc:alpine3.10:amd64

00:08:44

failed #453584
amd64 linux
system:gcc:alpine3.10:amd64

00:08:50

failed #453589
amd64 linux
system:gcc:stretch:amd64

00:07:10

 
  Docs
passed #453602
amd64 linux
docs:sid:amd64

00:01:02

 
  Postcheck
passed #453604
amd64 linux
cppcheck:gcc:sid:amd64

00:02:31

passed #453603
amd64 linux
scan-build:buster:amd64

00:10:46