Don't issue ns_client_endrequest on a NS_CLIENTSTATE_READY client.

Fix a potential assertion failure on shutdown in ns__client_endrequest.
Scenario:
1. We are shutting down, interface->clientmgr is gone.
2. We receive a packet, it gets through ns__client_request
3. mgr == NULL, return
4. isc_nmhandle_detach calls ns_client_reset_cb
5. ns_client_reset_cb calls ns_client_endrequest
6. INSIST(client->state == NS_CLIENTSTATE_WORKING ||
          client->state == NS_CLIENTSTATE_RECURSING) is not met
   - we haven't started processing this packet so
   client->state == NS_CLIENTSTATE_READY.
As a solution - don't do anything in ns_client_reset_cb if the client
is still in READY state.
80 jobs for !3077 with 1623-assertion-failure-ns-client-endrequest in 19 minutes and 43 seconds (queued for 5 seconds)
detached
Status Job ID Name Coverage
  Precheck
passed #687270
amd64 linux
🐞:sid:amd64

00:03:36

passed #687269
amd64 linux
💾:sid:amd64

00:00:20

passed #687267
amd64 linux
autoreconf:sid:amd64

00:00:33

passed #687268
amd64 linux
misc:sid:amd64

00:00:16

 
  Build
passed #687286
amd64 linux
asan:sid:amd64

00:02:06

passed #687293
amd64 freebsd
clang:freebsd11.3:amd64

00:01:07

passed #687294
amd64 freebsd
clang:freebsd12.0:amd64

00:00:59

passed #687295
amd64 libvirt
clang:openbsd6.6:amd64

00:04:38

passed #687290
amd64 linux
clang:stretch:amd64

00:02:02

passed #687291
i386 linux
clang:stretch:i386

00:01:46

passed #687271
amd64 linux
gcc:alpine3.11:amd64

00:02:11

passed #687285
amd64 linux
gcc:bionic:amd64

00:01:50

passed #687277
amd64 linux
gcc:buster:amd64

00:01:53

passed #687272
amd64 linux
gcc:centos6:amd64

00:01:47

passed #687273
amd64 linux
gcc:centos7:amd64

00:02:17

passed #687274
amd64 linux
gcc:centos8:amd64

00:02:05

passed #687283
amd64 linux
gcc:fedora31:amd64

00:02:27

passed #687275
amd64 linux
gcc:jessie:amd64

00:01:43

passed #687278
amd64 linux
gcc:sid:amd64

00:02:26

passed #687280
arm64 linux
gcc:sid:arm64

00:04:01

passed #687281
i386 linux
gcc:sid:i386

00:01:08

passed #687276
amd64 linux
gcc:stretch:amd64

00:01:53

passed #687282
amd64 linux
gcc:tumbleweed:amd64

00:01:55

passed #687284
amd64 linux
gcc:xenial:amd64

00:01:51

passed #687297
amd64 windows
msvc:windows:amd64

00:03:11

passed #687289
amd64 linux
mutexatomics:sid:amd64

00:01:50

passed #687296
amd64 linux
nolibtool:sid:amd64

00:02:22

passed #687279
amd64 linux
oot:sid:amd64

00:01:46

passed #687292
amd64 linux
pkcs11:sid:amd64

00:01:38

passed #687288
amd64 linux
rwlock:sid:amd64

00:01:48

passed #687287
amd64 linux
tsan:buster:amd64

00:03:08

 
  Unit
passed #687312
amd64 linux
unit:asan:sid:amd64

00:01:00

passed #687318
amd64 freebsd
unit:clang:freebsd11.3:amd64

00:00:34

passed #687319
amd64 freebsd
unit:clang:freebsd12.0:amd64

00:00:34

passed #687316
amd64 linux
unit:clang:stretch:amd64

00:00:54

passed #687298
amd64 linux
unit:gcc:alpine3.11:amd64

00:01:00

passed #687311
amd64 linux
unit:gcc:bionic:amd64

00:00:56

passed #687304
amd64 linux
unit:gcc:buster:amd64

00:00:57

passed #687299
amd64 linux
unit:gcc:centos6:amd64

00:00:57

passed #687300
amd64 linux
unit:gcc:centos7:amd64

00:00:53

passed #687301
amd64 linux
unit:gcc:centos8:amd64

00:00:41

passed #687309
amd64 linux
unit:gcc:fedora31:amd64

00:00:52

passed #687302
amd64 linux
unit:gcc:jessie:amd64

00:00:32

passed #687305
amd64 linux
unit:gcc:sid:amd64

00:00:58

passed #687306
arm64 linux
unit:gcc:sid:arm64

00:01:08

passed #687307
i386 linux
unit:gcc:sid:i386

00:01:03

passed #687303
amd64 linux
unit:gcc:stretch:amd64

00:00:55

passed #687308
amd64 linux
unit:gcc:tumbleweed:amd64

00:00:44

passed #687310
amd64 linux
unit:gcc:xenial:amd64

00:00:56

failed #687315
amd64 linux allowed to fail
unit:mutexatomics:sid:amd64

00:10:56

passed #687320
amd64 linux
unit:nolibtool:sid:amd64

00:01:13

passed #687317
amd64 linux
unit:pkcs11:sid:amd64

00:00:58

passed #687314
amd64 linux
unit:rwlock:sid:amd64

00:00:59

failed #687313
amd64 linux allowed to fail
unit:tsan:buster:amd64

00:02:26

 
  System
passed #687335
amd64 linux
system:asan:sid:amd64

00:13:26

passed #687340
amd64 freebsd
system:clang:freebsd11.3:amd64

00:12:50

passed #687341
amd64 freebsd
system:clang:freebsd12.0:amd64

00:12:55

passed #687321
amd64 linux
system:gcc:alpine3.11:amd64

00:12:48

passed #687334
amd64 linux
system:gcc:bionic:amd64

00:11:27

passed #687327
amd64 linux
system:gcc:buster:amd64

00:11:36

passed #687322
amd64 linux
system:gcc:centos6:amd64

00:11:51

passed #687323
amd64 linux
system:gcc:centos7:amd64

00:11:17

passed #687324
amd64 linux
system:gcc:centos8:amd64

00:12:10

passed #687332
amd64 linux
system:gcc:fedora31:amd64

00:11:57

passed #687325
amd64 linux
system:gcc:jessie:amd64

00:12:21

passed #687328
amd64 linux
system:gcc:sid:amd64

00:11:46

passed #687329
arm64 linux
system:gcc:sid:arm64

00:12:23

passed #687330
i386 linux
system:gcc:sid:i386

00:12:11

passed #687326
amd64 linux
system:gcc:stretch:amd64

00:10:44

passed #687331
amd64 linux
system:gcc:tumbleweed:amd64

00:12:12

passed #687333
amd64 linux
system:gcc:xenial:amd64

00:11:14

passed #687338
amd64 linux
system:mutexatomics:sid:amd64

00:12:09

passed #687342
amd64 linux
system:nolibtool:sid:amd64

00:12:32

passed #687339
amd64 linux
system:pkcs11:sid:amd64

00:11:22

passed #687337
amd64 linux
system:rwlock:sid:amd64

00:12:13

failed #687336
amd64 linux allowed to fail
system:tsan:buster:amd64

00:15:54

 
  Docs
passed #687343
amd64 linux
docs:sid:amd64

00:01:11

 
  Postcheck
passed #687345
amd64 linux
cppcheck:gcc:sid:amd64

00:01:37

passed #687346
arm64 linux
cppcheck:gcc:sid:arm64

00:02:20

passed #687344
amd64 linux
scan-build:buster:amd64

00:10:23

 
Name Stage Failure
failed
system:tsan:buster:amd64 System
make: *** [Makefile:486: test] Error 1
Running after script...
$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts...
bin/tests/system/*/tsan.*: found 18 matching files
bin/tests/system/*/*/tsan.*: found 246 matching files

tsan/: found 181 matching files

Uploading artifacts to coordinator... ok
id=687336 responseStatus=201 Created token=Ng72yPNy
ERROR: Job failed: exit code 1
failed
unit:mutexatomics:sid:amd64 Unit
Generating kyua_html/lib_ns_tests_query_test_main.html
Generating kyua_html/report.css
Generating kyua_html/index.html
Uploading artifacts...
kyua.log: found 1 matching files
kyua.results: found 1 matching files

kyua_html/: found 69 matching files

Uploading artifacts to coordinator... ok
id=687315 responseStatus=201 Created token=TZLWGrd9
ERROR: Job failed: exit code 1
failed
unit:tsan:buster:amd64 Unit
$ find lib -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts...
lib/*/tests/tsan.*: found 3 matching files
tsan/: found 13 matching files

kyua.log: found 1 matching files

kyua.results: found 1 matching files

WARNING: kyua_html/: no matching files
Uploading artifacts to coordinator... ok
id=687313 responseStatus=201 Created token=PCoaSCxR
ERROR: Job failed: exit code 1