Retire predecessor when creating successor

When creating the successor, the current active key (predecessor)
should change its goal state to HIDDEN.

Also add two useful debug logs in the keymgr_key_rollover function.
77 jobs for !3538 with 1845-1846-keyrollver-bugs in 32 minutes and 49 seconds (queued for 4 seconds)
detached
Status Job ID Name Coverage
  Autoconf
passed #885528
amd64 linux
autoreconf

00:01:02

 
  Precheck
passed #885530
amd64 linux
clang-format

00:00:59

passed #885531
amd64 linux
coccinelle

00:04:48

passed #885529
amd64 linux
misc

00:00:48

 
  Build
passed #885547
amd64 linux
clang:asan

00:03:29

passed #885551
amd64 linux
clang:buster:amd64

00:02:13

passed #885553
amd64 libvirt
clang:freebsd11.3:amd64

00:01:53

passed #885554
amd64 libvirt
clang:freebsd12.1:amd64

00:01:57

passed #885555
amd64 libvirt
clang:openbsd6.6:amd64

00:03:15

passed #885549
amd64 linux
clang:tsan

00:02:40

passed #885532
amd64 linux
gcc:alpine3.11:amd64

00:02:15

passed #885546
amd64 linux
gcc:asan

00:03:08

passed #885545
amd64 linux
gcc:bionic:amd64

00:02:15

passed #885537
amd64 linux
gcc:buster:amd64

00:02:19

passed #885533
amd64 linux
gcc:centos6:amd64

00:01:58

passed #885534
amd64 linux
gcc:centos7:amd64

00:01:57

passed #885535
amd64 linux
gcc:centos8:amd64

00:02:50

passed #885543
amd64 linux
gcc:fedora31:amd64

00:02:04

passed #885550
amd64 linux
gcc:mutexatomics

00:02:11

passed #885539
amd64 linux
gcc:out-of-tree

00:02:19

passed #885552
amd64 linux
gcc:pkcs11

00:01:51

passed #885538
amd64 linux
gcc:sid:amd64

00:02:27

passed #885540
arm64 linux
gcc:sid:arm64

00:02:05

passed #885541
i386 linux
gcc:sid:i386

00:02:08

passed #885536
amd64 linux
gcc:stretch:amd64

00:02:19

passed #885548
amd64 linux
gcc:tsan

00:02:29

passed #885542
amd64 linux
gcc:tumbleweed:amd64

00:02:01

passed #885544
amd64 linux
gcc:xenial:amd64

00:02:09

 
  Unit
passed #885570
amd64 linux
unit:clang:asan

00:02:20

passed #885574
amd64 linux
unit:clang:buster:amd64

00:01:58

passed #885576
amd64 libvirt
unit:clang:freebsd11.3:amd64

00:02:07

passed #885577
amd64 libvirt
unit:clang:freebsd12.1:amd64

00:02:04

failed #885572
amd64 linux allowed to fail
unit:clang:tsan

00:01:01

passed #885556
amd64 linux
unit:gcc:alpine3.11:amd64

00:02:07

passed #885569
amd64 linux
unit:gcc:asan

00:02:13

passed #885568
amd64 linux
unit:gcc:bionic:amd64

00:01:57

passed #885561
amd64 linux
unit:gcc:buster:amd64

00:02:01

passed #885557
amd64 linux
unit:gcc:centos6:amd64

00:02:06

passed #885558
amd64 linux
unit:gcc:centos7:amd64

00:01:39

passed #885559
amd64 linux
unit:gcc:centos8:amd64

00:01:46

passed #885566
amd64 linux
unit:gcc:fedora31:amd64

00:01:50

passed #885573
amd64 linux
unit:gcc:mutexatomics

00:01:52

passed #885575
amd64 linux
unit:gcc:pkcs11

00:01:55

passed #885562
amd64 linux
unit:gcc:sid:amd64

00:01:50

passed #885563
arm64 linux
unit:gcc:sid:arm64

00:01:12

passed #885564
i386 linux
unit:gcc:sid:i386

00:01:47

passed #885560
amd64 linux
unit:gcc:stretch:amd64

00:02:03

failed #885571
amd64 linux allowed to fail
unit:gcc:tsan

00:05:18

passed #885565
amd64 linux
unit:gcc:tumbleweed:amd64

00:01:38

passed #885567
amd64 linux
unit:gcc:xenial:amd64

00:01:59

 
  System
passed #885592
amd64 linux
system:clang:asan

00:18:27

passed #885596
amd64 linux
system:clang:buster:amd64

00:16:37

passed #885598
amd64 libvirt
system:clang:freebsd11.3:amd64

00:13:28

passed #885599
amd64 libvirt
system:clang:freebsd12.1:amd64

00:13:21

failed #885594
amd64 linux allowed to fail
system:clang:tsan

00:10:54

failed #885578
amd64 linux
system:gcc:alpine3.11:amd64

00:17:31

passed #885591
amd64 linux
system:gcc:asan

00:15:55

passed #885590
amd64 linux
system:gcc:bionic:amd64

00:15:43

passed #885583
amd64 linux
system:gcc:buster:amd64

00:14:24

passed #885579
amd64 linux
system:gcc:centos6:amd64

00:15:21

passed #885580
amd64 linux
system:gcc:centos7:amd64

00:17:41

passed #885581
amd64 linux
system:gcc:centos8:amd64

00:19:41

passed #885588
amd64 linux
system:gcc:fedora31:amd64

00:17:10

passed #885595
amd64 linux
system:gcc:mutexatomics

00:13:46

passed #885597
amd64 linux
system:gcc:pkcs11

00:16:32

passed #885584
amd64 linux
system:gcc:sid:amd64

00:14:24

passed #885585
arm64 linux
system:gcc:sid:arm64

00:11:58

passed #885586
i386 linux
system:gcc:sid:i386

00:15:36

passed #885582
amd64 linux
system:gcc:stretch:amd64

00:16:17

failed #885593
amd64 linux allowed to fail
system:gcc:tsan

00:23:08

passed #885587
amd64 linux
system:gcc:tumbleweed:amd64

00:13:36

passed #885589
amd64 linux
system:gcc:xenial:amd64

00:14:29

 
  Docs
passed #885600
amd64 linux
docs

00:31:36

 
  Postcheck
passed #885604
amd64 linux
cppcheck

00:01:47

passed #885601
amd64 linux
flake8

00:01:09

passed #885602
amd64 linux
pylint

00:01:38

passed #885603
amd64 linux
scan-build

00:06:31

 
Name Stage Failure
failed
system:gcc:tsan System

$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
bin/tests/system/*/tsan.*: found 36 matching files

bin/tests/system/*/*/tsan.*: found 249 matching files

tsan/: found 216 matching files

Uploading artifacts to coordinator... ok
id=885593 responseStatus=201 Created token=Jjjsgc9F
ERROR: Job failed: exit code 1
failed
system:gcc:alpine3.11:amd64 System
I:kasp:error: mismatch publish in ns6/Kstep4.algorithm-roll.kasp.+005+03973.private (expected 19691230100000)
I:kasp:error: mismatch publish in ns6/Kstep4.algorithm-roll.kasp.+005+03973.state (expected 19691230100000)
I:kasp:error: mismatch active comment in ns6/Kstep4.algorithm-roll.kasp.+005+03973.key (expected 19691230100000)
I:kasp:error: mismatch active in ns6/Kstep4.algorithm-roll.kasp.+005+03973.private (expected 19691230100000)
I:kasp:
Uploading artifacts for failed job
Uploading artifacts...
untracked: found 3642 files

Uploading artifacts to coordinator... ok
id=885578 responseStatus=201 Created token=EiPyDpgL
ERROR: Job failed: exit code 1
failed
system:clang:tsan System

$ find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
bin/tests/system/*/tsan.*: found 726 matching files

bin/tests/system/*/*/tsan.*: found 1032 matching files

tsan/: found 1 matching files

Uploading artifacts to coordinator... ok
id=885594 responseStatus=201 Created token=JWozsXX9
ERROR: Job failed: exit code 1
failed
unit:gcc:tsan Unit
Running after_script
Running after script...
$ find lib -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
lib/*/tests/tsan.*: found 1 matching files

tsan/: found 4 matching files

Uploading artifacts to coordinator... ok
id=885571 responseStatus=201 Created token=PKoEeH6F
ERROR: Job failed: exit code 1
failed
unit:clang:tsan Unit
Running after_script
Running after script...
$ find lib -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;
Uploading artifacts for failed job
Uploading artifacts...
lib/*/tests/tsan.*: found 63 matching files

tsan/: found 1 matching files

Uploading artifacts to coordinator... ok
id=885572 responseStatus=201 Created token=P9zZWyZo
ERROR: Job failed: exit code 1