• Witold Krecicki's avatar
    Don't issue ns_client_endrequest on a NS_CLIENTSTATE_READY client. · b0888ff0
    Witold Krecicki authored
    Fix a potential assertion failure on shutdown in ns__client_endrequest.
    Scenario:
    1. We are shutting down, interface->clientmgr is gone.
    2. We receive a packet, it gets through ns__client_request
    3. mgr == NULL, return
    4. isc_nmhandle_detach calls ns_client_reset_cb
    5. ns_client_reset_cb calls ns_client_endrequest
    6. INSIST(client->state == NS_CLIENTSTATE_WORKING ||
              client->state == NS_CLIENTSTATE_RECURSING) is not met
       - we haven't started processing this packet so
       client->state == NS_CLIENTSTATE_READY.
    As a solution - don't do anything in ns_client_reset_cb if the client
    is still in READY state.
    b0888ff0
Name
Last commit
Last update
.gitlab/issue_templates Loading commit data...
bin Loading commit data...
cocci Loading commit data...
conftools/perllib/dnsconf Loading commit data...
contrib Loading commit data...
doc Loading commit data...
docutil Loading commit data...
fuzz Loading commit data...
lib Loading commit data...
m4 Loading commit data...
make Loading commit data...
unit Loading commit data...
util Loading commit data...
win32utils Loading commit data...
.clang-format Loading commit data...
.clang-format.headers Loading commit data...
.dir-locals.el Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitlab-ci.yml Loading commit data...
.uncrustify.cfg Loading commit data...
CHANGES Loading commit data...
CODE_OF_CONDUCT Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
CONTRIBUTING Loading commit data...
CONTRIBUTING.md Loading commit data...
COPYRIGHT Loading commit data...
HISTORY Loading commit data...
HISTORY.md Loading commit data...
Kyuafile Loading commit data...
LICENSE Loading commit data...
Makefile.in Loading commit data...
OPTIONS Loading commit data...
OPTIONS.md Loading commit data...
PLATFORMS Loading commit data...
PLATFORMS.md Loading commit data...
README Loading commit data...
README.md Loading commit data...
aclocal.m4 Loading commit data...
autogen.sh Loading commit data...
bind.keys Loading commit data...
bind.keys.h Loading commit data...
config.guess Loading commit data...
config.h.in Loading commit data...
config.h.win32 Loading commit data...
config.sub Loading commit data...
config.threads.in Loading commit data...
configure Loading commit data...
configure.ac Loading commit data...
install-sh Loading commit data...
ltmain.sh Loading commit data...
mkinstalldirs Loading commit data...
version Loading commit data...