dhcp issueshttps://gitlab.isc.org/isc-projects/dhcp/-/issues2022-03-14T07:18:21Zhttps://gitlab.isc.org/isc-projects/dhcp/-/issues/180Not buildable on OpenWRT2022-03-14T07:18:21ZPhilip PrindevilleNot buildable on OpenWRT**Not buildable on OpenWRT**
4.2.2 won't build on OpenWRT because it's not finding `<isc/boolean.h>`.
**To Reproduce**
Steps to reproduce the behavior:
1. Checkout `master` on `openwrt/packages`, and change `net/isc-dhcp/Makefile` to us...**Not buildable on OpenWRT**
4.2.2 won't build on OpenWRT because it's not finding `<isc/boolean.h>`.
**To Reproduce**
Steps to reproduce the behavior:
1. Checkout `master` on `openwrt/packages`, and change `net/isc-dhcp/Makefile` to use version `4.4.2`.
2. Build
3. See error
4.
**Expected behavior**
It should build as 4.4.1 did.
**Environment:**
- ISC DHCP version: 4.4.2
- OS: OpenWRT master cross-built on Ubuntu 20.04.02 LTS
- `CONFIG_PACKAGE_isc-dhcp-server-ipv6=y` should be configured
**Additional Information**
Build fails as:
```
make[5]: Entering directory '/home/philipp/lede/build_dir/target-x86_64_musl/isc-dhcp-ipv6/dhcp-4.4.2/common'
x86_64-openwrt-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../includes -I.. -DLOCALSTATEDIR='"/var"' -I/home/philipp/lede/staging_dir/toolchain-x86_64_gcc-8.4.0_musl/usr/include -I/home/philipp/lede/staging_dir/toolchain-x86_64_gcc-8.4.0_musl/include/fortify -I/home/philipp/lede/staging_dir/toolchain-x86_64_gcc-8.4.0_musl/include -Os -pipe -fno-caller-saves -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable -Wno-error=unused-result -fmacro-prefix-map=/home/philipp/lede/build_dir/target-x86_64_musl/isc-dhcp-ipv6/dhcp-4.4.2=dhcp-4.4.2 -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -fcommon -I../includes -I/home/philipp/lede/build_dir/target-x86_64_musl/isc-dhcp-ipv6/dhcp-4.4.2/bind/include -c -o alloc.o alloc.c
In file included from ../includes/dhcpd.h:91,
from alloc.c:29:
../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
#include <isc/boolean.h>
^~~~~~~~~~~~~~~
compilation terminated.
make[5]: *** [Makefile:504: alloc.o] Error 1
make[5]: Leaving directory '/home/philipp/lede/build_dir/target-x86_64_musl/isc-dhcp-ipv6/dhcp-4.4.2/common'
make[4]: *** [Makefile:563: all-recursive] Error 1
make[4]: Leaving directory '/home/philipp/lede/build_dir/target-x86_64_musl/isc-dhcp-ipv6/dhcp-4.4.2/common'
make[3]: *** [Makefile:464: all-recursive] Error 1
make[3]: Leaving directory '/home/philipp/lede/build_dir/target-x86_64_musl/isc-dhcp-ipv6/dhcp-4.4.2'
make[2]: *** [Makefile:301: /home/philipp/lede/build_dir/target-x86_64_musl/isc-dhcp-ipv6/dhcp-4.4.2/.built] Error 2
make[2]: Leaving directory '/home/philipp/lede/feeds/packages/net/isc-dhcp'
time: package/feeds/packages/isc-dhcp/ipv6/compile#93.82#21.71#108.97
ERROR: package/feeds/packages/isc-dhcp failed to build (build variant: ipv6).
make[1]: *** [package/Makefile:114: package/feeds/packages/isc-dhcp/compile] Error 1
```
See also: [OpenWRT PR 14605](https://github.com/openwrt/packages/pull/14605/files)
**Is your feature request related to a problem? Please describe.**
This doesn't cross-build any more.
**Describe the solution you'd like**
`common/Makefile.am` should include settings from `../make/includes` but doesn't.
**Describe alternatives you've considered**
See previous
**Additional context**
N/A
**Funding its development**
N/A
**Participating in development**
I'm the maintainer for ISC-DHCP in OpenWRT, so not sure what more I need to do here...
**Contacting you**
My email is listed on my gitlab account, plus you can find me on the mailing lists.4.4.3-beta1https://gitlab.isc.org/isc-projects/dhcp/-/issues/227Remove client and relay code2022-03-30T14:57:07ZTomek MrugalskiRemove client and relay codeThe client (`dhclient`) and relay (`dhcrelay`) reached its end of life. The %"4.4.3" was the last release that had them.
Now it's time to remove the code and documentation for it.The client (`dhclient`) and relay (`dhcrelay`) reached its end of life. The %"4.4.3" was the last release that had them.
Now it's time to remove the code and documentation for it.4.5.0-betahttps://gitlab.isc.org/isc-projects/dhcp/-/issues/32undefined symbols in libomapi2023-03-07T09:15:20ZEnrico Scholzundefined symbols in libomapi**Describe the bug**
Calling `dhclient` fails here with
```
dhclient: symbol lookup error: /usr/lib/libomapi.so.0: undefined symbol: dns_rootname
```
This is caused by a combination of `-Wl,-as-needed` and `-Wl,-no-add-nedded` linker...**Describe the bug**
Calling `dhclient` fails here with
```
dhclient: symbol lookup error: /usr/lib/libomapi.so.0: undefined symbol: dns_rootname
```
This is caused by a combination of `-Wl,-as-needed` and `-Wl,-no-add-nedded` linkerflags (although sounding similarly, they have diffierent semantics and latter one is the default e.g. on Fedora).
Because code in `libomapi.so` uses functionality from `libdns` and other libraries, it should be linked against them.
I fixed it with [omapilibs.patch](/uploads/ff0ba07e0db378984318714d188972e0/omapilibs.patch)
```diff
Index: dhcp-4.4.1/omapip/Makefile.am.in
===================================================================
--- dhcp-4.4.1.orig/omapip/Makefile.am.in
+++ dhcp-4.4.1/omapip/Makefile.am.in
@@ -11,6 +11,10 @@ libomapi_@A@_SOURCES = protocol.c buffer
handle.c message.c convert.c hash.c auth.c inet_addr.c \
array.c trace.c toisc.c iscprint.c isclib.c
+libomapi_@A@_LIBADD = $(BINDLIBDNSDIR)/libdns.@A@ \
+ $(BINDLIBIRSDIR)/libirs.@A@ \
+ $(BINDLIBISCCFGDIR)/libisccfg.@A@
+
man_MANS = omapi.3
EXTRA_DIST = $(man_MANS)
```
**Environment:**
- seen with OpenEmbedded `thud` (http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-connectivity/dhcp?h=thud)4.5.0-betahttps://gitlab.isc.org/isc-projects/dhcp/-/issues/233Build failure with BIND 9.16.262022-04-04T19:45:29ZFabrice FontaineBuild failure with BIND 9.16.26dhcp raises the following build failure with BIND 9.16.26:
```
In file included from ../includes/dhcpd.h:91,
from bpf.c:35:
../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
51 ...dhcp raises the following build failure with BIND 9.16.26:
```
In file included from ../includes/dhcpd.h:91,
from bpf.c:35:
../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
51 | #include <isc/boolean.h>
| ^~~~~~~~~~~~~~~
```
This issue is raised because custom `isc_boolean_t` was replaced with C standard `bool` type 3 years ago with https://gitlab.isc.org/isc-projects/bind9/-/commit/994e656977b88516d76519c437b623ddb32b0769
This is especially an issue as BIND 9.11 EOL in March, 2022 and BIND 9.16 is current Stable/ESV version.
It seems this issue was already reported in https://gitlab.isc.org/isc-projects/dhcp/-/issues/14 and https://gitlab.isc.org/isc-projects/dhcp/-/issues/180 but 4.4.3 is still failing to build when the user provides an external BIND 9.16 library (through `--with-libbind`).
Full build log: http://autobuild.buildroot.org/results/bba/bba1d0f3693cd09cd38fe6255ecd5c8702ffb698/build-end.loghttps://gitlab.isc.org/isc-projects/dhcp/-/issues/158Using ATF from Debian bullseye does not work2022-09-01T07:20:15ZBaptisteUsing ATF from Debian bullseye does not workDebian bullseye (the upcoming stable) has both ATF and Kyua:
* https://packages.debian.org/bullseye/libatf-dev
* https://packages.debian.org/bullseye/kyua
However, even after installing these packages, dhcp does not find ATF:
```
$ ./...Debian bullseye (the upcoming stable) has both ATF and Kyua:
* https://packages.debian.org/bullseye/libatf-dev
* https://packages.debian.org/bullseye/kyua
However, even after installing these packages, dhcp does not find ATF:
```
$ ./configure --with-atf
...
configure: error: Unable to find atf files in location specified
```